Skip to content

psa: Remove not needed TF-M ITS KVStore adapter #13175

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 24, 2020

Conversation

Patater
Copy link
Contributor

@Patater Patater commented Jun 23, 2020

Summary of changes

    psa: Remove not needed TF-M ITS KVStore adapter

    Targets that use Mbed for their PSA implementation
    (TARGET_MBED_PSA_SRV), rather than TF-M, do not need any adapters to
    connect TF-M and KVStore. Remove the unnecessary file its_tfm_impl.cpp.
    test: Add an experimental API config
    
    It's important we still continue to run `mbed test` tests for APIs
    considered experimental. Add a new test config which enables all
    experimental APIs for test purposes.
    
    For example, to run mbed test including experimental APIs on K64F:
        mbed test -m K64F -t GCC_ARM --app-config TESTS/configs/experimental.json

Impact of changes

Migration actions required

Documentation

None


Pull request type

[X] Patch update (Bug fix / Target update / Docs update / Test update / Refactor)
[] Feature update (New feature / Functionality change / New API)
[] Major update (Breaking change E.g. Return code change / API behaviour change)

Test results

[] No Tests required for this change (E.g docs only update)
[X] Covered by existing mbed-os tests (Greentea or Unittest)
[] Tests / results supplied as part of this PR

Reviewers


Patater added 2 commits June 23, 2020 13:22
Targets that use Mbed for their PSA implementation
(TARGET_MBED_PSA_SRV), rather than TF-M, do not need any adapters to
connect TF-M and KVStore. Remove the unnecessary file its_tfm_impl.cpp.
It's important we still continue to run `mbed test` tests for APIs
considered experimental. Add a new test config which enables all
experimental APIs for test purposes.

For example, to run mbed test including experimental APIs on K64F:
    mbed test -m K64F -t GCC_ARM --app-config TESTS/configs/experimental.json
@Patater Patater force-pushed the remove-tfm-kvstore-adapter branch from 532d0d7 to 6c9d168 Compare June 23, 2020 12:49
@ciarmcom ciarmcom requested a review from a team June 23, 2020 13:00
@ciarmcom
Copy link
Member

@Patater, thank you for your changes.
@ARMmbed/mbed-os-maintainers please review.

Copy link
Contributor

@adbridge adbridge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks OK AFAICT

@0xc0170 0xc0170 added the release-type: patch Indentifies a PR as containing just a patch label Jun 23, 2020
@0xc0170
Copy link
Contributor

0xc0170 commented Jun 24, 2020

CI started

@mbed-ci
Copy link

mbed-ci commented Jun 24, 2020

Test run: SUCCESS

Summary: 6 of 6 test jobs passed
Build number : 1
Build artifacts

@0xc0170 0xc0170 merged commit 846fbfb into ARMmbed:master Jun 24, 2020
@mergify mergify bot removed the ready for merge label Jun 24, 2020
@adbridge adbridge added release-version: 6.1.0 Release-pending and removed release-type: patch Indentifies a PR as containing just a patch Release-pending labels Jun 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants