LWIPStack: set sockets non-blocking #13205
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When sockets were opened, they were not set non-blocking, but only had their timeout set to 1ms. TCP sockets were set to non-blocking on connect or accept, but UDP sockets were left blocking with 1ms timeout. This led to unnecessary delays when checking for data from an empty UDP socket. Change sockets to be non-blocking on open instead of setting the timeout. As TCP sockets were already non-blocking, the necessary event handling is already in place, and no other changes are required.
0xc0170
previously approved these changes
Jun 30, 2020
|
Planning to add a commit which turns off the receive timeout option from lwip, to save a bit of RAM/ROM |
We no longer use the receive timeout option in lwIP, so disable it to save a small amount of ROM+RAM.
|
@kjbracey-arm, thank you for your changes. |
0xc0170
approved these changes
Jun 30, 2020
|
CI started |
Test run: SUCCESSSummary: 6 of 6 test jobs passed |
adbridge
added
release-version: 6.2.0
Release-pending
and removed
release-type: patch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of changes
When sockets were opened, they were not set non-blocking, but only had their timeout set to 1ms.
TCP sockets were set to non-blocking on connect or accept, but UDP sockets were left blocking with 1ms timeout.
This led to unnecessary delays when checking for data from an empty UDP socket.
Change sockets to be non-blocking on open instead of setting the timeout. As TCP sockets were already non-blocking, the necessary event handling is already in place, and no other changes are required.
Impact of changes
Fixes #13197
Migration actions required
Documentation
None
Pull request type
Test results
Reviewers