-
Notifications
You must be signed in to change notification settings - Fork 3k
Implement polymorphism for DigitalIn/Out/InOut #13209
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
c640915
Implement polymorphism for DigitalIn
AGlass0fMilk 2e6a552
Implement polymorphism for DigitalOut
AGlass0fMilk 326f5bb
Implement polymorphism for DigitalInOut
AGlass0fMilk 78e33b0
astyle fixes
AGlass0fMilk 78cfad9
Remove virtual from interface operator definitions
AGlass0fMilk File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,55 @@ | ||
/* | ||
* Mbed-OS Microcontroller Library | ||
* Copyright (c) 2021 Embedded Planet | ||
* Copyright (c) 2021 ARM Limited | ||
* SPDX-License-Identifier: Apache-2.0 | ||
* | ||
* Licensed under the Apache License, Version 2.0 (the "License"); | ||
* you may not use this file except in compliance with the License. | ||
* You may obtain a copy of the License at | ||
* | ||
* http://www.apache.org/licenses/LICENSE-2.0 | ||
* | ||
* Unless required by applicable law or agreed to in writing, software | ||
* distributed under the License is distributed on an "AS IS" BASIS, | ||
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
* See the License for the specific language governing permissions and | ||
* limitations under the License | ||
*/ | ||
|
||
#ifndef MBED_INTERFACE_DIGITALIN_H_ | ||
#define MBED_INTERFACE_DIGITALIN_H_ | ||
|
||
|
||
namespace mbed { | ||
|
||
class DigitalIn; | ||
|
||
namespace interface { | ||
|
||
#ifdef FEATURE_EXPERIMENTAL_API | ||
|
||
// TODO - move method doxygen comments to interface once this polymorphism is mainstream | ||
|
||
// Pure interface definition for DigitalIn | ||
struct DigitalIn { | ||
virtual ~DigitalIn() = default; | ||
virtual int read() = 0; | ||
virtual void mode(PinMode pull) = 0; | ||
virtual int is_connected() = 0; | ||
|
||
operator int() | ||
{ | ||
// Underlying implementation is responsible for thread-safety | ||
return read(); | ||
} | ||
|
||
}; | ||
#else | ||
using DigitalIn = ::mbed::DigitalIn; | ||
#endif /* FEATURE_EXPERIMENTAL_API */ | ||
|
||
} // namespace interface | ||
} // namespace mbed | ||
|
||
#endif /* MBED_INTERFACE_DIGITALIN_H_ */ |
73 changes: 73 additions & 0 deletions
73
drivers/include/drivers/interfaces/InterfaceDigitalInOut.h
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,73 @@ | ||
/* | ||
* Mbed-OS Microcontroller Library | ||
* Copyright (c) 2021 Embedded Planet | ||
* Copyright (c) 2021 ARM Limited | ||
* SPDX-License-Identifier: Apache-2.0 | ||
* | ||
* Licensed under the Apache License, Version 2.0 (the "License"); | ||
* you may not use this file except in compliance with the License. | ||
* You may obtain a copy of the License at | ||
* | ||
* http://www.apache.org/licenses/LICENSE-2.0 | ||
* | ||
* Unless required by applicable law or agreed to in writing, software | ||
* distributed under the License is distributed on an "AS IS" BASIS, | ||
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
* See the License for the specific language governing permissions and | ||
* limitations under the License | ||
*/ | ||
|
||
#ifndef MBED_INTERFACE_DIGITALINOUT_H_ | ||
#define MBED_INTERFACE_DIGITALINOUT_H_ | ||
|
||
#include "PinNames.h" | ||
|
||
namespace mbed { | ||
|
||
class DigitalInOut; | ||
|
||
namespace interface { | ||
|
||
#ifdef FEATURE_EXPERIMENTAL_API | ||
|
||
// TODO - move method doxygen comments to interface once this polymorphism is mainstream | ||
|
||
// Pure interface definition for DigitalInOut | ||
struct DigitalInOut { | ||
virtual ~DigitalInOut() = default; | ||
virtual void write(int value) = 0; | ||
virtual int read() = 0; | ||
virtual void output() = 0; | ||
virtual void input() = 0; | ||
virtual void mode(PinMode pull) = 0; | ||
virtual int is_connected() = 0; | ||
|
||
DigitalInOut &operator= (int value) | ||
{ | ||
// Underlying implementation is responsible for thread-safety | ||
write(value); | ||
return *this; | ||
} | ||
|
||
DigitalInOut &operator= (DigitalInOut &rhs) | ||
{ | ||
// Underlying implementation is responsible for thread-safety | ||
write(rhs.read()); | ||
return *this; | ||
} | ||
|
||
operator int() | ||
{ | ||
// Underlying implementation is responsible for thread-safety | ||
return read(); | ||
} | ||
|
||
}; | ||
#else | ||
using DigitalInOut = ::mbed::DigitalInOut; | ||
#endif /* FEATURE_EXPERIMENTAL_API */ | ||
|
||
} // namespace interface | ||
} // namespace mbed | ||
|
||
#endif /* MBED_INTERFACE_DIGITALINOUT_H_ */ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,71 @@ | ||
/* | ||
* Mbed-OS Microcontroller Library | ||
* Copyright (c) 2021 Embedded Planet | ||
* Copyright (c) 2021 ARM Limited | ||
* SPDX-License-Identifier: Apache-2.0 | ||
* | ||
* Licensed under the Apache License, Version 2.0 (the "License"); | ||
* you may not use this file except in compliance with the License. | ||
* You may obtain a copy of the License at | ||
* | ||
* http://www.apache.org/licenses/LICENSE-2.0 | ||
* | ||
* Unless required by applicable law or agreed to in writing, software | ||
* distributed under the License is distributed on an "AS IS" BASIS, | ||
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
* See the License for the specific language governing permissions and | ||
* limitations under the License | ||
*/ | ||
|
||
#ifndef MBED_INTERFACE_DIGITALOUT_H_ | ||
#define MBED_INTERFACE_DIGITALOUT_H_ | ||
|
||
#include "PinNames.h" | ||
|
||
namespace mbed { | ||
|
||
class DigitalOut; | ||
|
||
namespace interface { | ||
|
||
#ifdef FEATURE_EXPERIMENTAL_API | ||
|
||
// TODO - move method doxygen comments to interface once this polymorphism is mainstream | ||
|
||
// Pure interface definition for DigitalOut | ||
struct DigitalOut { | ||
virtual ~DigitalOut() = default; | ||
virtual void write(int value) = 0; | ||
virtual int read() = 0; | ||
virtual int is_connected() = 0; | ||
|
||
DigitalOut &operator= (int value) | ||
{ | ||
// Underlying implementation is responsible for thread-safety | ||
write(value); | ||
return *this; | ||
} | ||
|
||
DigitalOut &operator= (DigitalOut &rhs) | ||
{ | ||
// Underlying implementation is responsible for thread-safety | ||
write(rhs.read()); | ||
return *this; | ||
} | ||
|
||
operator int() | ||
{ | ||
// Underlying implementation is responsible for thread-safety | ||
return read(); | ||
} | ||
|
||
}; | ||
#else | ||
using DigitalOut = ::mbed::DigitalOut; | ||
#endif /* FEATURE_EXPERIMENTAL_API */ | ||
|
||
} // namespace interface | ||
} // namespace mbed | ||
|
||
|
||
#endif /* MBED_INTERFACE_DIGITALOUT_H_ */ |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we remove this todo ,as this is almost ready for integration,it will go into the next release . If there is anything outstanding, create an issue about it.