Skip to content

Reduce LED use in automatic CI tests #13213

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jul 6, 2020
Merged

Reduce LED use in automatic CI tests #13213

merged 2 commits into from
Jul 6, 2020

Conversation

jeromecoutant
Copy link
Collaborator

Summary of changes

Fix #13021

LED use in automatic tests is not useful

  • LED2 is removed
  • LED1 is only kept in INTEGRATION tests as there is a way to not use it

Impact of changes

none in CI

Migration actions required

Documentation

Pull request type 

[x] Patch update (Bug fix / Target update / Docs update / Test update / Refactor)
[] Feature update (New feature / Functionality change / New API)
[] Major update (Breaking change E.g. Return code change / API behaviour change)

Test results 

[] No Tests required for this change (E.g docs only update)
[x] Covered by existing mbed-os tests (Greentea or Unittest)
[] Tests / results supplied as part of this PR

Reviewers

@jeromecoutant
Remove LED2 in integration tests
2cc72e7 
- LED1 is sufficient
- Use MBED_CONF_APP_NO_LED json config if LED1 doesn't exist
@jeromecoutant
LED1 and LED2 removed from tests-mbed_drivers-ticker
eac3c95 
not really useful for automatic CI test
@ciarmcom ciarmcom requested review from a team July 1, 2020 15:00
@ciarmcom
Copy link
Member

ciarmcom commented Jul 1, 2020

@jeromecoutant, thank you for your changes.
@ARMmbed/mbed-os-test @ARMmbed/mbed-os-core @ARMmbed/mbed-os-maintainers please review.

evedon
evedon approved these changes Jul 2, 2020
View reviewed changes
Copy link
Contributor

@evedon evedon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems perfectly reasonable to remove LED2.

@0xc0170
Copy link
Contributor

0xc0170 commented Jul 2, 2020

CI started

@mbed-ci
Copy link

mbed-ci commented Jul 2, 2020

Test run: SUCCESS

Summary: 4 of 4 test jobs passed
Build number : 1
Build artifacts

@0xc0170
Copy link
Contributor

0xc0170 commented Jul 6, 2020

I restarted Travis, did not report status back (was green).

@0xc0170 0xc0170 added needs: CI release-type: patch Indentifies a PR as containing just a patch and removed needs: review labels Jul 6, 2020
@0xc0170 0xc0170 merged commit 338e5ea into ARMmbed:master Jul 6, 2020
@mergify mergify bot removed the ready for merge label Jul 6, 2020
@jeromecoutant jeromecoutant deleted the PR_LED2 branch July 6, 2020 14:01
@adbridge adbridge added release-version: 6.2.0 Release-pending and removed release-type: patch Indentifies a PR as containing just a patch Release-pending labels Jul 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@0xc0170 0xc0170 0xc0170 approved these changes

@evedon evedon evedon approved these changes

Assignees
No one assigned
Labels
release-version: 6.2.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

LED use in greentea tests ?
6 participants
@jeromecoutant @ciarmcom @0xc0170 @mbed-ci @evedon @adbridge