Skip to content

create a random static address using random data #13228

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

paul-szczepanek-arm
Copy link
Member

this is an edit to a PR

@ciarmcom ciarmcom requested a review from a team July 3, 2020 13:00
@ciarmcom
Copy link
Member

ciarmcom commented Jul 3, 2020

@paul-szczepanek-arm, thank you for your changes.
@ARMmbed/mbed-os-maintainers please review.

pan-
pan- previously requested changes Jul 3, 2020
Copy link
Member

@pan- pan- left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reading the data sheet, there's two registers that can be use to get an address:

  • DeviceID: The register previously read
  • DeviceAddress: Supposed to help the device address

I suggest we use one for the public address and the other for the random static address so we keep two addresses across reset.
This require update of the doInitialise function (see line 325). In general it would be a good thing to clarify public address provisioning and as many silicon vendor doesn't provide one.

@paul-szczepanek-arm
Copy link
Member Author

I thought about that but there is no message in cordio to do that so that would be another modification to cordio

@paul-szczepanek-arm
Copy link
Member Author

as for retaining the address, this will have the same address as it's seeded by the public address

@mergify mergify bot added needs: CI and removed needs: work labels Jul 6, 2020
@0xc0170
Copy link
Contributor

0xc0170 commented Jul 6, 2020

A fix for PR to master from feature branch, will merge now as it is.

@0xc0170 0xc0170 merged commit bd9e819 into ARMmbed:feature-cordio-update-20-05 Jul 6, 2020
@mergify mergify bot removed the ready for merge label Jul 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants