Skip to content

Remove invalid unicode characters from mesh-api/mbed_lib.json #13257

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

rwalton-arm
Copy link
Contributor

Summary of changes

mbed-mesh-api/mbed_lib.json contained an invalid unicode character (U+202C).

When attempting to decode this file in a Python script, it fails with a JSONDecodeError.
The current tools ignore encoding errors when opening a file object, masking the problem.

The github file viewer seems to ignore these characters. However, the invalid characters can be seen in a git diff on the command line (shown below).

     "config": {
         "heap-size": {
-            "help": "Nanostack's heap size [bytes: 0-<U+202D>4294967295<U+202C>]",
+            "help": "Nanostack's heap size [bytes: 0-4294967295]",
             "value": 32500
         },
         "mac-neigh-table-size": {
@@ -142,13 +142,13 @@
         },
         "wisun-uc-fixed-channel": {
             "help": "Default 16-bit fixed channel for unicast. Used when channel hopping is not desired.",
-            "value_max": 65535<U+202C>,
-            "value": <U+202D>65535<U+202C>
+            "value_max": 65535,
+            "value": 65535
         },
         "wisun-bc-fixed-channel": {
             "help": "Default 16-bit fixed channel for multicast. Used when channel hopping is not desired.",
-            "value_max": 65535<U+202C>,
-            "value": 65535<U+202C>
+            "value_max": 65535,
+            "value": 65535 

Impact of changes

Migration actions required

Documentation

None


Pull request type

[x] Patch update (Bug fix / Target update / Docs update / Test update / Refactor)
[] Feature update (New feature / Functionality change / New API)
[] Major update (Breaking change E.g. Return code change / API behaviour change)

Test results

[x] No Tests required for this change (E.g docs only update)
[] Covered by existing mbed-os tests (Greentea or Unittest)
[] Tests / results supplied as part of this PR

Reviewers


@ciarmcom
Copy link
Member

ciarmcom commented Jul 8, 2020

@rwalton-arm, thank you for your changes.
@ARMmbed/mbed-os-ipcore @ARMmbed/mbed-os-maintainers please review.

@ciarmcom ciarmcom requested review from a team July 8, 2020 21:00
@0xc0170
Copy link
Contributor

0xc0170 commented Jul 9, 2020

CI started

@mergify mergify bot added needs: CI and removed needs: review labels Jul 9, 2020
@mbed-ci
Copy link

mbed-ci commented Jul 9, 2020

Test run: SUCCESS

Summary: 7 of 7 test jobs passed
Build number : 1
Build artifacts

@0xc0170 0xc0170 added the release-type: patch Indentifies a PR as containing just a patch label Jul 9, 2020
@0xc0170 0xc0170 merged commit 4f9699a into ARMmbed:master Jul 9, 2020
@mergify mergify bot removed the ready for merge label Jul 9, 2020
@adbridge adbridge added release-version: 6.2.0 Release-pending and removed release-type: patch Indentifies a PR as containing just a patch Release-pending labels Jul 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants