Skip to content

Fix deprecated warning messages in Cypress code #13258

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 9, 2020

Conversation

praveenCY
Copy link
Contributor

Summary of changes

These changes fixes deprecated warning messages in CyH4TransportDriver.cpp and HCIDriver.cpp

[Warning] CyH4TransportDriver.cpp@142,36: 'void rtos::ThisThread::sleep_for(uint32_t)' is deprecated: Pass a chrono duration, not an integer millisecond count. For example use 5s rather than 5000. [since mbed-os-6.0.0] [-Wdeprecated-declarations]
[Warning] HCIDriver.cpp@102,40: 'void rtos::ThisThread::sleep_for(uint32_t)' is deprecated: Pass a chrono duration, not an integer millisecond count. For example use 5s rather than 5000. [since mbed-os-6.0.0] [-Wdeprecated-declarations]
[Warning] HCIDriver.cpp@104,40: 'void rtos::ThisThread::sleep_for(uint32_t)' is deprecated: Pass a chrono duration, not an integer millisecond count. For example use 5s rather than 5000. [since mbed-os-6.0.0] [-Wdeprecated-declarations]
[Warning] HCIDriver.cpp@367,41: 'void rtos::ThisThread::sleep_for(uint32_t)' is deprecated: Pass a chrono duration, not an integer millisecond count. For example use 5s rather than 5000. [since mbed-os-6.0.0] [-Wdeprecated-declarations]

Impact of changes

Migration actions required

Documentation

None


Pull request type

[x] Patch update (Bug fix / Target update / Docs update / Test update / Refactor)
[] Feature update (New feature / Functionality change / New API)
[] Major update (Breaking change E.g. Return code change / API behaviour change)

Test results

Code compile tried and deprecated warnings not seen

[] No Tests required for this change (E.g docs only update)
[x] Covered by existing mbed-os tests (Greentea or Unittest)
[] Tests / results supplied as part of this PR

Reviewers


@ciarmcom ciarmcom requested review from a team July 8, 2020 21:00
@ciarmcom
Copy link
Member

ciarmcom commented Jul 8, 2020

@praveenCY, thank you for your changes.
@ARMmbed/mbed-os-pan @ARMmbed/mbed-os-maintainers please review.

@mergify mergify bot added needs: CI and removed needs: review labels Jul 9, 2020
@0xc0170
Copy link
Contributor

0xc0170 commented Jul 9, 2020

CI started

@0xc0170
Copy link
Contributor

0xc0170 commented Jul 9, 2020

Errors in the build, will check and talk to @ARMmbed/mbed-os-test team

@mbed-ci
Copy link

mbed-ci commented Jul 9, 2020

Test run: FAILED

Summary: 1 of 3 test jobs failed
Build number : 1
Build artifacts

Failed test jobs:

  • jenkins-ci/mbed-os-ci_build-GCC_ARM

@mbed-ci
Copy link

mbed-ci commented Jul 9, 2020

Test run: SUCCESS

Summary: 6 of 6 test jobs passed
Build number : 2
Build artifacts

@0xc0170 0xc0170 added the release-type: patch Indentifies a PR as containing just a patch label Jul 9, 2020
@0xc0170 0xc0170 merged commit 947eb7a into ARMmbed:master Jul 9, 2020
@mergify mergify bot removed the ready for merge label Jul 9, 2020
@adbridge adbridge added release-version: 6.2.0 Release-pending and removed release-type: patch Indentifies a PR as containing just a patch Release-pending labels Jul 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants