Skip to content

TESTS: removed mbed OS 6 unsupported target in examples test #13279

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jul 31, 2020
Merged

TESTS: removed mbed OS 6 unsupported target in examples test #13279

merged 2 commits into from
Jul 31, 2020

Conversation

jamesbeyond
Copy link
Contributor

Summary of changes

Removed mbed OS 6 unsupported target in examples test

Impact of changes

Migration actions required

Documentation

Not Required

Pull request type 

[x] Patch update (Bug fix / Target update / Docs update / Test update / Refactor)
[] Feature update (New feature / Functionality change / New API)
[] Major update (Breaking change E.g. Return code change / API behaviour change)

Test results 

[] No Tests required for this change (E.g docs only update)
[x] Covered by existing mbed-os tests (Greentea or Unittest)
[] Tests / results supplied as part of this PR

Reviewers

@Patater

@ciarmcom ciarmcom requested review from Patater and a team July 13, 2020 11:00
@ciarmcom
Copy link
Member

@jamesbeyond, thank you for your changes.
@Patater @ARMmbed/mbed-os-tools @ARMmbed/mbed-os-maintainers please review.

0xc0170
0xc0170 previously approved these changes Jul 13, 2020
View reviewed changes
@mergify mergify bot added needs: CI and removed needs: review labels Jul 13, 2020
Patater
Patater reviewed Jul 13, 2020
View reviewed changes
tools/test/examples/examples.json
@@ -339,7 +339,7 @@
"sub-repo-example": false,
"subs": [],
"features" : [],
"targets" : ["ARM_MUSCA_A1", "ARM_MUSCA_B1", "K64F", "CY8CKIT_064S2_4343W"],
"targets" : ["ARM_MUSCA_B1", "K64F"],
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you replace with CY8CKIT_064B0S2_4343W please? We should run with a PSoC 64 target. This target will be available after #13243 is merged.

Patater
Patater reviewed Jul 13, 2020
View reviewed changes
tools/test/examples/examples.json Outdated
"NUCLEO_F429ZI",
"LPC55S69_NS"
],
"targets" : [ "K66F", "NUCLEO_F429ZI" ],
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should add ARM_MUSCA_B1 here.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

@mergify mergify bot dismissed 0xc0170’s stale review July 14, 2020 14:39

Pull request has been modified.

@jamesbeyond
Copy link
Contributor Author

Updated with new targets. But will need to wait until #13243 is merged, as @Patater indicates

@adbridge adbridge added the release-type: patch Indentifies a PR as containing just a patch label Jul 17, 2020
@jamesbeyond
Copy link
Contributor Author

Since #13243 is not merged, I remove the cypress target from this PR. It can be raised as separate PR if necessary.

I think this one is good for review and CI @0xc0170 @Patater

@mergify mergify bot added needs: CI and removed needs: review labels Jul 30, 2020
@0xc0170
Copy link
Contributor

0xc0170 commented Jul 31, 2020

CI started

@mbed-ci
Copy link

mbed-ci commented Jul 31, 2020

Test run: SUCCESS

Summary: 6 of 6 test jobs passed
Build number : 1
Build artifacts

0xc0170
0xc0170 approved these changes Jul 31, 2020
View reviewed changes
Copy link
Contributor

@0xc0170 0xc0170 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One thing, the alignment should be fixed separately, following targets.json when we have one line per an item to avoid conflicts and keep it consistent

@0xc0170 0xc0170 merged commit 74a1a05 into ARMmbed:master Jul 31, 2020
@mergify mergify bot removed the ready for merge label Jul 31, 2020
@mbedmain mbedmain added release-version: 6.2.1 Release-pending and removed release-type: patch Indentifies a PR as containing just a patch Release-pending labels Aug 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Patater Patater Patater approved these changes

@0xc0170 0xc0170 0xc0170 approved these changes

Assignees
No one assigned
Labels
release-version: 6.2.1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@jamesbeyond @ciarmcom @0xc0170 @mbed-ci @Patater @adbridge @mbedmain