Use a different key to sign Non-secure image for ARM_MUSCA_B1 target #13285
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This applies only to `ARM_MUSCA_B1` target When MCUBOOT repo: UPSTREAM was set as default as part of TF-M 1.1 release, few things were changed: MCUBOOT_IMAGE_NUMBER: '2' MCUBOOT_UPGRADE_STRATEGY: 'OVERWRITE_ONLY' MCUBOOT_HW_KEY: 'On'(default) Therefore the signing strategy for Non-secure image (Mbed OS) needs to be done with its own private key, which is validated during boot. Signed-off-by: Vikas Katariya <[email protected]>
0xc0170
approved these changes
Jul 13, 2020
Test run: SUCCESSSummary: 6 of 6 test jobs passed |
|
maybe a silly question: but is publish the private key expected here ? @0xc0170 @jainvikas8 |
We already have many private keys - https://github.com/ARMmbed/mbed-os/tree/master/tools/targets , Ideally I'd not expect it, but we have a note saying don't use it in production. |
0xc0170
added
the
release-type: patch
|
Approved for 6.2, I'll merge now |
adbridge
added
release-version: 6.2.0
Release-pending
and removed
release-type: patch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of changes
MCUBOOT has been upgraded to image 2, therefore the Non-secure image
needs to be signed with its own private key, which is validated during
boot.
MCUBOOT_REPO: 'UPSTREAM'
MCUBOOT_IMAGE_NUMBER: '2'
MCUBOOT_UPGRADE_STRATEGY: 'OVERWRITE_ONLY'
MCUBOOT_HW_KEY: 'On' (default)
The private key is been imported from - https://git.trustedfirmware.org/TF-M/trusted-firmware-m.git/tree/bl2/ext/mcuboot/root-rsa-3072_1.pem
Impact of changes
These changes impact only the
ARM_MUSCA_B1target.Migration actions required
Documentation
Pull request type
Test results
Reviewers