Add CYTFM_064B0S2 4343W Target #13358

RaymondNgun · 2020-07-28T00:10:18Z

Summary of changes

This PR adds CYTFM_064B0S2_4343W target. The target is similar to CY8CKIT_064B0S2_4343W but
adds TFM/PSA capability. Since the target is based on TFM v1.0, this PR also adds support for
both TFM v1.0 and TFM v1.1 selectable from targets.json.

Impact of changes

Migration actions required

Documentation

This PR replaces #13243

Pull request type

[x] Patch update (Bug fix / Target update / Docs update / Test update / Refactor)
[] Feature update (New feature / Functionality change / New API)
[] Major update (Breaking change E.g. Return code change / API behaviour change)

Test results

[] No Tests required for this change (E.g docs only update)
[] Covered by existing mbed-os tests (Greentea or Unittest)
[x] Tests / results supplied as part of this PR

ARM Compiler GT Results: results_0727_arm.txt
GCC ARM Compiler GT Results: results_0727_gcc_arm.txt
TFM Results: TFM_Regression_Test.txt

Reviewers

ciarmcom · 2020-07-28T01:00:33Z

@RaymondNgun, thank you for your changes.
@maclobdell @ARMmbed/mbed-os-security @ARMmbed/mbed-os-maintainers @ARMmbed/mbed-os-tools @ARMmbed/mbed-os-hal please review.

RaymondNgun · 2020-07-28T03:15:34Z

@moshe-shahar, please give this target a try - CYTFM_064B0S2_4343W. As I mentioned, this includes a new reprov_helper.py and also fix to key type. Thanks! Let me know if this works for you. Hopefully I didn't miss anything.

0xc0170 · 2020-07-28T07:24:07Z

This PR is intended to replace #13243

Shall we close #13243?

adbridge · 2020-07-28T16:10:20Z

CI started

mbed-ci · 2020-07-28T16:39:52Z

Test run: FAILED

Summary: 1 of 3 test jobs failed
Build number : 1
Build artifacts

Failed test jobs:

jenkins-ci/mbed-os-ci_build-GCC_ARM

Pull request has been modified.

mbed-ci · 2020-07-29T09:31:24Z

Test run: FAILED

Summary: 2 of 3 test jobs failed
Build number : 2
Build artifacts

Failed test jobs:

jenkins-ci/mbed-os-ci_build-ARM
jenkins-ci/mbed-os-ci_build-GCC_ARM

0xc0170 · 2020-07-29T10:21:27Z

@RaymondNgun Please provide details what to update in CI to have this PR passing

cc @ARMmbed/mbed-os-test

...NTAL_API/FEATURE_PSA/TARGET_TFM/TARGET_TFM_V1_0/TARGET_TFM_DUALCPU/src/platform_ns_mailbox.c

...ENTAL_API/FEATURE_PSA/TARGET_TFM/TARGET_TFM_V1_0/TARGET_TFM_DUALCPU/src/tfm_multi_core_api.c

...PI/FEATURE_PSA/TARGET_TFM/TARGET_TFM_V1_0/TARGET_TFM_DUALCPU/src/tfm_multi_core_psa_ns_api.c

...es/FEATURE_EXPERIMENTAL_API/FEATURE_PSA/TARGET_TFM/TARGET_TFM_V1_0/include/device_cfg.h_orig

features/FEATURE_EXPERIMENTAL_API/FEATURE_PSA/TARGET_TFM/TARGET_TFM_V1_1/include/tfm_api.h

...FEATURE_EXPERIMENTAL_API/FEATURE_PSA/TARGET_TFM/TARGET_TFM_V1_1/include/tfm_multi_core_api.h

...s/FEATURE_EXPERIMENTAL_API/FEATURE_PSA/TARGET_TFM/TARGET_TFM_V1_1/include/tfm_ns_interface.h

features/FEATURE_EXPERIMENTAL_API/FEATURE_PSA/TARGET_TFM/TARGET_TFM_V1_1/include/tfm_ns_svc.h

...ess/TARGET_PSOC6/COMPONENT_WHD/resources/nvram/TARGET_CYTFM_064B0S2_4343W/wifi_nvram_image.h

Pull request has been modified.

Signed-off-by: Charley Chu <[email protected]>

Named TFM V1.1 as TFM_V1_1 instead of TFM_V1.1 as TFM_V1.1 is invalid as macro name Signed-off-by: Charley Chu <[email protected]>

Signed-off-by: Charley Chu <[email protected]>

Target is similar to CY8CKIT_064B0S2_4343W but with PSA and TFM enabled. Signed-off-by: Raymond Ngun <[email protected]>

0xc0170 · 2020-08-10T12:31:46Z

CI started

mbed-ci · 2020-08-10T13:13:07Z

Jenkins CI Test : ✔️ SUCCESS

Build Number: 10 | 🔒 Jenkins CI Job | 🌐 Logs & Artifacts

CLICK for Detailed Summary

jobs	Status
jenkins-ci/mbed-os-ci_unittests	✔️
jenkins-ci/mbed-os-ci_build-GCC_ARM	✔️
jenkins-ci/mbed-os-ci_build-ARM	✔️
jenkins-ci/mbed-os-ci_greentea-test	✔️
jenkins-ci/mbed-os-ci_dynamic-memory-usage	✔️
jenkins-ci/mbed-os-ci_cloud-client-pytest	✔️

0xc0170 · 2020-08-10T14:03:21Z

@adbridge All resolved and can be merged? If yes, please merge

adbridge · 2020-08-11T09:58:48Z

@RaymondNgun btw new targets come under patches (ie target update) not new features, for future reference. I will update it.

ciarmcom added the release-type: feature label Jul 28, 2020

ciarmcom requested review from maclobdell and a team July 28, 2020 01:00

ciarmcom added the needs: review label Jul 28, 2020

RaymondNgun force-pushed the topic/cytfm_064b0s2_4343w branch from d9a5327 to 67f6ef7 Compare July 28, 2020 03:05

0xc0170 removed request for a team July 28, 2020 07:23

0xc0170 previously approved these changes Jul 28, 2020

View reviewed changes

0xc0170 added the devices: cypress label Jul 28, 2020

mergify bot added needs: CI and removed needs: review labels Jul 28, 2020

mergify bot added needs: work and removed needs: CI labels Jul 28, 2020

CharleyChu mentioned this pull request Jul 28, 2020

Cypress PSoC64 TF-M Integration #13243

Closed

RaymondNgun force-pushed the topic/cytfm_064b0s2_4343w branch from 67f6ef7 to 5ca0401 Compare July 29, 2020 01:46

0xc0170 added needs: CI and removed needs: work labels Jul 29, 2020

mergify bot added needs: work and removed needs: CI labels Jul 29, 2020

adbridge previously requested changes Aug 6, 2020

View reviewed changes

RaymondNgun force-pushed the topic/cytfm_064b0s2_4343w branch from 5ca0401 to 23fd10e Compare August 7, 2020 03:08

Charley Chu and others added 6 commits August 7, 2020 08:02

psoc64: Update TF-M for MBedOS

a1bc65a

Signed-off-by: Charley Chu <[email protected]>

Use PSA TRNG if PSA is enabled and no TRNG device defined

ff74ea4

Signed-off-by: Charley Chu <[email protected]>

psoc64: Add ability to disable MXCRYPTO

8b663cf

Signed-off-by: Charley Chu <[email protected]>

Move current TFM to TFM_V1_1

badfa18

Named TFM V1.1 as TFM_V1_1 instead of TFM_V1.1 as TFM_V1.1 is invalid as macro name Signed-off-by: Charley Chu <[email protected]>

Add TFM V1.0

c525aec

Signed-off-by: Charley Chu <[email protected]>

CYTFM_064B0S2_4343W: Inital creation of PSA target

1be0b1f

Target is similar to CY8CKIT_064B0S2_4343W but with PSA and TFM enabled. Signed-off-by: Raymond Ngun <[email protected]>

RaymondNgun force-pushed the topic/cytfm_064b0s2_4343w branch from 23fd10e to 1be0b1f Compare August 7, 2020 15:02

0xc0170 added needs: CI and removed needs: work labels Aug 10, 2020

0xc0170 approved these changes Aug 10, 2020

View reviewed changes

mergify bot added ready for merge and removed needs: CI labels Aug 10, 2020

adbridge approved these changes Aug 11, 2020

View reviewed changes

adbridge merged commit 88d9313 into ARMmbed:master Aug 11, 2020

mergify bot removed the ready for merge label Aug 11, 2020

adbridge added release-type: patch Indentifies a PR as containing just a patch and removed release-type: feature labels Aug 11, 2020

mbedmain added release-version: 6.2.1 Release-pending labels Aug 16, 2020

adbridge added the scope: new-target label Aug 19, 2020

mbedmain removed release-type: patch Indentifies a PR as containing just a patch Release-pending labels Aug 19, 2020

Add CYTFM_064B0S2 4343W Target #13358

Add CYTFM_064B0S2 4343W Target #13358

Uh oh!

Conversation

RaymondNgun commented Jul 28, 2020 • edited by adbridge Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary of changes

Impact of changes

Migration actions required

Documentation

Pull request type

Test results

Reviewers

Uh oh!

ciarmcom commented Jul 28, 2020

Uh oh!

RaymondNgun commented Jul 28, 2020

Uh oh!

0xc0170 commented Jul 28, 2020

Uh oh!

adbridge commented Jul 28, 2020

Uh oh!

mbed-ci commented Jul 28, 2020

Test run: FAILED

Uh oh!

mbed-ci commented Jul 29, 2020

Test run: FAILED

Uh oh!

0xc0170 commented Jul 29, 2020

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

0xc0170 commented Aug 10, 2020

Uh oh!

mbed-ci commented Aug 10, 2020

Jenkins CI Test : ✔️ SUCCESS

Build Number: 10 | 🔒 Jenkins CI Job | 🌐 Logs & Artifacts

Uh oh!

0xc0170 commented Aug 10, 2020

Uh oh!

adbridge commented Aug 11, 2020

Uh oh!

Uh oh!

RaymondNgun commented Jul 28, 2020 •

edited by adbridge

Loading