-
Notifications
You must be signed in to change notification settings - Fork 3k
Restructure lwipstack directory #13371
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@gpsimenos, thank you for your changes. |
I wonder if |
Good shout. Moved those into |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Commit 63d1f77 should contain details from the PR description
- Public headers moved into mbed-os/connectivity/lwipstack/include/lwipstack folder - Source moved into mbed-os/connectivity/lwipstack/source folder - Internal lwip and lwip-sys libraries moved to source folder
b8c57f8
to
ee0a510
Compare
Rebased and reworded 63d1f77. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
921c752
to
bcb5c10
Compare
Reverted previous commit moving lwip libraries inside source because that causes problems with the build system. The libraries must remain where they are for now. |
CI started |
Test run: SUCCESSSummary: 6 of 6 test jobs passed |
Summary of changes
mbed-os/features/lwipstack
directory restructured according to the internal proposal.mbed-os/connectivity/lwipstack/include/lwipstack
foldermbed-os/connectivity/lwipstack/source
folderThis is one of a series of PRs aiming to clean up the mbed-os directory structure. The intention is to create a consistent tree among mbed components, following the below structure:
Impact of changes
None
Migration actions required
None
Documentation
None
Pull request type
Test results
Reviewers
@evedon
@ashok-rao
@LDong-Arm