-
Notifications
You must be signed in to change notification settings - Fork 3k
Fix baremetal nightly test build issue #13379
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@rajkan01, thank you for your changes. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
how it was selected previously - based on "feature" ?
these are targets drivers, so rather would expect to have one selection to enable "emac" and target would be selected properly (using TARGET_ rules). I can see one component here though in the target driver.
How this PR changes emac selection with the full build ?
Yes, this is based on netsocket feature. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd suggest to append the library name with driver-
but otherwise fine.
@0xc0170 Could you review and start CI if you are fine with changes thanks |
CI started |
Test run: SUCCESSSummary: 6 of 6 test jobs passed |
Summary of changes
A below list of targets baremetal nightly test build failed due to recently moved
mbed-os/features/netsocket/emac-drivers
tombed-os/connectivity/drivers/emac
drivers, so added mbed_lib.json config on every respective target emac drivers to avoid default inclusion by build tools.Impact of changes
With these changes, emac drivers will not be get included in the baremetal profile build
Migration actions required
None.
Documentation
None.
Pull request type
Test results
Reviewers
@evedon @LDong-Arm