Skip to content

Fix baremetal nightly test build issue #13379

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 31, 2020

Conversation

rajkan01
Copy link
Contributor

@rajkan01 rajkan01 commented Jul 30, 2020

Summary of changes

A below list of targets baremetal nightly test build failed due to recently moved mbed-os/features/netsocket/emac-drivers to mbed-os/connectivity/drivers/emac drivers, so added mbed_lib.json config on every respective target emac drivers to avoid default inclusion by build tools.

  • ARCH_PRO
  • LPC1768
  • NUMAKER_IOT_M487
  • NUMAKER_PFM_M487
  • NUMAKER_PFM_NUC472
  • RZ_A1H

Impact of changes

With these changes, emac drivers will not be get included in the baremetal profile build

Migration actions required

None.

Documentation

None.


Pull request type

[x] Patch update (Bug fix / Target update / Docs update / Test update / Refactor)
[] Feature update (New feature / Functionality change / New API)
[] Major update (Breaking change E.g. Return code change / API behaviour change)

Test results

[] No Tests required for this change (E.g docs only update)
[x] Covered by existing mbed-os tests (Greentea or Unittest)
[] Tests / results supplied as part of this PR

Reviewers

@evedon @LDong-Arm


@ciarmcom ciarmcom added the release-type: patch Indentifies a PR as containing just a patch label Jul 30, 2020
@ciarmcom ciarmcom requested review from evedon, LDong-Arm and a team July 30, 2020 19:00
@ciarmcom
Copy link
Member

@rajkan01, thank you for your changes.
@evedon @LDong-Arm @ARMmbed/mbed-os-maintainers please review.

Copy link
Contributor

@0xc0170 0xc0170 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

how it was selected previously - based on "feature" ?

these are targets drivers, so rather would expect to have one selection to enable "emac" and target would be selected properly (using TARGET_ rules). I can see one component here though in the target driver.

How this PR changes emac selection with the full build ?

@rajkan01
Copy link
Contributor Author

how it was selected previously - based on "feature" ?
these are targets drivers, so rather would expect to have one selection to enable "emac" and target would be selected properly (using TARGET_ rules). I can see one component here though in the target driver.
How this PR changes emac selection with the full build ?

Yes, this is based on netsocket feature.
I thought about that like keep one mbed_lib.json for complete emac but some of the target emac drivers already had mbed_lib.json, so I added mbed_lib.json for missing target.
No change with a full build, This PR changes mainly resolve the build issue with baremetal profile

Copy link
Contributor

@LDong-Arm LDong-Arm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@evedon evedon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd suggest to append the library name with driver- but otherwise fine.

@mergify mergify bot added needs: CI and removed needs: review labels Jul 31, 2020
@rajkan01
Copy link
Contributor Author

@0xc0170 Could you review and start CI if you are fine with changes thanks

@0xc0170
Copy link
Contributor

0xc0170 commented Jul 31, 2020

CI started

@mbed-ci
Copy link

mbed-ci commented Jul 31, 2020

Test run: SUCCESS

Summary: 6 of 6 test jobs passed
Build number : 1
Build artifacts

@0xc0170 0xc0170 merged commit e57e325 into ARMmbed:master Jul 31, 2020
@mergify mergify bot removed the ready for merge label Jul 31, 2020
@mbedmain mbedmain added release-version: 6.2.1 Release-pending and removed release-type: patch Indentifies a PR as containing just a patch Release-pending labels Aug 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants