Skip to content

travis: Check CMake builds CMake-capable targets #13426

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 14, 2020
Merged

travis: Check CMake builds CMake-capable targets #13426

merged 1 commit into from
Aug 14, 2020

Conversation

rwalton-arm
Copy link
Contributor

Summary of changes

We want to ensure the tools/CMake work for all current CMake capable targets.

Add the targets to the travis job.

Impact of changes

Migration actions required

Documentation

None

Pull request type 

[x] Patch update (Bug fix / Target update / Docs update / Test update / Refactor)
[] Feature update (New feature / Functionality change / New API)
[] Major update (Breaking change E.g. Return code change / API behaviour change)

Test results 

[] No Tests required for this change (E.g docs only update)
[] Covered by existing mbed-os tests (Greentea or Unittest)
[] Tests / results supplied as part of this PR

Reviewers

@rwalton-arm rwalton-arm requested review from Patater and 0xc0170 August 13, 2020 14:57
@ciarmcom ciarmcom requested a review from a team August 13, 2020 15:00
@ciarmcom
Copy link
Member

@rwalton-arm, thank you for your changes.
@ARMmbed/mbed-os-maintainers please review.

@0xc0170
Copy link
Contributor

0xc0170 commented Aug 13, 2020

Nice ! This was on the plan for enabling all examples that is still blocked on examples being fixed.. I assume the fixup above is one of them.. :( We will fix them in the next days.

@rwalton-arm rwalton-arm changed the title (WIP) travis: Check CMake builds CMake-capable targets travis: Check CMake builds CMake-capable targets Aug 14, 2020
Patater
Patater previously approved these changes Aug 14, 2020
View reviewed changes
Copy link
Contributor

@Patater Patater left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Please apply the fixup before merge.

@mergify mergify bot added needs: CI and removed needs: work labels Aug 14, 2020
@rwalton-arm rwalton-arm force-pushed the dev/rwalton-arm/add-targets-to-travis-job branch from 2b65cb3 to 67585de Compare August 14, 2020 10:23
@mergify mergify bot dismissed Patater’s stale review August 14, 2020 10:24

Pull request has been modified.

@0xc0170 0xc0170 merged commit 25b0725 into ARMmbed:feature-cmake Aug 14, 2020
@0xc0170 0xc0170 removed the needs: CI label Aug 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Patater Patater Patater approved these changes

@0xc0170 0xc0170 0xc0170 approved these changes

Assignees
No one assigned
Labels
release-version: feature branch
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@rwalton-arm @ciarmcom @0xc0170 @Patater