Skip to content

USBPhyHw: remove mbed.h inclusion #13456

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 25, 2020
Merged

USBPhyHw: remove mbed.h inclusion #13456

merged 2 commits into from
Aug 25, 2020

Conversation

0xc0170
Copy link
Contributor

@0xc0170 0xc0170 commented Aug 18, 2020

Summary of changes

Remove user facing header file, it should not be included within a library. The header itself does not need anything from Mbed.

It could possibly fail if targets which implement usb are not including what is required for their implementation.

I can fix any breakage in nightly but before that I'll run with this PR couple of builds for targets with usb support.

Impact of changes

Migration actions required

Documentation


Pull request type

[x] Patch update (Bug fix / Target update / Docs update / Test update / Refactor)
[] Feature update (New feature / Functionality change / New API)
[] Major update (Breaking change E.g. Return code change / API behaviour change)

Test results

[x] No Tests required for this change (E.g docs only update)
[] Covered by existing mbed-os tests (Greentea or Unittest)
[] Tests / results supplied as part of this PR

Reviewers


Remove user facing header file, it should not be included within a library. The header itself does not need anything from Mbed.

It could possibly fail if targets which implement usb are not including what is required for their implementation.
@ciarmcom ciarmcom added the release-type: patch Indentifies a PR as containing just a patch label Aug 18, 2020
@ciarmcom ciarmcom requested review from maclobdell and a team August 18, 2020 15:00
@ciarmcom
Copy link
Member

@0xc0170, thank you for your changes.
@maclobdell @ARMmbed/mbed-os-maintainers please review.

@0xc0170
Copy link
Contributor Author

0xc0170 commented Aug 18, 2020

I could reproduce events failures, as I wrote earlier, I'll run some tests locally and fix includes in USB HAL.

@0xc0170
Copy link
Contributor Author

0xc0170 commented Aug 21, 2020

I'll run one CI to get the better coverage what failures are there so can fix it quickly

@mbed-ci
Copy link

mbed-ci commented Aug 21, 2020

Jenkins CI Test : ✔️ SUCCESS

Build Number: 1 | 🔒 Jenkins CI Job | 🌐 Logs & Artifacts

CLICK for Detailed Summary

jobs Status
jenkins-ci/mbed-os-ci_unittests ✔️
jenkins-ci/mbed-os-ci_build-GCC_ARM ✔️
jenkins-ci/mbed-os-ci_build-ARM ✔️
jenkins-ci/mbed-os-ci_greentea-test ✔️
jenkins-ci/mbed-os-ci_dynamic-memory-usage ✔️
jenkins-ci/mbed-os-ci_cloud-client-pytest ✔️

@0xc0170
Copy link
Contributor Author

0xc0170 commented Aug 24, 2020

Travis restarted

@0xc0170
Copy link
Contributor Author

0xc0170 commented Aug 25, 2020

@adbridge please review, and merge if all OK

@adbridge adbridge merged commit 36764b9 into master Aug 25, 2020
@mbedmain mbedmain added release-version: 6.3.0 Release-pending and removed release-type: patch Indentifies a PR as containing just a patch Release-pending labels Sep 14, 2020
@0xc0170 0xc0170 deleted the dev_usb_remove_mbedh branch October 5, 2021 08:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants