Skip to content

adr: Recommend CMSIS component source structure #13464

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Sep 2, 2020

Conversation

hugueskamba
Copy link
Collaborator

@hugueskamba hugueskamba commented Aug 19, 2020

Summary of changes

Added an ADR to recommend component source structure.

The PR has two commits. One adds the adr and the other one implements the changes proposed.

The PR depends on:
#13469

Impact of changes

Migration actions required

Documentation


Pull request type

  • Patch update (Bug fix / Target update / Docs update / Test update / Refactor)
  • Feature update (New feature / Functionality change / New API)
  • Major update (Breaking change E.g. Return code change / API behaviour change)

Test results

  • No Tests required for this change (E.g docs only update)
  • Covered by existing mbed-os tests (Greentea or Unittest)
  • Tests / results supplied as part of this PR

Reviewers


@ciarmcom ciarmcom requested a review from a team August 19, 2020 14:30
@ciarmcom
Copy link
Member

@hugueskamba, thank you for your changes.
@ARMmbed/mbed-os-maintainers please review.

@hugueskamba hugueskamba force-pushed the hk_cmsis_restructure branch 5 times, most recently from ca7f3f4 to fa9f23a Compare August 20, 2020 11:06
@hugueskamba hugueskamba force-pushed the hk_cmsis_restructure branch 10 times, most recently from 01fad41 to fce9b2b Compare August 21, 2020 11:42
@ARMmbed ARMmbed deleted a comment from mbed-ci Aug 21, 2020
@ARMmbed ARMmbed deleted a comment from mbed-ci Aug 21, 2020
@ARMmbed ARMmbed deleted a comment from mbed-ci Aug 21, 2020
@ARMmbed ARMmbed deleted a comment from mbed-ci Aug 21, 2020
@mergify
Copy link

mergify bot commented Aug 21, 2020

This PR cannot be merged due to conflicts. Please rebase to resolve them.

@mbed-ci
Copy link

mbed-ci commented Aug 21, 2020

Jenkins CI Test : ✔️ SUCCESS

Build Number: 5 | 🔒 Jenkins CI Job | 🌐 Logs & Artifacts

CLICK for Detailed Summary

jobs Status
jenkins-ci/mbed-os-ci_unittests ✔️
jenkins-ci/mbed-os-ci_build-ARM ✔️
jenkins-ci/mbed-os-ci_build-GCC_ARM ✔️
jenkins-ci/mbed-os-ci_dynamic-memory-usage ✔️
jenkins-ci/mbed-os-ci_cloud-client-pytest ✔️
jenkins-ci/mbed-os-ci_greentea-test ✔️

@0xc0170 0xc0170 requested a review from bulislaw August 31, 2020 17:16
@mbed-ci
Copy link

mbed-ci commented Sep 1, 2020

Jenkins CI Test : ❌ FAILED

Build Number: 11 | 🔒 Jenkins CI Job | 🌐 Logs & Artifacts

CLICK for Detailed Summary

jobs Status
jenkins-ci/mbed-os-ci_unittests ✔️
jenkins-ci/mbed-os-ci_build-GCC_ARM
jenkins-ci/mbed-os-ci_build-ARM

@hugueskamba hugueskamba force-pushed the hk_cmsis_restructure branch 3 times, most recently from 9b4ae20 to 3bded3d Compare September 1, 2020 13:52
@hugueskamba
Copy link
Collaborator Author

The following force-pushes:

@hugueskamba
Copy link
Collaborator Author

The following force-pushes:

This force-push amends the adr for the change above.

@hugueskamba hugueskamba requested a review from 0xc0170 September 1, 2020 14:00
bulislaw
bulislaw previously approved these changes Sep 1, 2020
Copy link
Member

@bulislaw bulislaw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks!

@mbed-ci
Copy link

mbed-ci commented Sep 1, 2020

Jenkins CI Test : ✔️ SUCCESS

Build Number: 12 | 🔒 Jenkins CI Job | 🌐 Logs & Artifacts

CLICK for Detailed Summary

jobs Status
jenkins-ci/mbed-os-ci_unittests ✔️
jenkins-ci/mbed-os-ci_build-GCC_ARM ✔️
jenkins-ci/mbed-os-ci_build-ARM ✔️
jenkins-ci/mbed-os-ci_dynamic-memory-usage ✔️
jenkins-ci/mbed-os-ci_cloud-client-pytest ✔️
jenkins-ci/mbed-os-ci_greentea-test ✔️

See docs/adr/0001_cmsis_component_source_structure_recommendations.md
For details information.
@mergify mergify bot dismissed bulislaw’s stale review September 1, 2020 14:55

Pull request has been modified.

@hugueskamba
Copy link
Collaborator Author

hugueskamba commented Sep 1, 2020

This force-push amends the travis-ci/events as it deletes the removed directory.

@mbed-ci
Copy link

mbed-ci commented Sep 1, 2020

Jenkins CI Test : ✔️ SUCCESS

Build Number: 13 | 🔒 Jenkins CI Job | 🌐 Logs & Artifacts

CLICK for Detailed Summary

jobs Status
jenkins-ci/mbed-os-ci_unittests ✔️
jenkins-ci/mbed-os-ci_build-GCC_ARM ✔️
jenkins-ci/mbed-os-ci_build-ARM ✔️
jenkins-ci/mbed-os-ci_greentea-test ✔️
jenkins-ci/mbed-os-ci_dynamic-memory-usage ✔️
jenkins-ci/mbed-os-ci_cloud-client-pytest ✔️

@0xc0170 0xc0170 added the release-type: patch Indentifies a PR as containing just a patch label Sep 2, 2020
@0xc0170 0xc0170 merged commit 90ca583 into ARMmbed:master Sep 2, 2020
@mergify mergify bot removed the ready for merge label Sep 2, 2020
@hugueskamba hugueskamba deleted the hk_cmsis_restructure branch September 2, 2020 08:47
@mbedmain mbedmain added release-version: 6.3.0 Release-pending and removed release-type: patch Indentifies a PR as containing just a patch Release-pending labels Sep 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants