Skip to content

[mbedos-5.15] Updating mbed-mesh-api #13496

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Sep 22, 2020
Merged

[mbedos-5.15] Updating mbed-mesh-api #13496

merged 3 commits into from
Sep 22, 2020

Conversation

artokin
Copy link
Contributor

@artokin artokin commented Aug 26, 2020

Summary of changes

Adding new parameters for Wi-SUN and Border router interface information.
This is upstream of PR #13453

Impact of changes

Migration actions required

Documentation

Pull request type 

[x] Patch update (Bug fix / Target update / Docs update / Test update / Refactor)
[] Feature update (New feature / Functionality change / New API)
[] Major update (Breaking change E.g. Return code change / API behaviour change)

Test results 

[] No Tests required for this change (E.g docs only update)
[x] Covered by existing mbed-os tests (Greentea or Unittest)
[] Tests / results supplied as part of this PR

Reviewers

mikter
mikter previously approved these changes Aug 26, 2020
View reviewed changes
@0xc0170
Copy link
Contributor

0xc0170 commented Aug 31, 2020

I restarted travis, 5.15 branch should contain the updated gcc arm version. It should pass this time.

@0xc0170
Copy link
Contributor

0xc0170 commented Aug 31, 2020

CI restarted

@mbed-ci
Copy link

mbed-ci commented Aug 31, 2020

Test run: FAILED

Summary: 2 of 3 test jobs failed
Build number : 1
Build artifacts

Failed test jobs:

  • jenkins-ci/mbed-os-ci_build-ARM-lts
  • jenkins-ci/mbed-os-ci_build-GCC_ARM-lts

@mergify mergify bot added needs: work and removed needs: CI labels Aug 31, 2020
@0xc0170
Copy link
Contributor

0xc0170 commented Aug 31, 2020

Travis restart helped but there is build error (also in jenkins), please review

@debdeep-arm
Copy link
Contributor

debdeep-arm commented Sep 1, 2020 •
edited
Loading

@artokin , are we going to take #13444 to this branch ?
It is failing in compilation.
Particularly this part is missing in this branch:
https://github.com/ARMmbed/mbed-os/blob/feature-wisun/features/nanostack/sal-stack-nanostack/nanostack/ws_bbr_api.h#L40

@artokin
Copy link
Contributor Author

artokin commented Sep 1, 2020

@debdeep-arm , you are right. We need the missing line from PR 13444. 13444 is upstreamed to 5.15 branch in #13451. So I should have marked this as dependent of 13451.

@artokin
Copy link
Contributor Author

artokin commented Sep 2, 2020

Preseding PR #13451 is now merged. @debdeep-arm, would you please rebase?

@debdeep-arm
Copy link
Contributor

Preseding PR #13451 is now merged. @debdeep-arm, would you please rebase?

@artokin The PR is created from your repo. I do not have write access.

@debdeep-arm
Updating mbed-mesh-api.
c5386c0 
-Adding new parameters for Wi-SUN interface information.
@debdeep-arm
Resolving comments
72c28ee
@debdeep-arm
Typo fixed.
b0c2443
@artokin
Copy link
Contributor Author

artokin commented Sep 2, 2020 •
edited
Loading

@debdeep-arm , sorry for confusing things. I can make the rebase as the PR is on my repository.

@artokin artokin force-pushed the sync_mbed_mesh_api_update_5_15 branch from 2e69cc4 to b0c2443 Compare September 2, 2020 11:02
@mergify mergify bot dismissed mikter’s stale review September 2, 2020 11:03

Pull request has been modified.

@0xc0170
Copy link
Contributor

0xc0170 commented Sep 3, 2020

CI started

@mbed-ci
Copy link

mbed-ci commented Sep 3, 2020

Test run: SUCCESS

Summary: 11 of 11 test jobs passed
Build number : 2
Build artifacts

@0xc0170
Copy link
Contributor

0xc0170 commented Sep 4, 2020

I accidentally started a new ci job, once completes, this is ready to merge

@mbed-ci
Copy link

mbed-ci commented Sep 4, 2020

Test run: SUCCESS

Summary: 11 of 11 test jobs passed
Build number : 3
Build artifacts

@0xc0170 0xc0170 requested a review from andypowers September 7, 2020 14:46
andypowers
andypowers approved these changes Sep 8, 2020
View reviewed changes
Copy link
Collaborator

@andypowers andypowers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved.

@0xc0170 0xc0170 merged commit 11418a2 into ARMmbed:mbed-os-5.15 Sep 22, 2020
@mergify mergify bot removed the ready for merge label Sep 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@0xc0170 0xc0170 0xc0170 approved these changes

@andypowers andypowers andypowers approved these changes

@debdeep-arm debdeep-arm debdeep-arm approved these changes

@juhhei01 juhhei01 Awaiting requested review from juhhei01

@JarkkoPaso JarkkoPaso Awaiting requested review from JarkkoPaso

@mikter mikter Awaiting requested review from mikter

@mikaleppanen mikaleppanen Awaiting requested review from mikaleppanen

Assignees
No one assigned
Labels
release-version: 5.15.6
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@artokin @0xc0170 @mbed-ci @debdeep-arm @mikter @mikaleppanen @andypowers