Skip to content

STM32 USB: use SNG_BUF #13514

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 31, 2020
Merged

Conversation

jeromecoutant
Copy link
Collaborator

Summary of changes

Patch following discussion with @maciejbocianski in #12751

We have some RAM location issue without the patch

Impact of changes

Migration actions required

Documentation


Pull request type

[x] Patch update (Bug fix / Target update / Docs update / Test update / Refactor)
[] Feature update (New feature / Functionality change / New API)
[] Major update (Breaking change E.g. Return code change / API behaviour change)

Test results

[] No Tests required for this change (E.g docs only update)
[x] Covered by existing mbed-os tests (Greentea or Unittest)
[] Tests / results supplied as part of this PR

Reviewers


@ciarmcom ciarmcom added the release-type: patch Indentifies a PR as containing just a patch label Aug 31, 2020
@ciarmcom ciarmcom requested a review from a team August 31, 2020 12:30
@ciarmcom
Copy link
Member

@jeromecoutant, thank you for your changes.
@ARMmbed/mbed-os-maintainers please review.

0xc0170
0xc0170 previously approved these changes Aug 31, 2020
Copy link
Contributor

@0xc0170 0xc0170 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's small change but why the change to SNG instead of DBL (worth in the commit message?) ?

@mergify mergify bot added needs: CI and removed needs: review labels Aug 31, 2020
@0xc0170
Copy link
Contributor

0xc0170 commented Aug 31, 2020

CI started

@mbed-ci
Copy link

mbed-ci commented Aug 31, 2020

Jenkins CI Test : ❌ FAILED

Build Number: 1 | 🔒 Jenkins CI Job | 🌐 Logs & Artifacts

CLICK for Detailed Summary

jobs Status
jenkins-ci/mbed-os-ci_unittests ✔️
jenkins-ci/mbed-os-ci_build-ARM ✔️
jenkins-ci/mbed-os-ci_build-GCC_ARM ✔️
jenkins-ci/mbed-os-ci_cloud-client-pytest
jenkins-ci/mbed-os-ci_greentea-test ✔️
jenkins-ci/mbed-os-ci_dynamic-memory-usage ✔️

To avoid RAM location issue
@jeromecoutant jeromecoutant force-pushed the PR_STM32WB_USB_SNG_BUF branch from af2e72b to 53008d9 Compare August 31, 2020 15:31
@mergify mergify bot dismissed 0xc0170’s stale review August 31, 2020 15:32

Pull request has been modified.

@ciarmcom ciarmcom requested a review from a team August 31, 2020 16:00
@ciarmcom
Copy link
Member

@jeromecoutant, thank you for your changes.
@ARMmbed/mbed-os-maintainers please review.

@0xc0170
Copy link
Contributor

0xc0170 commented Aug 31, 2020

CI restarted

@mbed-ci
Copy link

mbed-ci commented Aug 31, 2020

Jenkins CI Test : ✔️ SUCCESS

Build Number: 2 | 🔒 Jenkins CI Job | 🌐 Logs & Artifacts

CLICK for Detailed Summary

jobs Status
jenkins-ci/mbed-os-ci_unittests ✔️
jenkins-ci/mbed-os-ci_build-ARM ✔️
jenkins-ci/mbed-os-ci_build-GCC_ARM ✔️
jenkins-ci/mbed-os-ci_greentea-test ✔️
jenkins-ci/mbed-os-ci_dynamic-memory-usage ✔️
jenkins-ci/mbed-os-ci_cloud-client-pytest ✔️

@0xc0170 0xc0170 merged commit 642d1ec into ARMmbed:master Aug 31, 2020
@mergify mergify bot removed the ready for merge label Aug 31, 2020
@jeromecoutant jeromecoutant deleted the PR_STM32WB_USB_SNG_BUF branch September 1, 2020 06:54
@mbedmain mbedmain added release-version: 6.3.0 Release-pending and removed release-type: patch Indentifies a PR as containing just a patch Release-pending labels Sep 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants