CMake: Use cmake toolchain file #13540
Merged
+15
−16
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@0xc0170, thank you for your changes. |
6 tasks
|
I should squash 5 commits into one ,as the change is simple and all related to together. |
hugueskamba
force-pushed
the
feature-cmake
branch
from
1272a43 to
7f85097
Compare
|
This PR cannot be merged due to conflicts. Please rebase to resolve them. |
0xc0170
force-pushed
the
fix_cmake_toolchain_file
branch
from
0781eeb to
2c796db
Compare
We should define CMAKE_TOOLCHAIN_FILE (as we are providing Mbed OS toolchain file). This fixes also the issue we had with Unix makefiles where application would be without response files. For more details, see https://gitlab.kitware.com/cmake/cmake/-/issues/21104 As the Mbed OS toolchain file is included by CMake, we need to have enabling language in the main CMake (can be executed only once).
0xc0170
force-pushed
the
fix_cmake_toolchain_file
branch
from
2c796db to
9d75c75
Compare
|
Rebased, ready for review |
hugueskamba
approved these changes
Sep 3, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of changes
Using CMake way to select toolchain file -
CMAKE_TOOLCHAIN_FILEvariable. Toolchain is included by the CMake system. It also allows to be overwritten (user's toolchain file).I took these changes from #13427 with fixes found there in the review.
Impact of changes
Migration actions required
Documentation
Pull request type
Test results
Reviewers