Skip to content

STM32Gx: LSI clock selection when LSE is not available #13564

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 9, 2020

Conversation

More-Wrong
Copy link
Contributor

Summary of changes

Similar to #11525
When LSE was not available on these devices (STM32G4 and STM32G0), LSI would not be selectable due to an issue in HAL compatibility, resulting in a compile error.

Impact of changes

Migration actions required

Documentation

None


Pull request type

[x] Patch update (Bug fix / Target update / Docs update / Test update / Refactor)
[] Feature update (New feature / Functionality change / New API)
[] Major update (Breaking change E.g. Return code change / API behaviour change)

Test results

[] No Tests required for this change (E.g docs only update)
[] Covered by existing mbed-os tests (Greentea or Unittest)
[] Tests / results supplied as part of this PR

This change was not, and is not part of any tests, however, compiling mbed for these devices with

"target.lse_available": 0

in the mbed_app.json file, without the changes, results in a compile error:

mbed-os/targets/TARGET_STM/mbed_overrides.c:154:39: error: 'RCC_RTCCLKSOURCE_NO_CLK' undeclared (first use in this function)
if (__HAL_RCC_GET_RTC_SOURCE() != RCC_RTCCLKSOURCE_NO_CLK) {

Reviewers


@ciarmcom ciarmcom added the release-type: patch Indentifies a PR as containing just a patch label Sep 7, 2020
@ciarmcom
Copy link
Member

ciarmcom commented Sep 7, 2020

@More-Wrong, thank you for your changes.
@ARMmbed/mbed-os-maintainers please review.

@ciarmcom ciarmcom requested a review from a team September 7, 2020 14:30
@0xc0170 0xc0170 requested a review from a team September 9, 2020 10:49
@mergify mergify bot added needs: CI and removed needs: review labels Sep 9, 2020
@mbed-ci
Copy link

mbed-ci commented Sep 9, 2020

Jenkins CI Test : ✔️ SUCCESS

Build Number: 1 | 🔒 Jenkins CI Job | 🌐 Logs & Artifacts

CLICK for Detailed Summary

jobs Status
jenkins-ci/mbed-os-ci_unittests ✔️
jenkins-ci/mbed-os-ci_build-ARM ✔️
jenkins-ci/mbed-os-ci_build-GCC_ARM ✔️
jenkins-ci/mbed-os-ci_greentea-test ✔️
jenkins-ci/mbed-os-ci_dynamic-memory-usage ✔️
jenkins-ci/mbed-os-ci_cloud-client-pytest ✔️

@0xc0170 0xc0170 merged commit 1f6fe47 into ARMmbed:master Sep 9, 2020
@mergify mergify bot removed the ready for merge label Sep 9, 2020
@mbedmain mbedmain added release-version: 6.3.0 Release-pending and removed release-type: patch Indentifies a PR as containing just a patch Release-pending labels Sep 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants