CMake: Gcc Arm prebuild step fix #13575
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We need to use macros for bootloader. Get definitions and pass it to the linker.
|
@0xc0170, thank you for your changes. |
0xc0170
commented
Sep 8, 2020
0xc0170
force-pushed
the
feature-cmake-fix-prelink
branch
from
6a60413 to
e6635d1
Compare
0xc0170
force-pushed
the
feature-cmake-fix-prelink
branch
from
e6635d1 to
dbec0ce
Compare
|
I fixed the target variable name in the main CMake, ready for review |
|
This is needed for #13566 |
hugueskamba
pushed a commit
that referenced
this pull request
Sep 11, 2020
Make it generic for all targets. It was previously hardcoded for K64F
0xc0170
added a commit
that referenced
this pull request
Sep 23, 2020
Make it generic for all targets. It was previously hardcoded for K64F
hugueskamba
pushed a commit
that referenced
this pull request
Oct 12, 2020
Make it generic for all targets. It was previously hardcoded for K64F
hugueskamba
pushed a commit
that referenced
this pull request
Oct 15, 2020
Make it generic for all targets. It was previously hardcoded for K64F
0xc0170
added a commit
that referenced
this pull request
Oct 20, 2020
Make it generic for all targets. It was previously hardcoded for K64F
0xc0170
added a commit
that referenced
this pull request
Oct 23, 2020
Make it generic for all targets. It was previously hardcoded for K64F
0xc0170
added a commit
that referenced
this pull request
Nov 3, 2020
Make it generic for all targets. It was previously hardcoded for K64F
hugueskamba
pushed a commit
that referenced
this pull request
Nov 6, 2020
Make it generic for all targets. It was previously hardcoded for K64F
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of changes
Pre build step contained K64F specific settings, we left behind there. This should fix it - using generator to get 2 properties there - link options and macros.
Impact of changes
Migration actions required
Documentation
Pull request type
Test results
Reviewers