Revert "Always build both .hex and .bin files" #13584
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeromecoutant
approved these changes
Sep 10, 2020
Jenkins CI Test : ✔️ SUCCESSBuild Number: 1 | 🔒 Jenkins CI Job | 🌐 Logs & ArtifactsCLICK for Detailed Summary
|
|
This PR does not contain release version label after merging. |
mergify
bot
added
the
release version missing
|
@alzix It would be good to have tracking issue for new tools - mbed-tools to capture this feature there. |
0xc0170
added
release-type: patch
mbedmain
added
release-version: 6.3.0
Release-pending
and removed
release-type: patch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts #13011
The issue : ARMmbed/mbed-cli#980 . We did not realize the PR 13011 has an impact on the tooling. Producing both outputs make it impossible for a tool to select which one to flash without additional logic from a target (does a target support both or just one - which one is it?). Additional work would be needed for the tools to support this.
mbed-clicurrently copies what it finds first. This is causing an error for targets supporting only .bin output format (.hex is checked first in the tools). There are lot of targets affected unfortunately. The newer firmware (daplink , stlink and others) support both but not all people are up to date, or the target supports latest updates.The change itself in 13011 was good one but without tools supporting it, we have to revert it. The new tools should consider this functionality.
cc @alzix