Make mbed-trace available to bare metal #13649
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Sep 21, 2020
ciarmcom
added
the
release-type: patch
|
@LDong-Arm, thank you for your changes. |
Some code in "drivers" and "targets" use mbed-trace, which when disabled has zero overhead as trace function calls are masks by dummy macros.
This reverts commit 183ca77. Now the "mbed_trace.h" header is always available and maps trace functions to dummy macros when tracing is disabled.
LDong-Arm
commented
Sep 21, 2020
LDong-Arm
force-pushed
the
mbed-trace-default
branch
from
cf45039 to
ca40038
Compare
|
@evedon Thanks for the review, I've addressed your comment. |
|
Hi @artokin, for reasons described above (Mbed OS bare metal), we need an extra check for IPv6 availability. This means updated |
evedon
approved these changes
Sep 21, 2020
artokin
approved these changes
Sep 22, 2020
0xc0170
approved these changes
Sep 22, 2020
|
CI started |
Same here! |
Jenkins CI Test : ✔️ SUCCESSBuild Number: 1 | 🔒 Jenkins CI Job | 🌐 Logs & ArtifactsCLICK for Detailed Summary
|
mbedmain
added
release-version: 6.4.0
Release-pending
and removed
release-type: patch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of changes
(Replaces #13617)
As discussed in #13617, we decide that
mbed-traceis a basic feature and should be always available, even in bare metal builds. This is required by some targets and drivers code.Note: Previously IPv6 tracing is enabled by default, which has dependency on
nanostack-libservice(unavailable to bare metal). Rather than simply disabling IPv6 tracing which would break existing applications, we add a flagnanostack-libservice.present(which translates toMBED_CONF_NANOSTACK_LIBSERVICE_PRESENT) and set IPv6 tracing accordingly.Impact of changes
mbed-traceis now available to all bare metal builds, without having to manually enable it.Migration actions required
It's crucial that
nanostack-libservicecontains thenanostack-libservice.presentchange, otherwisembed-tracewill not enable IPv6 tracing.The changes are upstreamed to PelionIoT/nanostack-libservice#92 and PelionIoT/mbed-trace#99
Documentation
None.
Pull request type
Test results
Reviewers
@ARMmbed/mbed-os-core @artokin @jeromecoutant @kjbracey-arm