Skip to content

Remove unused Nordic TARGET_SDK_11 #13691

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from Nov 12, 2020
Merged

Remove unused Nordic TARGET_SDK_11 #13691

merged 1 commit into from Nov 12, 2020

Conversation

ghost
Copy link

@ghost ghost commented Oct 1, 2020

Summary of changes

The target for Nordic SDK_11 seems unused by anything in mbed-os itself.

Impact of changes

I don't think there is any impact for supported targets in mbed-os, since all consumers have been removed.

Migration actions required

Documentation


Pull request type

[x] Patch update (Bug fix / Target update / Docs update / Test update / Refactor)
[] Feature update (New feature / Functionality change / New API)
[] Major update (Breaking change E.g. Return code change / API behaviour change)

I'm not sure how to categorize this.

Test results

[] No Tests required for this change (E.g docs only update)
[x] Covered by existing mbed-os tests (Greentea or Unittest)
[] Tests / results supplied as part of this PR

Reviewers


@ciarmcom ciarmcom added the release-type: patch Indentifies a PR as containing just a patch label Oct 1, 2020
@ciarmcom
Copy link
Member

ciarmcom commented Oct 1, 2020

@jrobeson, thank you for your changes.
@ARMmbed/mbed-os-maintainers please review.

@ciarmcom ciarmcom requested a review from a team October 1, 2020 00:30
@ghost
Copy link
Author

ghost commented Oct 1, 2020

Is there any way I can get in touch with the folks working on Nordic devices? I want to know if nrfx can/will be updated, and how much the SDK versions matter for nordic devices due to the existence of nrfx.

@0xc0170 0xc0170 requested a review from a team October 14, 2020 07:45
Copy link
Contributor

@0xc0170 0xc0170 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If it's not used anymore, it's still on 5.15 branch. But lets wait for @ARMmbed/mbed-os-pan review

@mergify mergify bot added needs: CI and removed needs: review labels Oct 17, 2020
@0xc0170
Copy link
Contributor

0xc0170 commented Oct 26, 2020

CI started

@mbed-ci
Copy link

mbed-ci commented Oct 26, 2020

Jenkins CI Test : ✔️ SUCCESS

Build Number: 1 | 🔒 Jenkins CI Job | 🌐 Logs & Artifacts

CLICK for Detailed Summary

jobs Status
jenkins-ci/mbed-os-ci_unittests ✔️
jenkins-ci/mbed-os-ci_build-greentea-ARM ✔️
jenkins-ci/mbed-os-ci_build-example-ARM ✔️
jenkins-ci/mbed-os-ci_build-cloud-example-GCC_ARM ✔️
jenkins-ci/mbed-os-ci_build-greentea-GCC_ARM ✔️
jenkins-ci/mbed-os-ci_build-example-GCC_ARM ✔️
jenkins-ci/mbed-os-ci_build-cloud-example-ARM ✔️
jenkins-ci/mbed-os-ci_dynamic-memory-usage ✔️
jenkins-ci/mbed-os-ci_cloud-client-pytest ✔️
jenkins-ci/mbed-os-ci_greentea-test ✔️

@0xc0170
Copy link
Contributor

0xc0170 commented Oct 27, 2020

@ARMmbed/mbed-os-pan Please review

@0xc0170 0xc0170 merged commit 76ff098 into ARMmbed:master Nov 12, 2020
@mergify mergify bot removed the ready for merge label Nov 12, 2020
@mbedmain mbedmain added release-version: 6.5.0 Release-pending and removed release-type: patch Indentifies a PR as containing just a patch Release-pending labels Nov 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants