Skip to content

adapting to new s3 bucket location in travis.yml #13694

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 2, 2020
Merged

adapting to new s3 bucket location in travis.yml #13694

merged 1 commit into from
Oct 2, 2020

Conversation

saheerb
Copy link
Contributor

@saheerb saheerb commented Oct 1, 2020 •
edited
Loading

Summary of changes

Travis CI uses compilers and other binaries like astyle. These are stored in S3 bucket currently owned by ISG and mbed-os-ci is switching to OSS. This PR adapts the S3 location changes from ISG to OSS for travis CI builds.

Impact of changes

Migration actions required

Documentation

None

Pull request type 

[X] Patch update (Bug fix / Target update / Docs update / Test update / Refactor)
[] Feature update (New feature / Functionality change / New API)
[] Major update (Breaking change E.g. Return code change / API behaviour change)

Test results 

[] No Tests required for this change (E.g docs only update)
[X] Covered by existing mbed-os tests (Greentea or Unittest)
[] Tests / results supplied as part of this PR

Reviewers

@ciarmcom ciarmcom requested a review from a team October 1, 2020 17:30
@ciarmcom
Copy link
Member

ciarmcom commented Oct 1, 2020

@saheerb, thank you for your changes.
@ARMmbed/mbed-os-maintainers please review.

@saheerb
Copy link
Contributor Author

saheerb commented Oct 1, 2020

@adbridge @jamesbeyond please review

@adbridge
Copy link
Contributor

adbridge commented Oct 2, 2020

@saheerb please fill in the template header correctly, there is a lot of missing, required information...

adbridge
adbridge approved these changes Oct 2, 2020
View reviewed changes
Copy link
Contributor

@adbridge adbridge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM as far as I can tell

@adbridge adbridge merged commit ad40b1b into ARMmbed:master Oct 2, 2020
@mergify mergify bot added release version missing When PR does not contain release version, bot should label it and we fix it afterwards and removed ready for merge labels Oct 2, 2020
@mergify
Copy link

mergify bot commented Oct 2, 2020

This PR does not contain release version label after merging.

@adbridge adbridge added release-type: patch Indentifies a PR as containing just a patch and removed release version missing When PR does not contain release version, bot should label it and we fix it afterwards labels Oct 20, 2020
@mbedmain mbedmain added release-version: 6.4.0 Release-pending and removed release-type: patch Indentifies a PR as containing just a patch Release-pending labels Oct 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adbridge adbridge adbridge approved these changes

Assignees
No one assigned
Labels
release-version: 6.4.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@saheerb @ciarmcom @adbridge @mbedmain