Skip to content

CMake: Rename CMake targets #13803

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 23, 2020

Conversation

hugueskamba
Copy link
Collaborator

@hugueskamba hugueskamba commented Oct 22, 2020

This is part of the work to create a baremetal configuration.

  • mbed-os renamed mbed-core
  • mbed-os-<COMPONENT> renamed mbed-<COMPONENT>

Also, create a mbed-os alias library.
This ensures that applications which link with the mbed-os
CMake target still work. We want applications that require the OS
to use the mbed-os CMake target as we will be creating a new one
that will include mbed-core and mbed-rtos.

Summary of changes

Impact of changes

All applications supported will need to be amended to include the component libraries with the mbed- prtefix instead of mbed-os-.

Migration actions required

The following PRs need to be merged for the CI to pass:

Documentation


Pull request type

[x] Patch update (Bug fix / Target update / Docs update / Test update / Refactor)
[] Feature update (New feature / Functionality change / New API)
[] Major update (Breaking change E.g. Return code change / API behaviour change)

Test results

[] No Tests required for this change (E.g docs only update)
[x] Covered by existing mbed-os tests (Greentea or Unittest)
[] Tests / results supplied as part of this PR

Reviewers


@ciarmcom
Copy link
Member

@hugueskamba, thank you for your changes.
@ARMmbed/mbed-os-maintainers please review.

0xc0170
0xc0170 previously approved these changes Oct 23, 2020
@0xc0170
Copy link
Contributor

0xc0170 commented Oct 23, 2020

@rajkan01 Please review, once approved, I'll merge examples and this one.

* mbed-os renamed mbed-core
* mbed-os-<COMPONENT> renamed mbed-<COMPONENT>
This ensures that applications which link with the mbed-os
CMake target still work. We want applications that require the OS
to use the mbed-os CMake target as we will be creating a new one
that will include mbed-core and mbed-rtos.
@hugueskamba hugueskamba force-pushed the hk_cmake_rename_targets branch from a178bb8 to b1512ce Compare October 23, 2020 09:38
@mergify mergify bot dismissed 0xc0170’s stale review October 23, 2020 09:39

Pull request has been modified.

Copy link
Contributor

@rajkan01 rajkan01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@0xc0170
Copy link
Contributor

0xc0170 commented Oct 23, 2020

Travis is pending for already more than a hour, queue is empty 😭 Trying to find out what is going on.

@0xc0170
Copy link
Contributor

0xc0170 commented Oct 23, 2020

Tested with 2 examples, as Travis is not progressing and this is blocking other PRs. I'll merge this to the feature branch.

@0xc0170 0xc0170 merged commit fee3e9f into ARMmbed:feature-cmake Oct 23, 2020
@0xc0170 0xc0170 removed the needs: CI label Oct 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants