Skip to content

Remove STM's qspi_api trace which is verbose and slows down operations #13804

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Remove STM's qspi_api trace which is verbose and slows down operations #13804

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 0 additions & 19 deletions targets/TARGET_STM/qspi_api.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,14 +25,6 @@
#include "pinmap.h"
#include "PeripheralPins.h"

#include "mbed-trace/mbed_trace.h"

#if defined(OCTOSPI1)
#define TRACE_GROUP "STOS"
#else
#define TRACE_GROUP "STQS"
#endif /* OCTOSPI1 */

// activate / de-activate extra debug
#define qspi_api_c_debug 0

Expand Down Expand Up @@ -387,8 +379,6 @@ qspi_status_t qspi_init_direct(qspi_t *obj, const qspi_pinmap_t *pinmap, uint32_
static qspi_status_t _qspi_init_direct(qspi_t *obj, const qspi_pinmap_t *pinmap, uint32_t hz, uint8_t mode)
#endif
{
tr_info("qspi_init mode %u", mode);

// Reset handle internal state
obj->handle.State = HAL_OSPI_STATE_RESET;

Expand Down Expand Up @@ -535,7 +525,6 @@ qspi_status_t qspi_init_direct(qspi_t *obj, const qspi_pinmap_t *pinmap, uint32_
static qspi_status_t _qspi_init_direct(qspi_t *obj, const qspi_pinmap_t *pinmap, uint32_t hz, uint8_t mode)
#endif
{
tr_info("qspi_init mode %u", mode);
// Enable interface clock for QSPI
__HAL_RCC_QSPI_CLK_ENABLE();

Expand Down Expand Up @@ -632,7 +621,6 @@ qspi_status_t qspi_init(qspi_t *obj, PinName io0, PinName io1, PinName io2, PinN
#if defined(OCTOSPI1)
qspi_status_t qspi_free(qspi_t *obj)
{
tr_info("qspi_free");
if (HAL_OSPI_DeInit(&obj->handle) != HAL_OK) {
return QSPI_STATUS_ERROR;
}
Expand Down Expand Up @@ -664,8 +652,6 @@ qspi_status_t qspi_free(qspi_t *obj)
#else /* OCTOSPI */
qspi_status_t qspi_free(qspi_t *obj)
{
tr_info("qspi_free");

if (HAL_QSPI_DeInit(&obj->handle) != HAL_OK) {
return QSPI_STATUS_ERROR;
}
Expand Down Expand Up @@ -701,7 +687,6 @@ qspi_status_t qspi_free(qspi_t *obj)
#if defined(OCTOSPI1)
qspi_status_t qspi_frequency(qspi_t *obj, int hz)
{
tr_info("qspi_frequency hz %d", hz);
qspi_status_t status = QSPI_STATUS_OK;

/* HCLK drives QSPI. QSPI clock depends on prescaler value:
Expand All @@ -728,7 +713,6 @@ qspi_status_t qspi_frequency(qspi_t *obj, int hz)
#else /* OCTOSPI */
qspi_status_t qspi_frequency(qspi_t *obj, int hz)
{
tr_info("qspi_frequency hz %d", hz);
qspi_status_t status = QSPI_STATUS_OK;

/* HCLK drives QSPI. QSPI clock depends on prescaler value:
Expand Down Expand Up @@ -863,8 +847,6 @@ qspi_status_t qspi_read(qspi_t *obj, const qspi_command_t *command, void *data,
#if defined(OCTOSPI1)
qspi_status_t qspi_command_transfer(qspi_t *obj, const qspi_command_t *command, const void *tx_data, size_t tx_size, void *rx_data, size_t rx_size)
{
tr_info("qspi_command_transfer tx %u rx %u command %#04x", tx_size, rx_size, command->instruction.value);

qspi_status_t status = QSPI_STATUS_OK;

if ((tx_data == NULL || tx_size == 0) && (rx_data == NULL || rx_size == 0)) {
Expand Down Expand Up @@ -903,7 +885,6 @@ qspi_status_t qspi_command_transfer(qspi_t *obj, const qspi_command_t *command,
#else /* OCTOSPI */
qspi_status_t qspi_command_transfer(qspi_t *obj, const qspi_command_t *command, const void *tx_data, size_t tx_size, void *rx_data, size_t rx_size)
{
tr_info("qspi_command_transfer tx %u rx %u command %#04x", tx_size, rx_size, command->instruction.value);
qspi_status_t status = QSPI_STATUS_OK;

if ((tx_data == NULL || tx_size == 0) && (rx_data == NULL || rx_size == 0)) {
Expand Down