Skip to content

Remove erroneous character from SPDX identifer #13808

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 27, 2020
Merged

Remove erroneous character from SPDX identifer #13808

merged 1 commit into from
Oct 27, 2020

Conversation

harmut01
Copy link
Contributor

@harmut01 harmut01 commented Oct 23, 2020 •
edited
Loading

Summary of changes

Fixes #13807

Backslash was erroneously appended to comment line for SPDX identifier in some files. Removes backslash from affected files.

Impact of changes

None

Migration actions required

None

Documentation

None

Pull request type 

[x] Patch update (Bug fix / Target update / Docs update / Test update / Refactor)
[] Feature update (New feature / Functionality change / New API)
[] Major update (Breaking change E.g. Return code change / API behaviour change)

Test results 

[x] No Tests required for this change (E.g docs only update)
[] Covered by existing mbed-os tests (Greentea or Unittest)
[] Tests / results supplied as part of this PR

Reviewers

@ARMmbed/mbed-os-maintainers @0xc0170

@harrisonmutai-arm
Remove erroneous character from SPDX identifer
6bfe651 
Erroneous '/' was appended to start of comment. This was causing CMake
warning during complition. Removes character from affected files.
@ciarmcom ciarmcom added the release-type: patch Indentifies a PR as containing just a patch label Oct 23, 2020
@ciarmcom ciarmcom requested review from 0xc0170 and a team October 23, 2020 14:30
@ciarmcom
Copy link
Member

@harmut01, thank you for your changes.
@0xc0170 @ARMmbed/mbed-os-maintainers please review.

@mergify mergify bot added needs: CI and removed needs: review labels Oct 26, 2020
@0xc0170
Copy link
Contributor

0xc0170 commented Oct 26, 2020

CI started

@mbed-ci
Copy link

mbed-ci commented Oct 26, 2020

Jenkins CI Test : ✔️ SUCCESS

Build Number: 1 | 🔒 Jenkins CI Job | 🌐 Logs & Artifacts

CLICK for Detailed Summary

jobs Status
jenkins-ci/mbed-os-ci_unittests ✔️
jenkins-ci/mbed-os-ci_build-greentea-GCC_ARM ✔️
jenkins-ci/mbed-os-ci_build-greentea-ARM ✔️
jenkins-ci/mbed-os-ci_build-example-ARM ✔️
jenkins-ci/mbed-os-ci_build-example-GCC_ARM ✔️
jenkins-ci/mbed-os-ci_build-cloud-example-ARM ✔️
jenkins-ci/mbed-os-ci_build-cloud-example-GCC_ARM ✔️
jenkins-ci/mbed-os-ci_dynamic-memory-usage ✔️
jenkins-ci/mbed-os-ci_greentea-test ✔️
jenkins-ci/mbed-os-ci_cloud-client-pytest ✔️

@0xc0170 0xc0170 merged commit 78c8d84 into ARMmbed:master Oct 27, 2020
@0xc0170 0xc0170 mentioned this pull request Oct 27, 2020
Closed
@mergify mergify bot removed the ready for merge label Oct 27, 2020
@harmut01 harmut01 deleted the license_refactor branch October 27, 2020 09:42
@mbedmain mbedmain added release-version: 6.5.0 Release-pending and removed release-type: patch Indentifies a PR as containing just a patch Release-pending labels Nov 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@0xc0170 0xc0170 0xc0170 approved these changes

Assignees
No one assigned
Labels
release-version: 6.5.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

SPDX licenses in some cases cause a warning
6 participants
@harmut01 @ciarmcom @0xc0170 @mbed-ci @mbedmain @harrisonmutai-arm