Fix GCC_ARM non-contiguous FW for K64F and K66F
#13832
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ciarmcom
added
the
release-type: patch
|
@moshe-shahar, thank you for your changes. |
|
@0xc0170 Can you please get this one reviewed, it solves pyocd flashing issue for PDMC which is used in CI flow. |
0xc0170
reviewed
Oct 29, 2020
There was a problem hiding this comment.
I checked, same should be applied to also .sct file (I understand this is for GCC_ARM, but can we fix quickly also ARMCLang?
#define m_interrupts_start MBED_APP_START
#define m_interrupts_size 0x00000400
#define m_flash_config_start MBED_APP_START + 0x400
#define m_flash_config_size 0x00000010
#define m_text_start MBED_APP_START + 0x410
#define m_text_size MBED_APP_SIZE - 0x410
Can you add it here so then K64F MCU is fixed completely?
Or is this only GCC ARM issue?
|
+1, IAR is not supported anyway. |
moshe-shahar
force-pushed
the
fix-gcc-non-contiguous
branch
from
3894494 to
49a6db2
Compare
|
@0xc0170, |
moshe-shahar
changed the title
K64F and K66F
kjbracey
reviewed
Oct 29, 2020
| @@ -63,12 +65,21 @@ | |||
| #define m_interrupts_start MBED_APP_START | |||
| #define m_interrupts_size 0x00000400 | |||
|
|
|||
| #if MBED_APP_SIZE == 0 | |||
There was a problem hiding this comment.
Surely you mean MBED_APP_START == 0?
There was a problem hiding this comment.
Yes. The flash config is needed only if MBED_APP_START is 0 since that config has fix address in the HW.
0xc0170
reviewed
Oct 29, 2020
| #define m_flash_config_start MBED_APP_START + 0x400 | ||
| #define m_flash_config_size 0x00000010 | ||
|
|
||
| #define m_text_start MBED_APP_START + 0x410 | ||
| #define m_text_size MBED_APP_SIZE - 0x410 | ||
|
|
||
| #else | ||
|
|
||
| #define m_text_start MBED_APP_START + 0x400 |
There was a problem hiding this comment.
Why was this 0x400 padding left (due to vectors, that are used below in ROM) ? Its not present in GCC ARM if MBED_APP_SIZE is 0
There was a problem hiding this comment.
for the interrupts area. In GCC_ARM I moved the interrupts to the .text area.
In ARM, everything was in LR_IROM1 from the beginning.
0xc0170
previously approved these changes
Oct 29, 2020
|
CI started |
Jenkins CI Test : ❌ FAILEDBuild Number: 1 | 🔒 Jenkins CI Job | 🌐 Logs & ArtifactsCLICK for Detailed Summary
|
Jenkins CI Test : ❌ FAILEDBuild Number: 2 | 🔒 Jenkins CI Job | 🌐 Logs & ArtifactsCLICK for Detailed Summary
|
|
we are checking currently cloud client issue (other PRs are affected). However greentea test are related to K64F changes - they are timeouts. Can you reproduce one of the failures (one of the tests) ? |
added 3 commits
November 12, 2020 17:14
This will also fix GCC_ARM non-contiguous FW: Issue: ARMmbed#13831
moshe-shahar
force-pushed
the
fix-gcc-non-contiguous
branch
from
7e2de1d to
ca39f95
Compare
mergify
bot
dismissed
0xc0170’s stale review
Pull request has been modified.
|
Found incorrect condition. rebase and fix it. |
|
CI restarted |
Jenkins CI Test : ❌ FAILEDBuild Number: 3 | 🔒 Jenkins CI Job | 🌐 Logs & ArtifactsCLICK for Detailed Summary
|
|
I run could client test locally and it passed. |
|
CI restarted |
Jenkins CI Test : ❌ FAILEDBuild Number: 4 | 🔒 Jenkins CI Job | 🌐 Logs & ArtifactsCLICK for Detailed Summary
|
|
Ci restarted |
Jenkins CI Test : ❌ FAILEDBuild Number: 5 | 🔒 Jenkins CI Job | 🌐 Logs & ArtifactsCLICK for Detailed Summary
|
Jenkins CI Test : ✔️ SUCCESSBuild Number: 6 | 🔒 Jenkins CI Job | 🌐 Logs & ArtifactsCLICK for Detailed Summary
|
0xc0170
approved these changes
Nov 17, 2020
|
Hooray 👏 |
mbedmain
added
release-version: 6.5.0
Release-pending
and removed
release-type: patch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
K64FandK66Ffix for Issue: #13831Summary of changes
Removing
m_flash_configon relocated applications. It has a fixed address in the HW and is not required in the app.Combine
m_interruptsandm_textinto one area on relocated applications to prevent a non-contiguous FW app.Impact of changes
K64FandK64FtargetsMigration actions required
Documentation
Pull request type
Test results
Reviewers