Ambiq apollo3 fix of an SPI related SD bug #13861
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Modified line 145: previously the fill character has been hard coded to 0x00. However in Mbed OS core SPI_FILL_CHAR is defined in the core to be 0xFF by default (one can change that through mbed_app.json for example). This mod allows us to use the same fill character that is defined for Mbed OS. Also modified spi_master_block_write(): previously it called am_hal_iom_blocking_transfer on line 182, but that prevented succesful SD card writing operations. Now i changed that part to am_hal_iom_spi_blocking_fullduplex and SD functionality seems to be working.
Modified the spi_master_block_write() function yet again. SD related examples still read/erase/write the SD cards as expected and with these alterations the power consumption does not remain high after the SPI transaction has been finished. However i still only tested the SD functionality. Please test other SPI scenarios and different sensors as well to find out if this PR introduces unexpected bugs or not.
Changes:
- deleted the whole if (xfer.ui32NumBytes) condition as i did not find it logical (by that i mean xfer.ui32NumBytes was also true within the following else if (tx_length != rx_length){} block, so basically when the 2 buffers had different lengths an extra transfer has been done for nothing)
- removed the bool Rw = (rx_length >= tx_length) as the comparison >= has no sense anymore after if (tx_length == rx_length) on line 159.
|
@Wenn0101 Please review |
ciarmcom
added
the
release-type: patch
|
@idea--list, thank you for your changes. |
0xc0170
approved these changes
Nov 5, 2020
|
CI started |
Jenkins CI Test : ✔️ SUCCESSBuild Number: 1 | 🔒 Jenkins CI Job | 🌐 Logs & ArtifactsCLICK for Detailed Summary
|
mbedmain
added
release-version: 6.5.0
Release-pending
and removed
release-type: patch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of changes
While trying to implement SD functionality on the Artemis Thing Plus board i discovered that SDBlockDevice::program() fails for that target. After some investigation i found the root of the issue in spi_api.c for this target. Modifications:
spi_master_write()spi_master_block_write()has been called with a hard-coded 0x00 fill character before, now it is changed to SPI_FILL_CHAR to be in synch with the fill char set in the Mbed configuration.spi_master_block_write()previously it called am_hal_iom_blocking_transfer on line 182, but that prevented succesful SD card writing operations. This PR also changes that part to am_hal_iom_spi_blocking_fullduplex and SD functionality seems to be working.Impact of changes
Enables succesfull SD-writes with the Apollo3 processor family, while other SPI functionalities seem to be preserved (tested with an eink and also an ADC which communicate over SPI).
Migration actions required
None
Documentation
Pull request type
Test results
Reviewers