Skip to content

CMake: Fix Microlib selection #13871

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

hugueskamba
Copy link
Collaborator

@hugueskamba hugueskamba commented Nov 5, 2020

Summary of changes

Fixes #13858

As the assembler does not seem to recognise the request to the
linker to use Microlib, remove that instruction.

Microlib is still used as the linker selects microlib as a result
of being explicitly asked to do so.

mbed-os-example-blinky with Microlib

Total Static RAM memory (data + bss): 9305(+9305) bytes
Total Flash memory (text + data): 35711(+35711) bytes

mbed-os-example-blinky with ARM standard C library

Total Static RAM memory (data + bss): 10374(+10374) bytes
Total Flash memory (text + data): 40482(+40482) bytes

Microlib selection documentation:
https://developer.arm.com/documentation/dui0808/e/the-arm-c-micro-library/building-an-application-with-microlib

Impact of changes

Migration actions required

Documentation


Pull request type

[x] Patch update (Bug fix / Target update / Docs update / Test update / Refactor)
[] Feature update (New feature / Functionality change / New API)
[] Major update (Breaking change E.g. Return code change / API behaviour change)

Test results

[] No Tests required for this change (E.g docs only update)
[x] Covered by existing mbed-os tests (Greentea or Unittest)
[] Tests / results supplied as part of this PR

Reviewers


As the assembler does not seem to recognise the request to the
linker to use microlib, remove that instruction.
Microlib is still used as the linker selects microlib as a result
of being explicitly asked to do so.
@ciarmcom
Copy link
Member

ciarmcom commented Nov 5, 2020

@hugueskamba, thank you for your changes.
@ARMmbed/mbed-os-maintainers please review.

Copy link
Contributor

@0xc0170 0xc0170 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Use --library_type=microlib with the linker to override all other options.

👍

@hugueskamba hugueskamba merged commit 66dcd94 into ARMmbed:feature-cmake Nov 6, 2020
@hugueskamba hugueskamba deleted the hk_cmake_fix_microlib_selection branch November 6, 2020 09:30
@MarceloSalazar
Copy link

Works like a charm :)

hugueskamba added a commit that referenced this pull request Nov 6, 2020
As the assembler does not seem to recognise the request to the
linker to use microlib, remove that instruction.
Microlib is still used as the linker selects microlib as a result
of being explicitly asked to do so.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants