Skip to content

S1SBP6A fix RTC range #13880

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 12, 2020
Merged

S1SBP6A fix RTC range #13880

merged 1 commit into from
Nov 12, 2020

Conversation

heuisam
Copy link
Contributor

@heuisam heuisam commented Nov 9, 2020

BP6A do not support from 0 to 0xEFFFFFFF in SOC.
This patch fixes it in s/w manner.

Signed-off-by: Heuisam Kwag [email protected]

Summary of changes

BP6A do not support from 0 to 0xEFFFFFFF in SOC register.
This patch fixes #13876 in s/w manner.

Impact of changes

Migration actions required

Documentation


Pull request type

[x] Patch update (Bug fix / Target update / Docs update / Test update / Refactor)
[] Feature update (New feature / Functionality change / New API)
[] Major update (Breaking change E.g. Return code change / API behaviour change)

Test results

[x] No Tests required for this change (E.g docs only update)
[] Covered by existing mbed-os tests (Greentea or Unittest)
[] Tests / results supplied as part of this PR

Reviewers


@ciarmcom ciarmcom added the release-type: patch Indentifies a PR as containing just a patch label Nov 9, 2020
@ciarmcom ciarmcom requested a review from a team November 9, 2020 11:30
@ciarmcom
Copy link
Member

ciarmcom commented Nov 9, 2020

@heuisam, thank you for your changes.
@ARMmbed/mbed-os-maintainers please review.

@MarceloSalazar
Copy link

One remaining RTC test fails

| target        | platform_name | test suite                                 | test case                                  | passed | failed | result | elapsed_time (sec) |
|---------------|---------------|--------------------------------------------|--------------------------------------------|--------|--------|--------|--------------------|
| S1SBP6A-ARMC6 | S1SBP6A       | mbed-os-hal-tests-tests-mbed_hal-rtc_reset | mbed-os-hal-tests-tests-mbed_hal-rtc_reset | 0      | 1      | FAIL   | 27.09  

0xc0170
0xc0170 previously approved these changes Nov 9, 2020
@mergify mergify bot dismissed 0xc0170’s stale review November 11, 2020 04:43

Pull request has been modified.

@heuisam
Copy link
Contributor Author

heuisam commented Nov 11, 2020

@MarceloSalazar

One remaining RTC test fails

| target        | platform_name | test suite                                 | test case                                  | passed | failed | result | elapsed_time (sec) |
|---------------|---------------|--------------------------------------------|--------------------------------------------|--------|--------|--------|--------------------|
| S1SBP6A-ARMC6 | S1SBP6A       | mbed-os-hal-tests-tests-mbed_hal-rtc_reset | mbed-os-hal-tests-tests-mbed_hal-rtc_reset | 0      | 1      | FAIL   | 27.09  

I didn't check side effect, I update PR to fix it.

BP6A do not support from 0 to 0xEFFFFFFF in SOC.
This patch fixes it in s/w manner.

Signed-off-by: Heuisam Kwag <[email protected]>
Copy link

@MarceloSalazar MarceloSalazar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All RTC tests pass with both Arm and GCC toolchain. Thanks!

@mergify mergify bot added needs: CI and removed needs: work labels Nov 11, 2020
@MarceloSalazar
Copy link

@ARMmbed/mbed-os-maintainers please review and kick off CI to merge in time for the upcoming 6.x.y release

@0xc0170
Copy link
Contributor

0xc0170 commented Nov 11, 2020

CI started

@mbed-ci
Copy link

mbed-ci commented Nov 11, 2020

Jenkins CI Test : ✔️ SUCCESS

Build Number: 1 | 🔒 Jenkins CI Job | 🌐 Logs & Artifacts

CLICK for Detailed Summary

jobs Status
jenkins-ci/mbed-os-ci_unittests ✔️
jenkins-ci/mbed-os-ci_build-example-ARM ✔️
jenkins-ci/mbed-os-ci_build-example-GCC_ARM ✔️
jenkins-ci/mbed-os-ci_cmake-example-ARM ✔️
jenkins-ci/mbed-os-ci_build-cloud-example-GCC_ARM ✔️
jenkins-ci/mbed-os-ci_build-cloud-example-ARM ✔️
jenkins-ci/mbed-os-ci_build-greentea-ARM ✔️
jenkins-ci/mbed-os-ci_build-greentea-GCC_ARM ✔️
jenkins-ci/mbed-os-ci_cmake-example-GCC_ARM ✔️
jenkins-ci/mbed-os-ci_dynamic-memory-usage ✔️
jenkins-ci/mbed-os-ci_cloud-client-pytest ✔️
jenkins-ci/mbed-os-ci_cmake-example-test ✔️
jenkins-ci/mbed-os-ci_greentea-test ✔️

@0xc0170 0xc0170 merged commit 3239868 into ARMmbed:master Nov 12, 2020
@mergify mergify bot removed the ready for merge label Nov 12, 2020
@mbedmain mbedmain added release-version: 6.5.0 Release-pending and removed release-type: patch Indentifies a PR as containing just a patch Release-pending labels Nov 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

S1SBP6A fails to run RTC Greentea tests
6 participants