Skip to content

CMake: Specify mbedtools in the build instructions #13887

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 12, 2020
Merged

CMake: Specify mbedtools in the build instructions #13887

merged 1 commit into from
Nov 12, 2020
+14 −10

Conversation

hugueskamba
Copy link
Collaborator

Summary of changes

mbedtools provides a more user friendly UX for
building application.

Impact of changes

Migration actions required

Documentation

Pull request type 

[x] Patch update (Bug fix / Target update / Docs update / Test update / Refactor)
[] Feature update (New feature / Functionality change / New API)
[] Major update (Breaking change E.g. Return code change / API behaviour change)

Test results 

[] No Tests required for this change (E.g docs only update)
[x] Covered by existing mbed-os tests (Greentea or Unittest)
[] Tests / results supplied as part of this PR

Reviewers

rajkan01
rajkan01 approved these changes Nov 9, 2020
View reviewed changes
Copy link
Contributor

@rajkan01 rajkan01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ciarmcom ciarmcom added the release-type: patch Indentifies a PR as containing just a patch label Nov 9, 2020
@ciarmcom ciarmcom requested review from a team November 9, 2020 18:30
@ciarmcom
Copy link
Member

ciarmcom commented Nov 9, 2020

@hugueskamba, thank you for your changes.
@ARMmbed/mbed-os-tools @ARMmbed/mbed-os-maintainers please review.

ladislas
ladislas reviewed Nov 9, 2020
View reviewed changes
0xc0170
0xc0170 previously approved these changes Nov 10, 2020
View reviewed changes
@hugueskamba hugueskamba force-pushed the hk_cmake_update_build_instructions branch from ad7be28 to 6abb984 Compare November 10, 2020 18:04
@mergify mergify bot dismissed 0xc0170’s stale review November 10, 2020 18:04

Pull request has been modified.

@hugueskamba
CMake: Specify mbedtools in the build instructions
97c7a38 
mbedtools provides a more user friendly UX for
building application.
@hugueskamba hugueskamba force-pushed the hk_cmake_update_build_instructions branch from 6abb984 to 97c7a38 Compare November 10, 2020 18:54
@mergify mergify bot added needs: CI and removed needs: review labels Nov 12, 2020
@0xc0170
Copy link
Contributor

0xc0170 commented Nov 12, 2020

I'll start CI soon, to have this integrated for the upcoming release.

@0xc0170 0xc0170 merged commit 66c05dd into ARMmbed:master Nov 12, 2020
@mergify mergify bot removed the ready for merge label Nov 12, 2020
@hugueskamba hugueskamba deleted the hk_cmake_update_build_instructions branch November 16, 2020 13:07
@mbedmain mbedmain added release-version: 6.5.0 Release-pending and removed release-type: patch Indentifies a PR as containing just a patch Release-pending labels Nov 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rwalton-arm rwalton-arm rwalton-arm left review comments

@ladislas ladislas ladislas approved these changes

@0xc0170 0xc0170 0xc0170 approved these changes

@rajkan01 rajkan01 rajkan01 approved these changes

Assignees
No one assigned
Labels
release-version: 6.5.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@hugueskamba @ciarmcom @0xc0170 @ladislas @rwalton-arm @rajkan01 @mbedmain