CMake: add nuvoton targets #13922
Merged
CMake: add nuvoton targets #13922
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ciarmcom
added
the
release-type: patch
|
@0xc0170, thank you for your changes. |
ccli8
reviewed
Nov 19, 2020
|
|
||
| if("NUMAKER_IOT_M252" IN_LIST MBED_TARGET_LABELS) | ||
| add_subdirectory(TARGET_NUMAKER_IOT_M252) | ||
| endif() |
|
@0xc0170 , About some hex files in TARGET_M2351, it's the pre-built secure image, such like as some loader binary files. |
ccli8
reviewed
Nov 19, 2020
| set(LINKER_FILE device/TOOLCHAIN_GCC_ARM/TARGET_NU_XRAM_SUPPORTED/NUC472.sct) | ||
| elseif("NU_XRAM_UNSUPPORTED" IN_LIST MBED_TARGET_LABELS) | ||
| set(LINKER_FILE device/TOOLCHAIN_GCC_ARM/TARGET_NU_XRAM_UNSUPPORTED/NUC472.sct) | ||
| endif() |
There was a problem hiding this comment.
Should be TOOLCHAIN_ARM_STD
|
Thank you for review, I'll remove .hex files from CMake for now - if there is a folder with only .hex files, I won't add CMake. I'll also fix the comments and let you know once updated. |
|
@cyliangtw @ccli8 updated. |
cyliangtw
reviewed
Nov 23, 2020
| set(LINKER_FILE device/TOOLCHAIN_GCC_ARM/M251.ld) | ||
| elseif(${MBED_TOOLCHAIN} STREQUAL "ARM") | ||
| set(LINKER_FILE device/TOOLCHAIN_ARM_STD/M251.sct) | ||
| endif() |
There was a problem hiding this comment.
Also support IAR linker file, such like as ?
elseif(${MBED_TOOLCHAIN} STREQUAL "IAR")
set(LINKER_FILE device/TOOLCHAIN_IAR/M251.icf)
endif()
There was a problem hiding this comment.
we do not support IAR with CMake , thus we do not port it neither. If IAR is supported, we will need to add targets support (will be done via separate PRs).
cyliangtw
approved these changes
Nov 23, 2020
ccli8
approved these changes
Nov 24, 2020
|
I requested additional review, meanwhile started CI |
Jenkins CI Test : ✔️ SUCCESSBuild Number: 1 | 🔒 Jenkins CI Job | 🌐 Logs & ArtifactsCLICK for Detailed Summary
|
|
One more fix needed, .sct files need updating the comment for preprocessor. I'll fix now |
0xc0170
force-pushed
the
cmake-nuvoton
branch
from
1da77b8 to
0efffa3
Compare
|
CI started ARMClang fixed |
Jenkins CI Test : ❌ FAILEDBuild Number: 2 | 🔒 Jenkins CI Job | 🌐 Logs & ArtifactsCLICK for Detailed Summary
|
|
CI restarted |
Jenkins CI Test : ❌ FAILEDBuild Number: 3 | 🔒 Jenkins CI Job | 🌐 Logs & ArtifactsCLICK for Detailed Summary
|
Jenkins CI Test : ✔️ SUCCESSBuild Number: 4 | 🔒 Jenkins CI Job | 🌐 Logs & ArtifactsCLICK for Detailed Summary
|
mbedmain
added
release-version: 6.6.0
Release-pending
and removed
release-type: patch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of changes
Adding NUVOTON targets.
Note, there are some hex files. I added them as sources but I need more help to understand how they should be processed. I could not quickly find some references in Readme files in their directories or in the old tools.
We do not yet support TFM.
Impact of changes
Migration actions required
Documentation
Pull request type
Test results
Reviewers