Skip to content

Update to reflect Mbed CLI 2 changes #13946

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 11, 2020
Merged

Update to reflect Mbed CLI 2 changes #13946

merged 1 commit into from
Dec 11, 2020

Conversation

jainvikas8
Copy link
Contributor

@jainvikas8 jainvikas8 commented Nov 23, 2020 •
edited
Loading

Summary of changes

Due to the recent release of Mbed CLI 2, the command line options
have been renamed to ensure good usability and harmonize with the old
tools.

These are the following changes done:

  • Cmake - 3.19.0 is required
  • Mbed-tools - 4.0.0 is required
  • mbed-tools cmd init to new
  • mbed-tools cmd build to compile

Impact of changes

None

Migration actions required

Documentation

Updating docs

Pull request type 

[x] Patch update (Bug fix / Target update / Docs update / Test update / Refactor)
[] Feature update (New feature / Functionality change / New API)
[] Major update (Breaking change E.g. Return code change / API behaviour change)

Test results 

[] No Tests required for this change (E.g docs only update)
[x] Covered by existing mbed-os tests (Greentea or Unittest)
[] Tests / results supplied as part of this PR

Reviewers

@Patater @rwalton-arm @urutva

@ciarmcom ciarmcom added the release-type: patch Indentifies a PR as containing just a patch label Nov 23, 2020
@ciarmcom ciarmcom requested review from Patater, rwalton-arm, urutva and a team November 23, 2020 15:00
@ciarmcom
Copy link
Member

@jainvikas8, thank you for your changes.
@urutva @Patater @rwalton-arm @ARMmbed/mbed-os-tools @ARMmbed/mbed-os-maintainers please review.

@jainvikas8 jainvikas8 changed the title [WIP] Update to reflect Mbed CLI 2 changes Update to reflect Mbed CLI 2 changes Nov 24, 2020
@mergify
Copy link

mergify bot commented Nov 24, 2020

This PR cannot be merged due to conflicts. Please rebase to resolve them.

Patater
Patater previously approved these changes Nov 24, 2020
View reviewed changes
Copy link
Contributor

@Patater Patater left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can be merged when tools are released and updated in Mbed CI, to fix CI

@jainvikas8
Copy link
Contributor Author

@jamesbeyond Please review.

@jainvikas8 jainvikas8 force-pushed the update-mbed-cli-2-cmds branch from 764395a to 8e3942f Compare November 25, 2020 10:24
@mergify mergify bot dismissed Patater’s stale review November 25, 2020 10:24

Pull request has been modified.

@jainvikas8
Copy link
Contributor Author

Forced pushed to resolve conflicts

0xc0170
0xc0170 previously approved these changes Nov 25, 2020
View reviewed changes
@mergify mergify bot added needs: CI and removed needs: work labels Nov 25, 2020
@0xc0170
Copy link
Contributor

0xc0170 commented Nov 25, 2020

@rajkan01 we should update testing examples with the new commands

@0xc0170
Copy link
Contributor

0xc0170 commented Nov 25, 2020

Can be merged when tools are released and updated in Mbed CI, to fix CI

Let us know once it is completed

@0xc0170
Copy link
Contributor

0xc0170 commented Nov 25, 2020

CI started meanwhile

@mergify mergify bot added needs: work and removed needs: CI labels Nov 25, 2020
@mbed-ci
Copy link

mbed-ci commented Nov 25, 2020

Jenkins CI Test : ❌ FAILED

Build Number: 1 | 🔒 Jenkins CI Job | 🌐 Logs & Artifacts

CLICK for Detailed Summary

jobs Status
jenkins-ci/mbed-os-ci_unittests ✔️
jenkins-ci/mbed-os-ci_cmake-example-ARM ❌
jenkins-ci/mbed-os-ci_cmake-example-GCC_ARM ❌
jenkins-ci/mbed-os-ci_build-greentea-ARM ✔️
jenkins-ci/mbed-os-ci_build-cloud-example-GCC_ARM ✔️
jenkins-ci/mbed-os-ci_build-greentea-GCC_ARM ✔️
jenkins-ci/mbed-os-ci_build-example-ARM ✔️
jenkins-ci/mbed-os-ci_build-example-GCC_ARM ✔️
jenkins-ci/mbed-os-ci_build-cloud-example-ARM ✔️

@jainvikas8
Copy link
Contributor Author

jainvikas8 commented Nov 25, 2020 •
edited
Loading

Jenkins CI Test : ❌ FAILED

Build Number: 1 | 🔒 Jenkins CI Job | 🌐 Logs & Artifacts

CLICK for Detailed Summary
jobs Status
jenkins-ci/mbed-os-ci_unittests ✔️
jenkins-ci/mbed-os-ci_cmake-example-ARM ❌
jenkins-ci/mbed-os-ci_cmake-example-GCC_ARM ❌
jenkins-ci/mbed-os-ci_build-greentea-ARM ✔️
jenkins-ci/mbed-os-ci_build-cloud-example-GCC_ARM ✔️
jenkins-ci/mbed-os-ci_build-greentea-GCC_ARM ✔️
jenkins-ci/mbed-os-ci_build-example-ARM ✔️
jenkins-ci/mbed-os-ci_build-example-GCC_ARM ✔️
jenkins-ci/mbed-os-ci_build-cloud-example-ARM ✔️

This issue will be fixed when the new Mbedtools is released and the Jenkins updated to use them.

@jainvikas8 jainvikas8 force-pushed the update-mbed-cli-2-cmds branch from 8e3942f to 92f25e1 Compare November 30, 2020 12:21
@mergify mergify bot dismissed 0xc0170’s stale review November 30, 2020 12:22

Pull request has been modified.

@jainvikas8 jainvikas8 force-pushed the update-mbed-cli-2-cmds branch from 92f25e1 to c588501 Compare November 30, 2020 12:22
@jainvikas8
Copy link
Contributor Author

Rebased and force pushed to change release version of Mbed CLI 2

@0xc0170
Copy link
Contributor

0xc0170 commented Dec 1, 2020

@ARMmbed/mbed-os-test has mbed-tools been updated in CI? once yes, please start CI job for this one.

@mergify
Copy link

mergify bot commented Dec 1, 2020

This PR cannot be merged due to conflicts. Please rebase to resolve them.

@jainvikas8
docs: Update to reflect Mbed CLI 2 changes
8b70ae1 
Due to the recent release of Mbed CLI 2, the command line options
have been renamed to ensure good usability and harmonize with the old
tools.

These are the following changes done:
* Minimum Cmake - 3.19.0 is required
* Minimum Mbed-tools - 4.0.0 is required
* mbed-tools cmd `init` to `new`
* mbed-tools cmd `build` to `compile`
* Removed whitespaces
@jainvikas8 jainvikas8 force-pushed the update-mbed-cli-2-cmds branch from c588501 to 8b70ae1 Compare December 1, 2020 14:59
@jainvikas8
Copy link
Contributor Author

Rebased to resolve conflicts

@0xc0170
Copy link
Contributor

0xc0170 commented Dec 10, 2020

CI restarted

This should be part of the upcoming release

@mergify mergify bot added needs: work and removed needs: CI labels Dec 10, 2020
@mbed-ci
Copy link

mbed-ci commented Dec 10, 2020

Jenkins CI Test : ❌ FAILED

Build Number: 2 | 🔒 Jenkins CI Job | 🌐 Logs & Artifacts

CLICK for Detailed Summary

jobs Status
jenkins-ci/mbed-os-ci_unittests ✔️
jenkins-ci/mbed-os-ci_cmake-example-ARM ❌
jenkins-ci/mbed-os-ci_cmake-example-GCC_ARM ❌
jenkins-ci/mbed-os-ci_build-greentea-ARM ✔️
jenkins-ci/mbed-os-ci_build-greentea-GCC_ARM ✔️
jenkins-ci/mbed-os-ci_build-cloud-example-ARM ✔️
jenkins-ci/mbed-os-ci_build-example-GCC_ARM ✔️
jenkins-ci/mbed-os-ci_build-example-ARM ✔️
jenkins-ci/mbed-os-ci_build-cloud-example-GCC_ARM ✔️

@jamesbeyond
Copy link
Contributor

CI restarted, after tools update

@mbed-ci
Copy link

mbed-ci commented Dec 11, 2020

Jenkins CI Test : ✔️ SUCCESS

Build Number: 3 | 🔒 Jenkins CI Job | 🌐 Logs & Artifacts

CLICK for Detailed Summary

jobs Status
jenkins-ci/mbed-os-ci_unittests ✔️
jenkins-ci/mbed-os-ci_cmake-example-GCC_ARM ✔️
jenkins-ci/mbed-os-ci_cmake-example-ARM ✔️
jenkins-ci/mbed-os-ci_build-greentea-GCC_ARM ✔️
jenkins-ci/mbed-os-ci_build-greentea-ARM ✔️
jenkins-ci/mbed-os-ci_build-example-ARM ✔️
jenkins-ci/mbed-os-ci_build-example-GCC_ARM ✔️
jenkins-ci/mbed-os-ci_build-cloud-example-ARM ✔️
jenkins-ci/mbed-os-ci_build-cloud-example-GCC_ARM ✔️
jenkins-ci/mbed-os-ci_greentea-test ✔️
jenkins-ci/mbed-os-ci_cmake-example-test ✔️

jamesbeyond
jamesbeyond approved these changes Dec 11, 2020
View reviewed changes
Copy link
Contributor

@jamesbeyond jamesbeyond left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@adbridge adbridge merged commit 36df9d1 into ARMmbed:master Dec 11, 2020
@mbedmain mbedmain added release-version: 6.6.0 Release-pending and removed release-type: patch Indentifies a PR as containing just a patch Release-pending labels Dec 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jamesbeyond jamesbeyond jamesbeyond approved these changes

@Patater Patater Patater left review comments

@0xc0170 0xc0170 0xc0170 left review comments

@rwalton-arm rwalton-arm Awaiting requested review from rwalton-arm

@urutva urutva Awaiting requested review from urutva

Assignees
No one assigned
Labels
priority: high release-version: 6.6.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@jainvikas8 @ciarmcom @0xc0170 @mbed-ci @jamesbeyond @Patater @adbridge @mbedmain