MCU_NRF52832 (NRF52_DK, SDT52832B): use two-region memory model to support MicroLib #13951
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LDong-Arm
changed the title
ciarmcom
added
the
release-type: patch
|
@LDong-Arm, thank you for your changes. |
|
Manually pinging @ARMmbed/mbed-os-core for review, as the group was not added as reviewers by the system |
0xc0170
previously approved these changes
Nov 24, 2020
|
@0xc0170 I need to edit the PR description and commit message later as they are not accurate, please keep it on hold for a bit, thanks! |
LDong-Arm
changed the title
LDong-Arm
force-pushed
the
NRF52_DK-baremetal
branch
from
88c897e to
3957519
Compare
mergify
bot
dismissed stale reviews from MarceloSalazar and 0xc0170
Pull request has been modified.
LDong-Arm
changed the title
|
CI restarted |
evedon
previously requested changes
Nov 24, 2020
...T_NORDIC/TARGET_NRF5x/TARGET_NRF52/TARGET_MCU_NRF52832/device/TOOLCHAIN_ARM_STD/nRF52832.sct
Outdated
Show resolved
Hide resolved
Jenkins CI Test : ✔️ SUCCESSBuild Number: 2 | 🔒 Jenkins CI Job | 🌐 Logs & ArtifactsCLICK for Detailed Summary
|
…MicroLib MicroLib is the lightweight C lib for the Arm toolchain and used as the default C lib on bare metal builds with the Arm toolchain. It requires two separate memory regions for stack and heap. The change is based on nRF52840.sct.
LDong-Arm
force-pushed
the
NRF52_DK-baremetal
branch
from
3957519 to
b174edb
Compare
evedon
approved these changes
Nov 24, 2020
|
Hopefully it's all good this time! |
|
@0xc0170 This PR is ready for CI (when there's capacity), cheers! |
|
CI started |
Jenkins CI Test : ✔️ SUCCESSBuild Number: 3 | 🔒 Jenkins CI Job | 🌐 Logs & ArtifactsCLICK for Detailed Summary
|
mbedmain
added
release-version: 6.6.0
Release-pending
and removed
release-type: patch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of changes
Fixes: #13857
Arm toolchain's MicroLib, a lightweight C library used in conjunction with the bare metal profile to save code size, requires two separate memory regions for stack and heap. For MCU_NRF52832 (NRF52_DK, SDT52832B) such memory model is already used in the GCC_ARM linker script, and this PR adds it to the Arm Compiler scatter file.
This change is based on nRF52840.sct.Update: The heap size calculation of nRF52840 and many other targets contain a mistake, which will be fixed in a subsequent PR.Impact of changes
MCU_NRF52832 targets (NRF52_DK, SDT52832B) now support MicroLib (i.e.
"target.c_lib": "small"withTOOLCHAIN=ARM).Migration actions required
To use MicroLib on MCU_NRF52832 targets, set
"target.c_lib": "small"inmbed_app.jsonand compile with the ARM toolchain.Documentation
None.
Pull request type
Test results
mbed-os-example-blinky-baremetal compiles and runs on NRF52_DK.
All Greentea tests with the bare metal profile pass:
Both the above use MicroLib when compiled with the Arm Compiler.
Reviewers
@ARMmbed/mbed-os-core @MarceloSalazar