Skip to content

Add SPDX identifier to files in storage #14041

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 18, 2020
Merged

Add SPDX identifier to files in storage #14041

merged 1 commit into from
Dec 18, 2020

Conversation

harmut01
Copy link
Contributor

Summary of changes

SPDX identifiers added to files in Storage.

Impact of changes

None

Migration actions required

None

Documentation

None

Pull request type 

[x] Patch update (Bug fix / Target update / Docs update / Test update / Refactor)
[] Feature update (New feature / Functionality change / New API)
[] Major update (Breaking change E.g. Return code change / API behaviour change)

Test results 

[] No Tests required for this change (E.g docs only update)
[x] Covered by existing mbed-os tests (Greentea or Unittest)
[] Tests / results supplied as part of this PR

Reviewers

@ARMmbed/mbed-os-core

@ciarmcom ciarmcom added the release-type: patch Indentifies a PR as containing just a patch label Dec 14, 2020
@ciarmcom ciarmcom requested review from a team December 14, 2020 11:00
@ciarmcom
Copy link
Member

@harmut01, thank you for your changes.
@ARMmbed/mbed-os-core @ARMmbed/mbed-os-maintainers please review.

@harmut01 harmut01 changed the title Add SPDX identifier Add SPDX identifier to files in storage Dec 14, 2020
0xc0170
0xc0170 previously approved these changes Dec 14, 2020
View reviewed changes
@mergify mergify bot added needs: CI and removed needs: review labels Dec 14, 2020
hugueskamba
hugueskamba previously requested changes Dec 14, 2020
View reviewed changes
Copy link
Collaborator

@hugueskamba hugueskamba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why was MIT used instead of Apache-2.0?
Find information about licenses in Mbed OS here: https://os.mbed.com/docs/mbed-os/v6.5/contributing/license.html

@mergify mergify bot added needs: work and removed needs: CI labels Dec 14, 2020
@0xc0170
Copy link
Contributor

0xc0170 commented Dec 14, 2020

To answer a question about the licenses. We use Apache 2.0 but MIT is permissive as well, fine to be included although our files should be apache by default.
As all these are our files, we could change them to Apache 2.0 but that is not what this PR is about.

@LDong-Arm
Copy link
Contributor

I believe the inconsistency was unintended. For example, https://github.com/ARMmbed/mbed-os/pull/6757/files introduced BufferedBlockDevice.cpp with Apache-2.0 but BufferedBlockDevice.h with the text from the MIT license (without mentioning the name though).

@hugueskamba
Copy link
Collaborator

To answer a question about the licenses. We use Apache 2.0 but MIT is permissive as well, fine to be included although our files should be apache by default.
As all these are our files, we could change them to Apache 2.0 but that is not what this PR is about.

If our own documentation says we should use Apache surely we must use Apache...

@mergify mergify bot dismissed stale reviews from 0xc0170 and hugueskamba December 15, 2020 14:18

Pull request has been modified.

@harmut01
Copy link
Contributor Author

@hugueskamba @0xc0170 @LDong-Arm I've changed the license headers to Apache 2.0 for consistency. I think it is better to address the problem now rather than further down the road (unless there's a reason for having an MIT license).

hugueskamba
hugueskamba reviewed Dec 15, 2020
View reviewed changes
@harmut01 harmut01 requested a review from hugueskamba December 16, 2020 13:37
@mergify mergify bot added the needs: CI label Dec 16, 2020
@mergify mergify bot removed the needs: work label Dec 16, 2020
@0xc0170
Copy link
Contributor

0xc0170 commented Dec 16, 2020

CI started

@mbed-ci
Copy link

mbed-ci commented Dec 16, 2020

Jenkins CI Test : ❌ FAILED

Build Number: 1 | 🔒 Jenkins CI Job | 🌐 Logs & Artifacts

CLICK for Detailed Summary

jobs Status
jenkins-ci/mbed-os-ci_unittests ✔️
jenkins-ci/mbed-os-ci_build-cloud-example-ARM ✔️
jenkins-ci/mbed-os-ci_build-greentea-GCC_ARM ✔️
jenkins-ci/mbed-os-ci_build-cloud-example-GCC_ARM ✔️
jenkins-ci/mbed-os-ci_build-example-ARM ✔️
jenkins-ci/mbed-os-ci_cmake-example-GCC_ARM ✔️
jenkins-ci/mbed-os-ci_cmake-example-ARM ✔️
jenkins-ci/mbed-os-ci_build-greentea-ARM ✔️
jenkins-ci/mbed-os-ci_build-example-GCC_ARM ✔️
jenkins-ci/mbed-os-ci_cmake-example-test ✔️
jenkins-ci/mbed-os-ci_greentea-test ❌

@mergify mergify bot added needs: work and removed needs: CI labels Dec 16, 2020
@0xc0170
Copy link
Contributor

0xc0170 commented Dec 17, 2020

CI restarted

@mbed-ci
Copy link

mbed-ci commented Dec 17, 2020

Jenkins CI Test : ✔️ SUCCESS

Build Number: 2 | 🔒 Jenkins CI Job | 🌐 Logs & Artifacts

CLICK for Detailed Summary

jobs Status
jenkins-ci/mbed-os-ci_unittests ✔️
jenkins-ci/mbed-os-ci_cmake-example-ARM ✔️
jenkins-ci/mbed-os-ci_cmake-example-GCC_ARM ✔️
jenkins-ci/mbed-os-ci_build-greentea-ARM ✔️
jenkins-ci/mbed-os-ci_build-greentea-GCC_ARM ✔️
jenkins-ci/mbed-os-ci_build-example-ARM ✔️
jenkins-ci/mbed-os-ci_build-cloud-example-GCC_ARM ✔️
jenkins-ci/mbed-os-ci_build-example-GCC_ARM ✔️
jenkins-ci/mbed-os-ci_build-cloud-example-ARM ✔️
jenkins-ci/mbed-os-ci_greentea-test ✔️
jenkins-ci/mbed-os-ci_cmake-example-test ✔️

@0xc0170 0xc0170 merged commit 7f538a4 into ARMmbed:master Dec 18, 2020
@mergify mergify bot removed the ready for merge label Dec 18, 2020
@mbedmain mbedmain added release-version: 6.7.0 Release-pending and removed release-type: patch Indentifies a PR as containing just a patch Release-pending labels Jan 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@0xc0170 0xc0170 0xc0170 approved these changes

@hugueskamba hugueskamba hugueskamba approved these changes

Assignees
No one assigned
Labels
release-version: 6.7.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@harmut01 @ciarmcom @0xc0170 @LDong-Arm @hugueskamba @mbed-ci @mbedmain @harrisonmutai-arm