DISCO_L072CZ_LRWAN1: enable LORA by default #14049

jeromecoutant · 2020-12-15T14:06:15Z

Summary of changes

DISCO_L072CZ_LRWAN1 target includes a SX1276 transceiver,
so LoRaWan could be enabled in default configuration

During this development, I changed the way of configuring pins for each Lora radio driver.
Before, it was up to application to configure all the pins for each radio,
now pins are configured in the driver, and application just has to override to needed ones.

Greentea test is also updated

Impact of changes

Migration actions required

Documentation

Pull request type

[x] Patch update (Bug fix / Target update / Docs update / Test update / Refactor)
[] Feature update (New feature / Functionality change / New API)
[] Major update (Breaking change E.g. Return code change / API behaviour change)

Test results

target	platform_name	test suite	test case	passed	result	elapsed_time (sec)
DISCO_L072CZ_LRWAN1-GCC_ARM	DISCO_L072CZ_LRWAN1	connectivity-lorawan-tests-tests-lorawan-loraradio	Test check_rf_frequency	1	OK	0.05
DISCO_L072CZ_LRWAN1-GCC_ARM	DISCO_L072CZ_LRWAN1	connectivity-lorawan-tests-tests-lorawan-loraradio	Test perform_carrier_sense	1	OK	0.06
DISCO_L072CZ_LRWAN1-GCC_ARM	DISCO_L072CZ_LRWAN1	connectivity-lorawan-tests-tests-lorawan-loraradio	Test random	1	OK	0.1
DISCO_L072CZ_LRWAN1-GCC_ARM	DISCO_L072CZ_LRWAN1	connectivity-lorawan-tests-tests-lorawan-loraradio	Test set_rx_config	1	OK	0.08
DISCO_L072CZ_LRWAN1-GCC_ARM	DISCO_L072CZ_LRWAN1	connectivity-lorawan-tests-tests-lorawan-loraradio	Test set_tx_config	1	OK	0.09
DISCO_L072CZ_LRWAN1-GCC_ARM	DISCO_L072CZ_LRWAN1	connectivity-lorawan-tests-tests-lorawan-loraradio	Test time_on_air	1	OK	0.05

[] No Tests required for this change (E.g docs only update)
[x] Covered by existing mbed-os tests (Greentea or Unittest)
[] Tests / results supplied as part of this PR

Reviewers

jeromecoutant · 2020-12-15T14:10:37Z

FYI @ludoch-stm

ciarmcom · 2020-12-15T14:30:26Z

@jeromecoutant, thank you for your changes.
@ARMmbed/mbed-os-connectivity @ARMmbed/mbed-os-maintainers please review.

pan-

Thanks @jeromecoutant. It is a peculiar way of overriding the lora.radio parameter. Is there any side effect when the user attempt to override this value and one of the driver provides a value for MBED_CONF_LORA_RADIO ?

pan- · 2020-12-15T15:09:14Z

connectivity/drivers/lora/COMPONENT_SX126X/mbed_lib.json

@@ -1,6 +1,10 @@
 {
    "name": "SX126X-lora-driver",
    "config": {
+        "radio": {


If I understand this correctly this provides the override of "lora.radio"

yes, I don't find any clean way to override some config value defined in another lib....

That's a longstanding issue 😞 .

pan- · 2020-12-15T15:10:21Z

connectivity/lorawan/mbed_lib.json

@@ -5,6 +5,9 @@
            "help": "LoRa PHY region: EU868, AS923, AU915, CN470, CN779, EU433, IN865, KR920, US915",
            "value": "EU868"
        },
+        "radio": {
+            "help": "value set in radio driver : SX126X, SX1272, SX1276"


What happen if a value is provided in mbed_app.json ?

It will not be used as define will be MBED_CONF_APP_xxx

jeromecoutant · 2020-12-21T15:49:19Z

Could we start CI ?

0xc0170 · 2021-01-05T15:52:58Z

connectivity/drivers/lora/COMPONENT_SX126X/mbed_lib.json

@@ -24,6 +28,17 @@
        "standby-mode": {
        	"help": "Default: STDBY_RC = 0, STDBY_XOSC = 1",
        	"value": 0
-        }
+        },
+        "spi-mosi":       { "value": "NC" },


should this follow the style: value on separate line with NC ? same as the rest above to be consistent (I understand it's not much value but consistency is better.

adbridge · 2021-01-07T15:55:56Z

@0xc0170 could you re-review please,I'll start CI in the meantime

mbed-ci · 2021-01-07T18:35:54Z

Jenkins CI Test : ✔️ SUCCESS

Build Number: 1 | 🔒 Jenkins CI Job | 🌐 Logs & Artifacts

CLICK for Detailed Summary

jobs	Status
jenkins-ci/mbed-os-ci_unittests	✔️
jenkins-ci/mbed-os-ci_cmake-example-GCC_ARM	✔️
jenkins-ci/mbed-os-ci_cmake-example-ARM	✔️
jenkins-ci/mbed-os-ci_build-greentea-ARM	✔️
jenkins-ci/mbed-os-ci_build-greentea-GCC_ARM	✔️
jenkins-ci/mbed-os-ci_build-cloud-example-ARM	✔️
jenkins-ci/mbed-os-ci_build-cloud-example-GCC_ARM	✔️
jenkins-ci/mbed-os-ci_build-example-ARM	✔️
jenkins-ci/mbed-os-ci_build-example-GCC_ARM	✔️
jenkins-ci/mbed-os-ci_cmake-example-test	✔️
jenkins-ci/mbed-os-ci_greentea-test	✔️

0xc0170 · 2021-01-12T10:11:08Z

connectivity/drivers/lora/COMPONENT_SX1272/mbed_lib.json

+        "dio5":     {
+            "value": "NC"
+        },
+        "rf-switch-ctl1": { "value": "NC" },


same style for the rest also (line here and lines below)

0xc0170 · 2021-01-12T10:11:22Z

connectivity/drivers/lora/COMPONENT_SX1276/mbed_lib.json

+        "dio5":     {
+            "value": "NC"
+        },
+        "rf-switch-ctl1": { "value": "NC" },


also update here needed

0xc0170 · 2021-01-12T10:11:44Z

@jeromecoutant please update the rest of the changes, LGTM once updated

jeromecoutant · 2021-01-12T10:46:31Z

@jeromecoutant please update the rest of the changes, LGTM once updated

Done

0xc0170

@pan- happy with the changes?

mbed-ci · 2021-01-12T15:51:31Z

Jenkins CI Test : ✔️ SUCCESS

Build Number: 2 | 🔒 Jenkins CI Job | 🌐 Logs & Artifacts

CLICK for Detailed Summary

jobs	Status
jenkins-ci/mbed-os-ci_unittests	✔️
jenkins-ci/mbed-os-ci_cmake-example-ARM	✔️
jenkins-ci/mbed-os-ci_cmake-example-GCC_ARM	✔️
jenkins-ci/mbed-os-ci_build-greentea-ARM	✔️
jenkins-ci/mbed-os-ci_build-greentea-GCC_ARM	✔️
jenkins-ci/mbed-os-ci_build-example-ARM	✔️
jenkins-ci/mbed-os-ci_build-cloud-example-ARM	✔️
jenkins-ci/mbed-os-ci_build-cloud-example-GCC_ARM	✔️
jenkins-ci/mbed-os-ci_build-example-GCC_ARM	✔️
jenkins-ci/mbed-os-ci_greentea-test	✔️
jenkins-ci/mbed-os-ci_cmake-example-test	✔️

mergify bot added the needs: work label Dec 15, 2020

ciarmcom added the release-type: patch Indentifies a PR as containing just a patch label Dec 15, 2020

ciarmcom requested review from a team December 15, 2020 14:30

ciarmcom added the needs: review label Dec 15, 2020

jeromecoutant mentioned this pull request Dec 15, 2020

Pins configured at driver level ARMmbed/mbed-os-example-lorawan#206

Merged

jeromecoutant force-pushed the PR_L072_LORA branch from 76a1cd6 to f693871 Compare December 15, 2020 14:35

pan- reviewed Dec 15, 2020

View reviewed changes

hugueskamba requested a review from pan- December 31, 2020 12:18

0xc0170 reviewed Jan 5, 2021

View reviewed changes

jeromecoutant force-pushed the PR_L072_LORA branch from f693871 to f17ce83 Compare January 7, 2021 14:43

adbridge removed the needs: work label Jan 7, 2021

0xc0170 reviewed Jan 12, 2021

View reviewed changes

jeromecoutant added 3 commits January 12, 2021 11:42

LORA-DRIVER: add pins in json configuration

80aa710

LORA: update test

c3664d2

DISCO_L072CZ_LRWAN1: enable LORAWAN by default

e0217ad

jeromecoutant force-pushed the PR_L072_LORA branch from f17ce83 to e0217ad Compare January 12, 2021 10:42

0xc0170 approved these changes Jan 12, 2021

View reviewed changes

mergify bot added needs: CI and removed needs: review labels Jan 12, 2021

mergify bot added the ready for merge label Jan 12, 2021

mergify bot removed the needs: CI label Jan 12, 2021

0xc0170 merged commit 82f3126 into ARMmbed:master Jan 14, 2021

mergify bot removed the ready for merge label Jan 14, 2021

jeromecoutant deleted the PR_L072_LORA branch January 15, 2021 08:37

mbedmain added release-version: 6.7.0 Release-pending and removed release-type: patch Indentifies a PR as containing just a patch Release-pending labels Jan 25, 2021

DISCO_L072CZ_LRWAN1: enable LORA by default #14049

DISCO_L072CZ_LRWAN1: enable LORA by default #14049

Uh oh!

Conversation

jeromecoutant commented Dec 15, 2020

Summary of changes

Impact of changes

Migration actions required

Documentation

Pull request type

Test results

Reviewers

Uh oh!

jeromecoutant commented Dec 15, 2020

Uh oh!

ciarmcom commented Dec 15, 2020

Uh oh!

pan- left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

jeromecoutant commented Dec 21, 2020

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

adbridge commented Jan 7, 2021

Uh oh!

mbed-ci commented Jan 7, 2021

Jenkins CI Test : ✔️ SUCCESS

Build Number: 1 | 🔒 Jenkins CI Job | 🌐 Logs & Artifacts

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

0xc0170 commented Jan 12, 2021

Uh oh!

jeromecoutant commented Jan 12, 2021

Uh oh!

0xc0170 left a comment

Choose a reason for hiding this comment

Uh oh!

mbed-ci commented Jan 12, 2021

Jenkins CI Test : ✔️ SUCCESS

Build Number: 2 | 🔒 Jenkins CI Job | 🌐 Logs & Artifacts

Uh oh!

Uh oh!