Skip to content

CMake: Add CMake to drivers greentea test #14060

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 11, 2021

Conversation

rajkan01
Copy link
Contributor

@rajkan01 rajkan01 commented Dec 16, 2020

Summary of changes

  • Added CMakeLists.txt file to every test suite under the mbed_drivers so that it can build via CMake command

Impact of changes

None.

Migration actions required

Note

Documentation

None.


Pull request type

[] Patch update (Bug fix / Target update / Docs update / Test update / Refactor)
[x] Feature update (New feature / Functionality change / New API)
[] Major update (Breaking change E.g. Return code change / API behaviour change)

Test results

[] No Tests required for this change (E.g docs only update)
[] Covered by existing mbed-os tests (Greentea or Unittest)
[] Tests / results supplied as part of this PR

Manual testing:
Successfully able to build the test suite with below manual steps

  • Manual steps:
    -- Generated .mbed_build config for DISCO target from blinky example and copied into the echo test directory.
    -- Manually created test_spec.json, which is required by mbetgt to flash and initiate the test.
    -- Reused host_tests python scripts
    -- Manually created runtests.cmake where it calls mbedgt command via execute_process()
  • Run the test:
    -- CTest -S runtests.cmake

Reviewers

@hugueskamba @0xc0170


@rajkan01 rajkan01 force-pushed the add_cmake_greentea_drivers branch from 4407a76 to d47be75 Compare December 16, 2020 19:51
@ciarmcom ciarmcom requested review from 0xc0170, hugueskamba and a team December 16, 2020 20:00
@ciarmcom
Copy link
Member

@rajkan01, thank you for your changes.
@hugueskamba @0xc0170 @ARMmbed/mbed-os-hal @ARMmbed/mbed-os-core @ARMmbed/mbed-os-maintainers please review.

@0xc0170 0xc0170 changed the title Add CMake support CMake: Add test support Dec 17, 2020
@rajkan01 rajkan01 changed the title CMake: Add test support CMake: Add CMake to drivers greentea test Dec 21, 2020
Copy link
Collaborator

@hugueskamba hugueskamba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same comment as in #14072 (review)

@rajkan01 rajkan01 force-pushed the add_cmake_greentea_drivers branch from d47be75 to 85fbcf0 Compare December 23, 2020 12:39
@rajkan01 rajkan01 requested a review from hugueskamba December 23, 2020 12:42
hugueskamba
hugueskamba previously approved these changes Dec 23, 2020
@rajkan01 rajkan01 force-pushed the add_cmake_greentea_drivers branch from 85fbcf0 to bbd921d Compare January 5, 2021 14:56
@mergify mergify bot dismissed hugueskamba’s stale review January 5, 2021 14:56

Pull request has been modified.

@rajkan01 rajkan01 force-pushed the add_cmake_greentea_drivers branch from bbd921d to 20fb74f Compare January 5, 2021 17:10
@rajkan01
Copy link
Contributor Author

rajkan01 commented Jan 5, 2021

@0xc0170 @adbridge This PR is ready for CI, please start the CI

@adbridge
Copy link
Contributor

adbridge commented Jan 6, 2021

@hugueskamba can you please re-review and make sure you are happy with the changes?

@adbridge
Copy link
Contributor

adbridge commented Jan 6, 2021

CI started

@rajkan01 rajkan01 requested a review from hugueskamba January 6, 2021 14:51
@mbed-ci
Copy link

mbed-ci commented Jan 6, 2021

Jenkins CI Test : ✔️ SUCCESS

Build Number: 1 | 🔒 Jenkins CI Job | 🌐 Logs & Artifacts

CLICK for Detailed Summary

jobs Status
jenkins-ci/mbed-os-ci_unittests ✔️
jenkins-ci/mbed-os-ci_cmake-example-ARM ✔️
jenkins-ci/mbed-os-ci_cmake-example-GCC_ARM ✔️
jenkins-ci/mbed-os-ci_build-greentea-GCC_ARM ✔️
jenkins-ci/mbed-os-ci_build-greentea-ARM ✔️
jenkins-ci/mbed-os-ci_build-cloud-example-ARM ✔️
jenkins-ci/mbed-os-ci_build-cloud-example-GCC_ARM ✔️
jenkins-ci/mbed-os-ci_build-example-ARM ✔️
jenkins-ci/mbed-os-ci_build-example-GCC_ARM ✔️
jenkins-ci/mbed-os-ci_cmake-example-test ✔️
jenkins-ci/mbed-os-ci_greentea-test ✔️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants