Skip to content

CMake: Add support for netsocket/network Greentea tests #14103

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 12, 2021
Merged

CMake: Add support for netsocket/network Greentea tests #14103

merged 1 commit into from
Jan 12, 2021

Conversation

hugueskamba
Copy link
Collaborator

Summary of changes

The netsocket/network Greentea tests can now be built with CMake.

Preceding PR #14072

Impact of changes

Migration actions required

Documentation

Pull request type 

[x] Patch update (Bug fix / Target update / Docs update / Test update / Refactor)
[] Feature update (New feature / Functionality change / New API)
[] Major update (Breaking change E.g. Return code change / API behaviour change)

Test results 

[] No Tests required for this change (E.g docs only update)
[x] Covered by existing mbed-os tests (Greentea or Unittest)
[] Tests / results supplied as part of this PR

Reviewers

@mergify mergify bot added the needs: work label Dec 29, 2020
rajkan01
rajkan01 approved these changes Dec 30, 2020
View reviewed changes
Copy link
Contributor

@rajkan01 rajkan01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

0xc0170
0xc0170 previously approved these changes Jan 5, 2021
View reviewed changes
@0xc0170
Copy link
Contributor

0xc0170 commented Jan 11, 2021

This needs a rebase now

@hugueskamba
CMake: Add support for netsocket/network Greentea tests
088ce19 
The netsocket/network Greentea tests can now be built with CMake
@hugueskamba hugueskamba force-pushed the hk_cmake_greentea_netsocket_network branch from d30ac7a to 088ce19 Compare January 11, 2021 16:34
@hugueskamba
Copy link
Collaborator Author

This needs a rebase now

Done.

@mergify mergify bot dismissed 0xc0170’s stale review January 11, 2021 16:35

Pull request has been modified.

@0xc0170
Copy link
Contributor

0xc0170 commented Jan 12, 2021

CI started

@mbed-ci
Copy link

mbed-ci commented Jan 12, 2021

Jenkins CI Test : ✔️ SUCCESS

Build Number: 1 | 🔒 Jenkins CI Job | 🌐 Logs & Artifacts

CLICK for Detailed Summary

jobs Status
jenkins-ci/mbed-os-ci_unittests ✔️
jenkins-ci/mbed-os-ci_cmake-example-ARM ✔️
jenkins-ci/mbed-os-ci_cmake-example-GCC_ARM ✔️
jenkins-ci/mbed-os-ci_build-greentea-GCC_ARM ✔️
jenkins-ci/mbed-os-ci_build-greentea-ARM ✔️
jenkins-ci/mbed-os-ci_build-example-GCC_ARM ✔️
jenkins-ci/mbed-os-ci_build-example-ARM ✔️
jenkins-ci/mbed-os-ci_build-cloud-example-ARM ✔️
jenkins-ci/mbed-os-ci_build-cloud-example-GCC_ARM ✔️
jenkins-ci/mbed-os-ci_cmake-example-test ✔️
jenkins-ci/mbed-os-ci_greentea-test ✔️

@0xc0170 0xc0170 merged commit 265aa4c into ARMmbed:master Jan 12, 2021
@mergify mergify bot added release version missing When PR does not contain release version, bot should label it and we fix it afterwards and removed ready for merge labels Jan 12, 2021
@mergify
Copy link

mergify bot commented Jan 12, 2021

This PR does not contain release version label after merging.

@0xc0170 0xc0170 added release-type: patch Indentifies a PR as containing just a patch and removed release version missing When PR does not contain release version, bot should label it and we fix it afterwards labels Jan 12, 2021
@hugueskamba hugueskamba deleted the hk_cmake_greentea_netsocket_network branch January 12, 2021 10:54
@mbedmain mbedmain removed release-type: patch Indentifies a PR as containing just a patch Release-pending labels Jan 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@0xc0170 0xc0170 0xc0170 approved these changes

@rajkan01 rajkan01 rajkan01 approved these changes

@pan- pan- Awaiting requested review from pan-

@paul-szczepanek-arm paul-szczepanek-arm Awaiting requested review from paul-szczepanek-arm

Assignees
No one assigned
Labels
release-version: 6.7.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@hugueskamba @0xc0170 @mbed-ci @rajkan01 @mbedmain