Skip to content

STM32F439 : correct cmake compilation #14120

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 12, 2021
Merged

STM32F439 : correct cmake compilation #14120

merged 1 commit into from
Jan 12, 2021

Conversation

jeromecoutant
Copy link
Collaborator

@jeromecoutant jeromecoutant commented Jan 6, 2021 •
edited
Loading

Summary of changes

NUCLEO_F439ZI can't compile with mbedtools.

Correction takes #14104 as example

@hugueskamba

Impact of changes

Migration actions required

Documentation

Pull request type 

[x] Patch update (Bug fix / Target update / Docs update / Test update / Refactor)
[] Feature update (New feature / Functionality change / New API)
[] Major update (Breaking change E.g. Return code change / API behaviour change)

Test results 

[] No Tests required for this change (E.g docs only update)
[x] Covered by existing mbed-os tests (Greentea or Unittest)
[] Tests / results supplied as part of this PR

Reviewers

@ciarmcom ciarmcom added the release-type: patch Indentifies a PR as containing just a patch label Jan 6, 2021
@ciarmcom ciarmcom requested review from a team January 6, 2021 13:00
@ciarmcom
Copy link
Member

ciarmcom commented Jan 6, 2021

@jeromecoutant, thank you for your changes.
@ARMmbed/team-st-mcd @ARMmbed/mbed-os-connectivity @ARMmbed/mbed-os-maintainers please review.

@adbridge
Copy link
Contributor

adbridge commented Jan 7, 2021

@0xc0170 @hugueskamba please review

hugueskamba
hugueskamba reviewed Jan 8, 2021
View reviewed changes
targets/TARGET_STM/TARGET_STM32F4/TARGET_STM32F439xI/TARGET_WIO_3G/CMakeLists.txt Outdated
@@ -4,8 +4,6 @@
target_sources(mbed-core
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As there is not much in this file, we might as well delete this file and move the content to the file including it.

targets/TARGET_STM/TARGET_STM32F4/TARGET_STM32F439xI/TARGET_WIO_BG96/CMakeLists.txt Outdated
@@ -4,8 +4,6 @@
target_sources(mbed-core
INTERFACE
ONBOARD_QUECTEL_BG96.cpp
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As there is not much in this file, we might as well delete this file and move the content to the file including it.

0xc0170
0xc0170 reviewed Jan 11, 2021
View reviewed changes
Copy link
Contributor

@0xc0170 0xc0170 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would make sense to remove targets/TARGET_STM/TARGET_STM32F4/TARGET_STM32F439xI/TARGET_WIO_BG96/CMakeLists.txt and move what is there (as the rest of it was already moved in this PR).

@0xc0170
Copy link
Contributor

0xc0170 commented Jan 11, 2021

@jeromecoutant Can you update ?

@jeromecoutant
Copy link
Collaborator Author

@jeromecoutant Can you update ?

Done

@0xc0170
Copy link
Contributor

0xc0170 commented Jan 11, 2021

CI started

@mergify mergify bot added needs: CI and removed needs: review labels Jan 11, 2021
@mbed-ci
Copy link

mbed-ci commented Jan 11, 2021

Jenkins CI Test : ✔️ SUCCESS

Build Number: 1 | 🔒 Jenkins CI Job | 🌐 Logs & Artifacts

CLICK for Detailed Summary

jobs Status
jenkins-ci/mbed-os-ci_unittests ✔️
jenkins-ci/mbed-os-ci_cmake-example-ARM ✔️
jenkins-ci/mbed-os-ci_cmake-example-GCC_ARM ✔️
jenkins-ci/mbed-os-ci_build-greentea-ARM ✔️
jenkins-ci/mbed-os-ci_build-greentea-GCC_ARM ✔️
jenkins-ci/mbed-os-ci_build-example-GCC_ARM ✔️
jenkins-ci/mbed-os-ci_build-cloud-example-ARM ✔️
jenkins-ci/mbed-os-ci_build-example-ARM ✔️
jenkins-ci/mbed-os-ci_build-cloud-example-GCC_ARM ✔️
jenkins-ci/mbed-os-ci_greentea-test ✔️
jenkins-ci/mbed-os-ci_cmake-example-test ✔️

@0xc0170 0xc0170 merged commit 74ac9b9 into ARMmbed:master Jan 12, 2021
@mergify mergify bot removed the ready for merge label Jan 12, 2021
@jeromecoutant jeromecoutant deleted the DEV_CMAKE_F4 branch January 12, 2021 09:21
@mbedmain mbedmain added release-version: 6.7.0 Release-pending and removed release-type: patch Indentifies a PR as containing just a patch Release-pending labels Jan 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hugueskamba hugueskamba hugueskamba left review comments

@0xc0170 0xc0170 0xc0170 approved these changes

Assignees
No one assigned
Labels
release-version: 6.7.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@jeromecoutant @ciarmcom @adbridge @0xc0170 @mbed-ci @hugueskamba @mbedmain