Skip to content

Remove systematic 'legacyalign' warning #14151

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from

Conversation

jeromecoutant
Copy link
Collaborator

Summary of changes

With ARMC6 we got a systematic warning in logs:

[Warning] @0,0: L3912W: Option 'legacyalign' is deprecated.

Impact of changes

Migration actions required

Documentation


Pull request type

[x] Patch update (Bug fix / Target update / Docs update / Test update / Refactor)
[] Feature update (New feature / Functionality change / New API)
[] Major update (Breaking change E.g. Return code change / API behaviour change)

Test results

[] No Tests required for this change (E.g docs only update)
[x] Covered by existing mbed-os tests (Greentea or Unittest)
[] Tests / results supplied as part of this PR

Reviewers


@ciarmcom ciarmcom added the release-type: patch Indentifies a PR as containing just a patch label Jan 14, 2021
@ciarmcom ciarmcom requested review from a team January 14, 2021 10:00
@ciarmcom
Copy link
Member

@jeromecoutant, thank you for your changes.
@ARMmbed/mbed-os-tools @ARMmbed/mbed-os-maintainers please review.

@kjbracey
Copy link
Contributor

Good luck. Last time I attempted this I appeared to trigger a linker/library bug on some platforms: #10373

@0xc0170
Copy link
Contributor

0xc0170 commented Jan 15, 2021

This one still in there. I'll start CI to get early results.
We might be able to help fixing some linkers but it might be more difficult if libraries in the tree are affected, Let's see

@0xc0170
Copy link
Contributor

0xc0170 commented Jan 15, 2021

CI started

@mbed-ci
Copy link

mbed-ci commented Jan 15, 2021

Jenkins CI Test : ❌ FAILED

Build Number: 1 | 🔒 Jenkins CI Job | 🌐 Logs & Artifacts

CLICK for Detailed Summary

jobs Status
jenkins-ci/mbed-os-ci_unittests ✔️
jenkins-ci/mbed-os-ci_build-greentea-ARM
jenkins-ci/mbed-os-ci_build-greentea-GCC_ARM ✔️
jenkins-ci/mbed-os-ci_cmake-example-GCC_ARM ✔️
jenkins-ci/mbed-os-ci_build-example-ARM
jenkins-ci/mbed-os-ci_cmake-example-ARM ✔️
jenkins-ci/mbed-os-ci_build-cloud-example-ARM ✔️
jenkins-ci/mbed-os-ci_build-cloud-example-GCC_ARM ✔️
jenkins-ci/mbed-os-ci_build-example-GCC_ARM

@jeromecoutant
Copy link
Collaborator Author

As there are some errors, seems that 'legacyalign' is not so deprecated...
Do you have some contact with ARM compiler team ?

@0xc0170
Copy link
Contributor

0xc0170 commented Jan 15, 2021

We are hitting the same problem as before:

[ERROR] Error: L6244E: Exec region RW_IRAM1 address (0x20000108) not aligned on a 512 byte boundary.
Finished: 0 information, 0 warning and 1 error messages.

@kjbracey-arm the only way forward is to update all linker scripts affected or not? I do not recall any issue with prebuild libraries - is there any?

@ciarmcom ciarmcom added the stale Stale Pull Request label Jan 26, 2021
@ciarmcom
Copy link
Member

This pull request has automatically been marked as stale because it has had no recent activity. @jeromecoutant, please carry out any necessary work to get the changes merged. Thank you for your contributions.

@jeromecoutant
Copy link
Collaborator Author

@0xc0170
What is the plan ? We keep the warning, and I close the ticket ?

@0xc0170
Copy link
Contributor

0xc0170 commented Feb 4, 2021

Is there a tracking issue? If not, lets create one and track this. the warning should be fixed.

@0xc0170
Copy link
Contributor

0xc0170 commented Apr 7, 2021

Closing this as 14290 was created

@0xc0170 0xc0170 closed this Apr 7, 2021
@mergify mergify bot removed needs: work release-type: patch Indentifies a PR as containing just a patch stale Stale Pull Request labels Apr 7, 2021
@jeromecoutant jeromecoutant deleted the PR_LEGACYALIGN branch April 7, 2021 09:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants