Skip to content

NXP: Fix CMake support and clean up #14186

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jan 25, 2021
Merged

NXP: Fix CMake support and clean up #14186

merged 2 commits into from
Jan 25, 2021

Conversation

hugueskamba
Copy link
Collaborator

@hugueskamba hugueskamba commented Jan 22, 2021 •
edited by 0xc0170
Loading

Summary of changes

The armclang shebang is required in the scatter files in order to build with CMake.
Support for LPC55S69 had been removed without removing references in CMake.

Impact of changes

Migration actions required

Documentation

Pull request type 

[x] Patch update (Bug fix / Target update / Docs update / Test update / Refactor)
[] Feature update (New feature / Functionality change / New API)
[] Major update (Breaking change E.g. Return code change / API behaviour change)

Test results 

[x] No Tests required for this change (E.g docs only update)
[] Covered by existing mbed-os tests (Greentea or Unittest)
[] Tests / results supplied as part of this PR

Reviewers

@hugueskamba
NXP: Use armclang shebang in scatter files
425b9a7 
The armclang shebang is required in the scatter file in order to build with CMake.
@hugueskamba
NXP: Remove LPC55S69 CMake listing
dd6c5b3 
Support for LPC55S69 had been removed without removing references in CMake.
@hugueskamba hugueskamba requested review from 0xc0170, rajkan01 and a team January 22, 2021 11:16
@ciarmcom ciarmcom requested a review from a team January 22, 2021 11:30
@ciarmcom
Copy link
Member

@hugueskamba, thank you for your changes.
@ARMmbed/team-nxp @ARMmbed/mbed-os-maintainers please review.

rajkan01
rajkan01 approved these changes Jan 22, 2021
View reviewed changes
Copy link
Contributor

@rajkan01 rajkan01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@0xc0170 0xc0170 added the release-type: patch Indentifies a PR as containing just a patch label Jan 22, 2021
@mergify mergify bot added needs: CI and removed needs: review labels Jan 22, 2021
@mbed-ci
Copy link

mbed-ci commented Jan 22, 2021

Jenkins CI Test : ✔️ SUCCESS

Build Number: 1 | 🔒 Jenkins CI Job | 🌐 Logs & Artifacts

CLICK for Detailed Summary

jobs Status
jenkins-ci/mbed-os-ci_unittests ✔️
jenkins-ci/mbed-os-ci_cmake-example-GCC_ARM ✔️
jenkins-ci/mbed-os-ci_cmake-example-ARM ✔️
jenkins-ci/mbed-os-ci_build-greentea-ARM ✔️
jenkins-ci/mbed-os-ci_build-greentea-GCC_ARM ✔️
jenkins-ci/mbed-os-ci_build-example-GCC_ARM ✔️
jenkins-ci/mbed-os-ci_build-example-ARM ✔️
jenkins-ci/mbed-os-ci_build-cloud-example-ARM ✔️
jenkins-ci/mbed-os-ci_build-cloud-example-GCC_ARM ✔️
jenkins-ci/mbed-os-ci_cmake-example-test ✔️
jenkins-ci/mbed-os-ci_greentea-test ✔️

@0xc0170 0xc0170 merged commit 4d1d987 into ARMmbed:master Jan 25, 2021
@mergify mergify bot removed the ready for merge label Jan 25, 2021
@hugueskamba hugueskamba deleted the hk_cmake_nxp_cleanup branch January 25, 2021 09:38
@mbedmain mbedmain added release-version: 6.7.0 Release-pending and removed release-type: patch Indentifies a PR as containing just a patch Release-pending labels Jan 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@0xc0170 0xc0170 0xc0170 approved these changes

@rajkan01 rajkan01 rajkan01 approved these changes

Assignees
No one assigned
Labels
release-version: 6.7.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@hugueskamba @ciarmcom @mbed-ci @0xc0170 @rajkan01 @mbedmain