Skip to content

Update maximum version of intelhex to 2.3.0 #14201

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 2, 2021

Conversation

ladislas
Copy link
Contributor

@ladislas ladislas commented Jan 27, 2021

Summary of changes

Update minimum version of intelhex to 2.3.0.

Impact of changes

On macOS with Python 3.9.1, using intelhex in a script results in the following error:

  File "/Users/ladislas/Library/Python/3.9/lib/python/site-packages/intelhex/__init__.py", line 44, in <module>
    from intelhex.compat import (
  File "/Users/ladislas/Library/Python/3.9/lib/python/site-packages/intelhex/compat.py", line 60, in <module>
    array_tobytes = getattr(array.array, "tobytes", array.array.tostring)
AttributeError: type object 'array.array' has no attribute 'tostring'

The issue is well known, see:

python-intelhex/intelhex#45

With 2.3.0, the issue is fixed.

Migration actions required

none

Documentation

n/a


Pull request type

[x] Patch update (Bug fix / Target update / Docs update / Test update / Refactor)
[] Feature update (New feature / Functionality change / New API)
[] Major update (Breaking change E.g. Return code change / API behaviour change)

Test results

[x] No Tests required for this change (E.g docs only update)
[] Covered by existing mbed-os tests (Greentea or Unittest)
[] Tests / results supplied as part of this PR

Reviewers

@0xc0170 @rwalton-arm @Patater (might be related to ARMmbed/mbed-tools#171)


@rwalton-arm
Copy link
Contributor

Can we remove the maximum version? I'd rather keep it "unpinned" so we don't have to update it again at some point in the future.

@ladislas
Copy link
Contributor Author

I'm happy to do that! Should I also remove the minimum version or should I put 2.3.0?

@ladislas ladislas force-pushed the ladislas-update-python-intelhex branch from 7d568d1 to 881fc18 Compare January 27, 2021 16:27
@ciarmcom ciarmcom added the release-type: patch Indentifies a PR as containing just a patch label Jan 27, 2021
@ciarmcom ciarmcom requested review from 0xc0170, Patater, rwalton-arm and a team January 27, 2021 16:30
@ciarmcom
Copy link
Member

@ladislas, thank you for your changes.
@0xc0170 @Patater @rwalton-arm @ARMmbed/mbed-os-maintainers please review.

@ladislas ladislas force-pushed the ladislas-update-python-intelhex branch from 881fc18 to 34c49de Compare January 27, 2021 17:01
@ladislas ladislas force-pushed the ladislas-update-python-intelhex branch from 34c49de to 7983d81 Compare January 27, 2021 17:02
@mergify mergify bot added needs: CI and removed needs: review labels Jan 28, 2021
@ciarmcom ciarmcom added the stale Stale Pull Request label Jan 30, 2021
@ciarmcom
Copy link
Member

This pull request has automatically been marked as stale because it has had no recent activity. @ARMmbed/mbed-os-maintainers, please start CI to get the PR merged.

multiplemonomials added a commit to mbed-ce/mbed-os that referenced this pull request Feb 2, 2021
@0xc0170
Copy link
Contributor

0xc0170 commented Feb 2, 2021

CI started

@mbed-ci
Copy link

mbed-ci commented Feb 2, 2021

Jenkins CI Test : ✔️ SUCCESS

Build Number: 1 | 🔒 Jenkins CI Job | 🌐 Logs & Artifacts

CLICK for Detailed Summary

jobs Status
jenkins-ci/mbed-os-ci_unittests ✔️
jenkins-ci/mbed-os-ci_cmake-example-ARM ✔️
jenkins-ci/mbed-os-ci_build-greentea-ARM ✔️
jenkins-ci/mbed-os-ci_build-greentea-GCC_ARM ✔️
jenkins-ci/mbed-os-ci_cmake-example-GCC_ARM ✔️
jenkins-ci/mbed-os-ci_build-cloud-example-GCC_ARM ✔️
jenkins-ci/mbed-os-ci_build-example-ARM ✔️
jenkins-ci/mbed-os-ci_build-example-GCC_ARM ✔️
jenkins-ci/mbed-os-ci_build-cloud-example-ARM ✔️
jenkins-ci/mbed-os-ci_greentea-test ✔️
jenkins-ci/mbed-os-ci_cmake-example-test ✔️

@0xc0170 0xc0170 merged commit ba6f566 into ARMmbed:master Feb 2, 2021
@mergify mergify bot removed the ready for merge label Feb 2, 2021
multiplemonomials added a commit to mbed-ce/mbed-os that referenced this pull request Feb 3, 2021
@mbedmain mbedmain removed release-type: patch Indentifies a PR as containing just a patch Release-pending labels Feb 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants