Apollo3: Fix run time error due to memory mapping #14277
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The Appollo3 targets require dummy sections in stack and heap regions. The stack dummy section does not contain any symbols. It is only used for the linker to calculate the size of the stack sections and assign values to stack symbols later. The heap dummy region is used to identify the beginning of available dynamic memory.
hugueskamba
requested review from
MarceloSalazar,
0xc0170,
LDong-Arm and
a team
ciarmcom
added
the
release-type: patch
|
@hugueskamba, thank you for your changes. |
|
@idea--list please review |
|
@0xc0170 and @hugueskamba Compiled the official blinky and 2-3 other code with this change and code runs again on the board as expected. |
LDong-Arm
reviewed
Feb 12, 2021
Comment on lines
+43
to
+47
| ; This section does not contain any symbols. It is only used for the linker | ||
| ; to calculate the size of the stack sections and assign values to stack | ||
| ; symbols later | ||
| #define STACK_DUMMY_START (MBED_RAM1_START + MBED_RAM1_SIZE) | ||
| #define STACK_DUMMY_SIZE 0x8 |
There was a problem hiding this comment.
We got the info from the GCC linker script - the ranges of the stack and the heap are both shifted down by 8 bytes:
Dummy sections exist in many GCC linker scripts but most of them do not shift any bytes. I wonder if the 8 bytes are used for something in particular on this target? Thanks in advance. @ARMmbed/team-sparkfun
|
CI started |
|
@idea--list this will get into the upcoming release |
0xc0170
approved these changes
Feb 12, 2021
Jenkins CI Test : ✔️ SUCCESSBuild Number: 1 | 🔒 Jenkins CI Job | 🌐 Logs & ArtifactsCLICK for Detailed Summary
|
mbedmain
added
release-version: 6.8.0
Release-pending
and removed
release-type: patch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of changes
Fixes ##14273
The Apollo3 targets require dummy sections in stack and heap regions.
The stack dummy section does not contain any symbols. It is only used
for the linker to calculate the size of the stack sections and assign
values to stack symbols later.
The heap dummy region is used to identify the beginning of available dynamic memory.
Impact of changes
Migration actions required
Documentation
Pull request type
Test results
Reviewers