Add bare metal support to Renesas targets #14301

harmut01 · 2021-02-18T10:31:01Z

Summary of changes

Modify RZ_A1XX and RZ_A2XX target configurations to include
bare metal as a supported profile,and add list of supported standard libraries.
Changes affect the following targets: RZ_A1H, GR_LYCHEE, GR_MANGO.

Issue raised in #13099.

Impact of changes

None

Migration actions required

None

Documentation

None

Pull request type

[x] Patch update (Bug fix / Target update / Docs update / Test update / Refactor)
[] Feature update (New feature / Functionality change / New API)
[] Major update (Breaking change E.g. Return code change / API behaviour change)

Test results

[] No Tests required for this change (E.g docs only update)
[x] Covered by existing mbed-os tests (Greentea or Unittest)
[] Tests / results supplied as part of this PR

Reviewers

Modify RZ_A1XX and RZ_A2XX target configurations to include bare metal as a supported profile,and add list of supported standard libraries. Changes affect the following targets: RZ_A1H, GR_LYCHEE, GR_MANGO.

ciarmcom · 2021-02-18T11:00:20Z

@harmut01, thank you for your changes.
@ARMmbed/mbed-os-maintainers please review.

ciarmcom · 2021-02-20T12:50:12Z

This pull request has automatically been marked as stale because it has had no recent activity. @ARMmbed/mbed-os-maintainers, please start CI to get the PR merged.

0xc0170 · 2021-02-22T12:32:29Z

CI started

0xc0170 · 2021-02-22T14:48:32Z

@harmut01 CI errored early


[2021-02-22T12:34:58.040Z] multiprocessing.pool.RemoteTraceback: 

[2021-02-22T12:34:58.040Z] """

[2021-02-22T12:34:58.040Z] Traceback (most recent call last):

[2021-02-22T12:34:58.040Z]   File "/usr/lib/python3.6/multiprocessing/pool.py", line 119, in worker

[2021-02-22T12:34:58.040Z]     result = (True, func(*args, **kwds))

[2021-02-22T12:34:58.040Z]   File "/usr/lib/python3.6/multiprocessing/pool.py", line 44, in mapstar

[2021-02-22T12:34:58.040Z]     return list(map(*args))

[2021-02-22T12:34:58.040Z]   File "smart-tester/target_toolchain_selector.py", line 92, in get_resources_filenames_target_toolchains

[2021-02-22T12:34:58.040Z]     resources_filenames_target_toolchains[target][toolchain] = get_resources_filenames(".", target, toolchain)

[2021-02-22T12:34:58.040Z]   File "smart-tester/target_toolchain_selector.py", line 32, in get_resources_filenames

[2021-02-22T12:34:58.040Z]     notify=MockNotifier())

[2021-02-22T12:34:58.040Z]   File "./tools/build_api.py", line 514, in prepare_toolchain

[2021-02-22T12:34:58.040Z]     target, notify, macros, build_dir=build_dir, build_profile=profile, coverage_patterns=coverage_patterns)

[2021-02-22T12:34:58.040Z]   File "./tools/toolchains/iar.py", line 64, in __init__

[2021-02-22T12:34:58.040Z]     self.check_c_lib_supported(target, "iar")

[2021-02-22T12:34:58.040Z]   File "./tools/toolchains/mbed_toolchain.py", line 1113, in check_c_lib_supported

[2021-02-22T12:34:58.040Z]     UNSUPPORTED_C_LIB_EXCEPTION_STRING.format(target.c_lib)

[2021-02-22T12:34:58.040Z] tools.utils.NotSupportedException: std C library option not supported for this target.

Please review. I cant find in the logs what "this target" is it

harmut01 · 2021-02-24T16:33:20Z

The issue seems to be unrelated to the changes in this PR, @LDong-Arm has seen the same issue on his PR and raised this commit to fix it.

LDong-Arm · 2021-02-25T13:25:43Z

The CI might have been fixed by #14350, rerunning might work

LDong-Arm · 2021-02-25T13:29:09Z

targets/targets.json

@@ -4841,6 +4841,17 @@
        "program_cycle_s": 2,
        "overrides": {
            "network-default-interface-type": "ETHERNET"
+        },
+        "supported_application_profiles" : ["full", "bare-metal"],
+        "supported_c_libs": {


Please remove IAR from line 4812, to avoid check failure again in CI

Pull request has been modified.

0xc0170 · 2021-03-01T12:49:12Z

CI restarted

mbed-ci · 2021-03-01T15:57:23Z

Jenkins CI Test : ✔️ SUCCESS

Build Number: 2 | 🔒 Jenkins CI Job | 🌐 Logs & Artifacts

CLICK for Detailed Summary

jobs	Status
jenkins-ci/mbed-os-ci_unittests	✔️
jenkins-ci/mbed-os-ci_cmake-example-GCC_ARM	✔️
jenkins-ci/mbed-os-ci_cmake-example-ARM	✔️
jenkins-ci/mbed-os-ci_build-greentea-ARM	✔️
jenkins-ci/mbed-os-ci_build-greentea-GCC_ARM	✔️
jenkins-ci/mbed-os-ci_build-cloud-example-GCC_ARM	✔️
jenkins-ci/mbed-os-ci_build-example-ARM	✔️
jenkins-ci/mbed-os-ci_build-cloud-example-ARM	✔️
jenkins-ci/mbed-os-ci_build-example-GCC_ARM	✔️
jenkins-ci/mbed-os-ci_cmake-example-test	✔️
jenkins-ci/mbed-os-ci_greentea-test	✔️

0xc0170 · 2021-03-05T15:51:17Z

Seems like one of the recent PRs broke master


[2021-03-04T17:45:48.158Z] Previous HEAD position was 76b2902f48 Merge pull request #14354 from ARMmbed/feature-tf-m-1.2-integration

[2021-03-04T17:45:48.158Z] Switched to branch 'mbed-os-ci-test-unique-id'

[2021-03-04T17:45:48.414Z] multiprocessing.pool.RemoteTraceback: 

[2021-03-04T17:45:48.414Z] """

[2021-03-04T17:45:48.414Z] Traceback (most recent call last):

[2021-03-04T17:45:48.414Z]   File "/usr/lib/python3.6/multiprocessing/pool.py", line 119, in worker

[2021-03-04T17:45:48.414Z]     result = (True, func(*args, **kwds))

[2021-03-04T17:45:48.414Z]   File "/usr/lib/python3.6/multiprocessing/pool.py", line 44, in mapstar

[2021-03-04T17:45:48.414Z]     return list(map(*args))

[2021-03-04T17:45:48.414Z]   File "smart-tester/target_toolchain_selector.py", line 92, in get_resources_filenames_target_toolchains

[2021-03-04T17:45:48.414Z]     resources_filenames_target_toolchains[target][toolchain] = get_resources_filenames(".", target, toolchain)

[2021-03-04T17:45:48.414Z]   File "smart-tester/target_toolchain_selector.py", line 32, in get_resources_filenames

[2021-03-04T17:45:48.414Z]     notify=MockNotifier())

[2021-03-04T17:45:48.414Z]   File "./tools/build_api.py", line 514, in prepare_toolchain

[2021-03-04T17:45:48.414Z]     target, notify, macros, build_dir=build_dir, build_profile=profile, coverage_patterns=coverage_patterns)

[2021-03-04T17:45:48.414Z]   File "./tools/toolchains/iar.py", line 64, in __init__

[2021-03-04T17:45:48.414Z]     self.check_c_lib_supported(target, "iar")

[2021-03-04T17:45:48.414Z]   File "./tools/toolchains/mbed_toolchain.py", line 1113, in check_c_lib_supported

[2021-03-04T17:45:48.414Z]     UNSUPPORTED_C_LIB_EXCEPTION_STRING.format(target.c_lib)

[2021-03-04T17:45:48.414Z] tools.utils.NotSupportedException: std C library option not supported for this target.

This is in the latest CI run here but I am seeing this in another PRs now

LDong-Arm · 2021-03-05T16:05:02Z

@0xc0170 I had a quick look at the latest targets.json as of now, KL25Z, KL46Z, MCU_K22F512, KL43Z, K82F all have IAR in supported_toolchains but no iar in supported_c_libs.

0xc0170 · 2021-03-05T16:11:20Z

Thank you, @harmut01 is looking at it

0xc0170 · 2021-03-08T10:53:54Z

CI started

mbed-ci · 2021-03-08T14:47:12Z

Jenkins CI Test : ❌ FAILED

Build Number: 4 | 🔒 Jenkins CI Job | 🌐 Logs & Artifacts

CLICK for Detailed Summary

jobs	Status
jenkins-ci/mbed-os-ci_unittests	✔️
jenkins-ci/mbed-os-ci_cmake-example-ARM	✔️
jenkins-ci/mbed-os-ci_cmake-example-GCC_ARM	✔️
jenkins-ci/mbed-os-ci_build-greentea-ARM	✔️
jenkins-ci/mbed-os-ci_build-cloud-example-ARM	✔️
jenkins-ci/mbed-os-ci_build-greentea-GCC_ARM	✔️
jenkins-ci/mbed-os-ci_build-cloud-example-GCC_ARM	✔️
jenkins-ci/mbed-os-ci_build-example-GCC_ARM	❌
jenkins-ci/mbed-os-ci_build-example-ARM	❌

0xc0170 · 2021-03-09T14:33:44Z

CI restarted

mbed-ci · 2021-03-09T15:43:07Z

Jenkins CI Test : ✔️ SUCCESS

Build Number: 5 | 🔒 Jenkins CI Job | 🌐 Logs & Artifacts

CLICK for Detailed Summary

jobs	Status
jenkins-ci/mbed-os-ci_cmake-example-GCC_ARM	✔️
jenkins-ci/mbed-os-ci_cmake-example-ARM	✔️
jenkins-ci/mbed-os-ci_unittests	✔️
jenkins-ci/mbed-os-ci_build-greentea-GCC_ARM	✔️
jenkins-ci/mbed-os-ci_build-greentea-ARM	✔️
jenkins-ci/mbed-os-ci_build-cloud-example-ARM	✔️
jenkins-ci/mbed-os-ci_build-example-ARM	✔️
jenkins-ci/mbed-os-ci_build-example-GCC_ARM	✔️
jenkins-ci/mbed-os-ci_build-cloud-example-GCC_ARM	✔️
jenkins-ci/mbed-os-ci_greentea-test	✔️
jenkins-ci/mbed-os-ci_cmake-example-test	✔️

Add bare metal support to Renesas targets

15a263f

Modify RZ_A1XX and RZ_A2XX target configurations to include bare metal as a supported profile,and add list of supported standard libraries. Changes affect the following targets: RZ_A1H, GR_LYCHEE, GR_MANGO.

harmut01 requested review from a team and hugueskamba February 18, 2021 10:31

ciarmcom added the release-type: patch Indentifies a PR as containing just a patch label Feb 18, 2021

ciarmcom requested a review from a team February 18, 2021 11:00

ciarmcom added the needs: review label Feb 18, 2021

hugueskamba approved these changes Feb 18, 2021

View reviewed changes

mergify bot added needs: CI and removed needs: review labels Feb 18, 2021

0xc0170 previously approved these changes Feb 18, 2021

View reviewed changes

ciarmcom added the stale Stale Pull Request label Feb 20, 2021

LDong-Arm suggested changes Feb 25, 2021

View reviewed changes

Remove IAR from list of supported toolchains

15e8511

LDong-Arm approved these changes Feb 25, 2021

View reviewed changes

ciarmcom added stale Stale Pull Request and removed stale Stale Pull Request labels Mar 1, 2021

0xc0170 approved these changes Mar 4, 2021

View reviewed changes

harmut01 mentioned this pull request Mar 5, 2021

Freescale: Remove IAR from list of supported toolchains #14386

Merged

mergify bot added ready for merge and removed needs: CI labels Mar 9, 2021

0xc0170 merged commit 5f9fbfe into ARMmbed:master Mar 9, 2021

mergify bot removed ready for merge stale Stale Pull Request labels Mar 9, 2021

dependabot bot mentioned this pull request Mar 10, 2021

Bump mbed-os from f227856 to 0e89f9d uwrobotics/MarsRoverFirmware#319

Closed

mbedmain added release-version: 6.9.0 Release-pending and removed release-type: patch Indentifies a PR as containing just a patch Release-pending labels Mar 15, 2021

Add bare metal support to Renesas targets #14301

Add bare metal support to Renesas targets #14301

Uh oh!

Conversation

harmut01 commented Feb 18, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary of changes

Impact of changes

Migration actions required

Documentation

Pull request type

Test results

Reviewers

Uh oh!

ciarmcom commented Feb 18, 2021

Uh oh!

ciarmcom commented Feb 20, 2021

Uh oh!

0xc0170 commented Feb 22, 2021

Uh oh!

0xc0170 commented Feb 22, 2021

Uh oh!

harmut01 commented Feb 24, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

LDong-Arm commented Feb 25, 2021

Uh oh!

LDong-Arm Feb 25, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

0xc0170 commented Mar 1, 2021

Uh oh!

mbed-ci commented Mar 1, 2021

Jenkins CI Test : ✔️ SUCCESS

Build Number: 2 | 🔒 Jenkins CI Job | 🌐 Logs & Artifacts

Uh oh!

0xc0170 commented Mar 5, 2021

Uh oh!

LDong-Arm commented Mar 5, 2021

Uh oh!

0xc0170 commented Mar 5, 2021

Uh oh!

0xc0170 commented Mar 8, 2021

Uh oh!

mbed-ci commented Mar 8, 2021

Jenkins CI Test : ❌ FAILED

Build Number: 4 | 🔒 Jenkins CI Job | 🌐 Logs & Artifacts

Uh oh!

0xc0170 commented Mar 9, 2021

Uh oh!

mbed-ci commented Mar 9, 2021

Jenkins CI Test : ✔️ SUCCESS

Build Number: 5 | 🔒 Jenkins CI Job | 🌐 Logs & Artifacts

Uh oh!

Uh oh!

harmut01 commented Feb 18, 2021 •

edited

Loading

harmut01 commented Feb 24, 2021 •

edited

Loading

LDong-Arm Feb 25, 2021 •

edited

Loading