Skip to content

Create FLASH CMSIS ALGO target to remove dependency on MBED_TARGET_LABELS #14308

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Feb 22, 2021
Merged

Create FLASH CMSIS ALGO target to remove dependency on MBED_TARGET_LABELS #14308

merged 2 commits into from
Feb 22, 2021

Conversation

hugueskamba
Copy link
Collaborator

Summary of changes

This goes towards eventually removing reliance on targets.json to specify
the requirements of Mbed targets.

Impact of changes

Migration actions required

Documentation

Pull request type 

[x] Patch update (Bug fix / Target update / Docs update / Test update / Refactor)
[] Feature update (New feature / Functionality change / New API)
[] Major update (Breaking change E.g. Return code change / API behaviour change)

Test results 

[] No Tests required for this change (E.g docs only update)
[x] Covered by existing mbed-os tests (Greentea or Unittest)
[] Tests / results supplied as part of this PR

Reviewers

@hugueskamba
Create FLASH CMSIS ALGO target to remove dependency on MBED_TARGET_LA…
7d49d4b 
…BELS

This goes towards eventually removing reliance on targets.json to specify
the requirements of Mbed targets.
@ciarmcom ciarmcom added the release-type: patch Indentifies a PR as containing just a patch label Feb 19, 2021
@ciarmcom ciarmcom requested a review from a team February 19, 2021 17:00
@ciarmcom
Copy link
Member

@hugueskamba, thank you for your changes.
@ARMmbed/mbed-os-maintainers please review.

@hugueskamba
Remove usage of MBED_TARGET_LABELS in hal/ tests
c45e6ce 
This removes some dependency on targets.json
@hugueskamba hugueskamba force-pushed the hk_cmake_create_flash_cmsis_algo branch from d081e85 to c45e6ce Compare February 19, 2021 19:15
@mergify mergify bot added needs: CI and removed needs: review labels Feb 22, 2021
@0xc0170
Copy link
Contributor

0xc0170 commented Feb 22, 2021

CI started

@mbed-ci
Copy link

mbed-ci commented Feb 22, 2021

Jenkins CI Test : ✔️ SUCCESS

Build Number: 1 | 🔒 Jenkins CI Job | 🌐 Logs & Artifacts

CLICK for Detailed Summary

jobs Status
jenkins-ci/mbed-os-ci_unittests ✔️
jenkins-ci/mbed-os-ci_cmake-example-ARM ✔️
jenkins-ci/mbed-os-ci_cmake-example-GCC_ARM ✔️
jenkins-ci/mbed-os-ci_build-greentea-ARM ✔️
jenkins-ci/mbed-os-ci_build-example-ARM ✔️
jenkins-ci/mbed-os-ci_build-greentea-GCC_ARM ✔️
jenkins-ci/mbed-os-ci_build-cloud-example-ARM ✔️
jenkins-ci/mbed-os-ci_build-cloud-example-GCC_ARM ✔️
jenkins-ci/mbed-os-ci_build-example-GCC_ARM ✔️
jenkins-ci/mbed-os-ci_cmake-example-test ✔️
jenkins-ci/mbed-os-ci_greentea-test ✔️

0xc0170
0xc0170 reviewed Feb 22, 2021
View reviewed changes
Copy link
Contributor

@0xc0170 0xc0170 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Currently target gets FLASH_CMSIS_ALGO by defining extra label. I dont see this reflected in CMake or is it?

NUMAKER_PFM_NUC472 for instance would need mbed-flash-cmsis-algo so it should link to it. Or is it done automatically? I don't recall we query all target labels if they exists as CMake targets and link to it (we do it for only MBED_TARGET).

@hugueskamba
Copy link
Collaborator Author

hugueskamba commented Feb 22, 2021 •
edited
Loading

Currently target gets FLASH_CMSIS_ALGO by defining extra label. I dont see this reflected in CMake or is it?

NUMAKER_PFM_NUC472 for instance would need mbed-flash-cmsis-algo so it should link to it. Or is it done automatically? I don't recall we query all target labels if they exists as CMake targets and link to it (we do it for only MBED_TARGET).

The Mbed boards which require FLASH_CMSIS_ALGO link the newly added CMake library target.
For instance NUMAKER_PFM_NUC472 gets it because of the changes made to the targets/TARGET_NUVOTON/TARGET_NUC472/CMakeLists.txt.

@0xc0170
Copy link
Contributor

0xc0170 commented Feb 22, 2021 •
edited
Loading

I've missed it in the diff the changes when I looked at this after CI. I'll merge now

@0xc0170 0xc0170 merged commit 3bb8de6 into ARMmbed:master Feb 22, 2021
@mergify mergify bot removed the ready for merge label Feb 22, 2021
@hugueskamba hugueskamba deleted the hk_cmake_create_flash_cmsis_algo branch February 22, 2021 15:49
@mbedmain mbedmain removed the release-type: patch Indentifies a PR as containing just a patch label Feb 22, 2021
@mergify
Copy link

mergify bot commented Feb 22, 2021

This PR does not contain release version label after merging.

@mergify mergify bot added the release version missing When PR does not contain release version, bot should label it and we fix it afterwards label Feb 22, 2021
@0xc0170 0xc0170 removed the release version missing When PR does not contain release version, bot should label it and we fix it afterwards label Jun 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@0xc0170 0xc0170 0xc0170 approved these changes

Assignees
No one assigned
Labels
component: hal devices: analog devices devices: nuvoton devices: nxp
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@hugueskamba @ciarmcom @0xc0170 @mbed-ci @mbedmain