Skip to content

CMake: Fix STM32F091XC Mbed targets GCC_ARM build #14309

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

hugueskamba
Copy link
Collaborator

Summary of changes

The linker file for the GCC_ARM toolchain was not correctly listed.

Impact of changes

Migration actions required

Documentation


Pull request type

[x] Patch update (Bug fix / Target update / Docs update / Test update / Refactor)
[] Feature update (New feature / Functionality change / New API)
[] Major update (Breaking change E.g. Return code change / API behaviour change)

Test results

[] No Tests required for this change (E.g docs only update)
[x] Covered by existing mbed-os tests (Greentea or Unittest)
[] Tests / results supplied as part of this PR

Reviewers


The linker file for the GCC_ARM toolchain was not
correctly listed.
@ciarmcom ciarmcom added the release-type: patch Indentifies a PR as containing just a patch label Feb 19, 2021
@ciarmcom
Copy link
Member

@hugueskamba, thank you for your changes.
@ARMmbed/mbed-os-maintainers please review.

@0xc0170
Copy link
Contributor

0xc0170 commented Feb 22, 2021

CI started

@mbed-ci
Copy link

mbed-ci commented Feb 22, 2021

Jenkins CI Test : ✔️ SUCCESS

Build Number: 1 | 🔒 Jenkins CI Job | 🌐 Logs & Artifacts

CLICK for Detailed Summary

jobs Status
jenkins-ci/mbed-os-ci_cmake-example-ARM ✔️
jenkins-ci/mbed-os-ci_unittests ✔️
jenkins-ci/mbed-os-ci_cmake-example-GCC_ARM ✔️
jenkins-ci/mbed-os-ci_build-example-GCC_ARM ✔️
jenkins-ci/mbed-os-ci_build-greentea-ARM ✔️
jenkins-ci/mbed-os-ci_build-cloud-example-GCC_ARM ✔️
jenkins-ci/mbed-os-ci_build-greentea-GCC_ARM ✔️
jenkins-ci/mbed-os-ci_build-example-ARM ✔️
jenkins-ci/mbed-os-ci_build-cloud-example-ARM ✔️
jenkins-ci/mbed-os-ci_cmake-example-test ✔️
jenkins-ci/mbed-os-ci_greentea-test ✔️

@0xc0170 0xc0170 merged commit dbbdd0f into ARMmbed:master Feb 22, 2021
@mergify mergify bot removed the ready for merge label Feb 22, 2021
@hugueskamba hugueskamba deleted the hk_cmake_fix_stm32f091xc_gcc_arm branch February 22, 2021 16:37
@mbedmain mbedmain removed the release-type: patch Indentifies a PR as containing just a patch label Feb 22, 2021
@mergify
Copy link

mergify bot commented Feb 22, 2021

This PR does not contain release version label after merging.

@mergify mergify bot added the release version missing When PR does not contain release version, bot should label it and we fix it afterwards label Feb 22, 2021
@0xc0170 0xc0170 added release-type: patch Indentifies a PR as containing just a patch release-version: 6.10.0 and removed release version missing When PR does not contain release version, bot should label it and we fix it afterwards labels Jun 22, 2021
@mbedmain mbedmain removed the release-type: patch Indentifies a PR as containing just a patch label Jun 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants