Skip to content

MAX32625: Fix CMake build #14316

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 22, 2021
Merged

MAX32625: Fix CMake build #14316

merged 1 commit into from
Feb 22, 2021

Conversation

hugueskamba
Copy link
Collaborator

Summary of changes

  • Correct board CMake target name to match board name
  • Make MAX32625 depend on MAXIM CMake target to inherit its include dirs
  • Correct path to linker files

Impact of changes

Migration actions required

Documentation

Pull request type 

[x] Patch update (Bug fix / Target update / Docs update / Test update / Refactor)
[] Feature update (New feature / Functionality change / New API)
[] Major update (Breaking change E.g. Return code change / API behaviour change)

Test results 

[] No Tests required for this change (E.g docs only update)
[x] Covered by existing mbed-os tests (Greentea or Unittest)
[] Tests / results supplied as part of this PR

Reviewers

@hugueskamba
MAX32625: Fix CMake build
80c679c 
* Correct board CMake target name to match board name
* Make MAX32625 depend on MAXIM CMake target to inherit its include dirs
* Correct path to linker files
@ciarmcom ciarmcom added the release-type: patch Indentifies a PR as containing just a patch label Feb 22, 2021
@ciarmcom
Copy link
Member

@hugueskamba, thank you for your changes.
@ARMmbed/mbed-os-maintainers please review.

@ciarmcom ciarmcom requested a review from a team February 22, 2021 14:00
@0xc0170
Copy link
Contributor

0xc0170 commented Feb 22, 2021

CI started

@mergify mergify bot added needs: CI and removed needs: review labels Feb 22, 2021
@mbed-ci
Copy link

mbed-ci commented Feb 22, 2021

Jenkins CI Test : ✔️ SUCCESS

Build Number: 1 | 🔒 Jenkins CI Job | 🌐 Logs & Artifacts

CLICK for Detailed Summary

jobs Status
jenkins-ci/mbed-os-ci_unittests ✔️
jenkins-ci/mbed-os-ci_cmake-example-ARM ✔️
jenkins-ci/mbed-os-ci_build-example-ARM ✔️
jenkins-ci/mbed-os-ci_build-example-GCC_ARM ✔️
jenkins-ci/mbed-os-ci_cmake-example-GCC_ARM ✔️
jenkins-ci/mbed-os-ci_build-greentea-GCC_ARM ✔️
jenkins-ci/mbed-os-ci_build-cloud-example-GCC_ARM ✔️
jenkins-ci/mbed-os-ci_build-greentea-ARM ✔️
jenkins-ci/mbed-os-ci_build-cloud-example-ARM ✔️
jenkins-ci/mbed-os-ci_cmake-example-test ✔️
jenkins-ci/mbed-os-ci_greentea-test ✔️

@0xc0170 0xc0170 merged commit 778f833 into ARMmbed:master Feb 22, 2021
@mergify mergify bot removed the ready for merge label Feb 22, 2021
@hugueskamba hugueskamba deleted the hk_cmake_fix_max32625 branch February 23, 2021 09:56
@mbedmain mbedmain added release-version: 6.9.0 Release-pending and removed release-type: patch Indentifies a PR as containing just a patch Release-pending labels Mar 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Patater Patater Patater approved these changes

@0xc0170 0xc0170 0xc0170 approved these changes

@harmut01 harmut01 harmut01 approved these changes

@saheerb saheerb Awaiting requested review from saheerb

@rajkan01 rajkan01 Awaiting requested review from rajkan01

Assignees
No one assigned
Labels
devices: maxim release-version: 6.9.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@hugueskamba @ciarmcom @0xc0170 @mbed-ci @Patater @harmut01 @mbedmain