Skip to content

[DISCO_F746NG] missing gcc_arm in targets.py, travis build and dsp #1438

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Nov 20, 2015

Conversation

ohagendorf
Copy link
Contributor

  • adding missing GCC_ARM to target in targets.py
  • updating dsp cmsis lib to current v4.5 because of missing cortex m7 in existing version
  • adding linker option for float support in printf/scanf to be able to run both dsp test

Please see test results in the commits.

'normal' tests are OK, RTOS builds fail:

+--------------+--------------+-----------+-------------+---------------------------------------+--------------------+---------------+-------+
| Result | Target | Toolchain | Test ID | Test Description | Elapsed Time (sec) | Timeout (sec) | Loops |
+--------------+--------------+-----------+-------------+---------------------------------------+--------------------+---------------+-------+
| OK | DISCO_F746NG | GCC_ARM | DTCT_1 | Simple detect test | 0.5 | 10 | 1/1 |
| OK | DISCO_F746NG | GCC_ARM | EXAMPLE_1 | /dev/null | 3.43 | 20 | 1/1 |
| OK | DISCO_F746NG | GCC_ARM | MBED_10 | Hello World | 0.36 | 5 | 1/1 |
| OK | DISCO_F746NG | GCC_ARM | MBED_11 | Ticker Int | 11.37 | 15 | 1/1 |
| OK | DISCO_F746NG | GCC_ARM | MBED_12 | C++ | 1.37 | 10 | 1/1 |
| OK | DISCO_F746NG | GCC_ARM | MBED_16 | RTC | 4.74 | 20 | 1/1 |
| OK | DISCO_F746NG | GCC_ARM | MBED_2 | stdio | 0.8 | 20 | 1/1 |
| OK | DISCO_F746NG | GCC_ARM | MBED_23 | Ticker Int us | 11.35 | 15 | 1/1 |
| OK | DISCO_F746NG | GCC_ARM | MBED_24 | Timeout Int us | 11.37 | 15 | 1/1 |
| OK | DISCO_F746NG | GCC_ARM | MBED_25 | Time us | 11.37 | 15 | 1/1 |
| OK | DISCO_F746NG | GCC_ARM | MBED_26 | Integer constant division | 1.38 | 20 | 1/1 |
| OK | DISCO_F746NG | GCC_ARM | MBED_34 | Ticker Two callbacks | 11.4 | 15 | 1/1 |
| OK | DISCO_F746NG | GCC_ARM | MBED_37 | Serial NC RX | 10.91 | 20 | 1/1 |
| OK | DISCO_F746NG | GCC_ARM | MBED_38 | Serial NC TX | 15.4 | 20 | 1/1 |
| OK | DISCO_F746NG | GCC_ARM | MBED_A1 | Basic | 1.36 | 20 | 1/1 |
| OK | DISCO_F746NG | GCC_ARM | MBED_A21 | Call function before main (mbed_main) | 1.43 | 20 | 1/1 |
| OK | DISCO_F746NG | GCC_ARM | MBED_A9 | Serial Echo at 115200 | 6.51 | 20 | 1/1 |
| OK | DISCO_F746NG | GCC_ARM | MBED_BUSOUT | BusOut | 2.27 | 15 | 1/1 |
| BUILD_FAILED | DISCO_F746NG | GCC_ARM | RTOS_1 | Toolchain build failed | 0 | 0 | - |
| BUILD_FAILED | DISCO_F746NG | GCC_ARM | RTOS_2 | Toolchain build failed | 0 | 0 | - |
| BUILD_FAILED | DISCO_F746NG | GCC_ARM | RTOS_3 | Toolchain build failed | 0 | 0 | - |
| BUILD_FAILED | DISCO_F746NG | GCC_ARM | RTOS_4 | Toolchain build failed | 0 | 0 | - |
| BUILD_FAILED | DISCO_F746NG | GCC_ARM | RTOS_5 | Toolchain build failed | 0 | 0 | - |
| BUILD_FAILED | DISCO_F746NG | GCC_ARM | RTOS_6 | Toolchain build failed | 0 | 0 | - |
| BUILD_FAILED | DISCO_F746NG | GCC_ARM | RTOS_7 | Toolchain build failed | 0 | 0 | - |
| BUILD_FAILED | DISCO_F746NG | GCC_ARM | RTOS_8 | Toolchain build failed | 0 | 0 | - |
+--------------+--------------+-----------+-------------+---------------------------------------+--------------------+---------------+-------+
Result: 8 BUILD_FAILED / 18 OK
update was necessary to switching on the dsp lib for Cortex M7 (DISCO_F746)
both dsp tests (CMSIS_DSP_1, DSP_1) are OK with DISCO_F746 and DISCO_L476
adding "-u_printf_float", "-u_scanf_float" for disco_f746
@0xc0170
Copy link
Contributor

0xc0170 commented Nov 19, 2015

Please dont mix feature-sets within one PR , the 1st and 3rd commits could be merged right away. I have to now check the big commit changing >250 files no related to those 2 commits :)

@0xc0170
Copy link
Contributor

0xc0170 commented Nov 19, 2015

Can you please remove the 2nd commit and send it separately? Will be easier to review + test + integrate

@ohagendorf
Copy link
Contributor Author

I combined the commits because they are not independent - without the second one the first/last would get a failure during travis build. I started with the first commit because of issue #1435

There seems to be a small bug in travis build - thats why the dsp problem wasn't seen before by anybody:

  • DISCO_F746 was already in travis build with fat and dsp library and gcc_arm as compiler
  • DISCO_F746 was already in targets.py but WITHOUT gcc_arm
  • this target was never build during travis build:
    • after adding gcc_arm to DISCO_F746 config in targets.py I got a dsp library compile failure - the dsp library version didn't support Cortex M7

The second commit is the original ARM CMSIS dsp library code without any changes except math_helper.h. That file was not change through the commit. The only difference between mbed version and ARM version is an extern "C" { ... }

So when I resubmit 2 PRs, one with first and last commit and the other with the second commit both have to be included into the main branch at the same time. When not the travis build would fail.

Do you still want that I put this PR into two different?

@0xc0170
Copy link
Contributor

0xc0170 commented Nov 20, 2015

Thanks for clarification, let's leave it for as it is.

0xc0170 added a commit that referenced this pull request Nov 20, 2015
[DISCO_F746NG] missing gcc_arm in targets.py, travis build and dsp
@0xc0170 0xc0170 merged commit 2b2e0d5 into ARMmbed:master Nov 20, 2015
@ohagendorf ohagendorf deleted the dsp_lib branch November 20, 2015 09:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants