Skip to content

SDP-K1: enable IAR compilation #14421

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 22, 2021
Merged

Conversation

jeromecoutant
Copy link
Collaborator

Summary of changes

Issue with mbed-os-6.8.0:

[Error] PeripheralPins.c@435,25: [Pe029]: expected an expression
[Error] PeripheralPins.c@427,0: [Pe1345]: an empty initializer is invalid for an array with unspecified bound
[ERROR]
  };
  ^
"xxx\targets\TARGET_STM\TARGET_STM32F4\TARGET_STM32F469xI\TARGET_SDP_K1\PeripheralPins.c",435  Error[Pe029]: expected an expression

  MBED_WEAK const PinMap PinMap_USB_FS[] = {
                         ^
"xxx\targets\TARGET_STM\TARGET_STM32F4\TARGET_STM32F469xI\TARGET_SDP_K1\PeripheralPins.c",427  Error[Pe1345]: an empty initializer is invalid for an array with unspecified bound

Impact of changes

Migration actions required

Documentation


Pull request type

[x] Patch update (Bug fix / Target update / Docs update / Test update / Refactor)
[] Feature update (New feature / Functionality change / New API)
[] Major update (Breaking change E.g. Return code change / API behaviour change)

Test results

[] No Tests required for this change (E.g docs only update)
[x] Covered by existing mbed-os tests (Greentea or Unittest)
[] Tests / results supplied as part of this PR

Reviewers

@kylejansen


@ciarmcom ciarmcom added the release-type: patch Indentifies a PR as containing just a patch label Mar 11, 2021
@ciarmcom ciarmcom requested a review from a team March 11, 2021 15:00
@ciarmcom
Copy link
Member

@jeromecoutant, thank you for your changes.
@ARMmbed/mbed-os-maintainers please review.

@kjansen-adi
Copy link
Contributor

Looks good to me

Copy link
Contributor

@0xc0170 0xc0170 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I assume as there is no USB_FS, leaving this out would cause a compiler failure - rather than keeping it in with just NC fields.

@0xc0170
Copy link
Contributor

0xc0170 commented Mar 11, 2021

CI started

@mbed-ci
Copy link

mbed-ci commented Mar 11, 2021

Jenkins CI Test : ✔️ SUCCESS

Build Number: 1 | 🔒 Jenkins CI Job | 🌐 Logs & Artifacts

CLICK for Detailed Summary

jobs Status
jenkins-ci/mbed-os-ci_unittests ✔️
jenkins-ci/mbed-os-ci_cmake-example-GCC_ARM ✔️
jenkins-ci/mbed-os-ci_cmake-example-ARM ✔️
jenkins-ci/mbed-os-ci_build-greentea-GCC_ARM ✔️
jenkins-ci/mbed-os-ci_build-greentea-ARM ✔️
jenkins-ci/mbed-os-ci_build-example-ARM ✔️
jenkins-ci/mbed-os-ci_build-example-GCC_ARM ✔️
jenkins-ci/mbed-os-ci_build-cloud-example-ARM ✔️
jenkins-ci/mbed-os-ci_build-cloud-example-GCC_ARM ✔️
jenkins-ci/mbed-os-ci_greentea-test ✔️
jenkins-ci/mbed-os-ci_cmake-example-test ✔️

@0xc0170
Copy link
Contributor

0xc0170 commented Mar 12, 2021

I restarted travis.

@0xc0170 0xc0170 closed this Mar 12, 2021
@0xc0170
Copy link
Contributor

0xc0170 commented Mar 12, 2021

I could not restart travis, reopening in a minute

@mergify mergify bot removed devices: st needs: CI release-type: patch Indentifies a PR as containing just a patch labels Mar 12, 2021
@jeromecoutant
Copy link
Collaborator Author

@0xc0170 ping

@0xc0170 0xc0170 reopened this Mar 19, 2021
@0xc0170 0xc0170 added release-type: patch Indentifies a PR as containing just a patch needs: CI labels Mar 19, 2021
@0xc0170 0xc0170 merged commit 83adad9 into ARMmbed:master Mar 22, 2021
@mergify mergify bot removed the ready for merge label Mar 22, 2021
@jeromecoutant jeromecoutant deleted the PR_SDPUSB branch March 22, 2021 10:01
@mbedmain mbedmain removed the release-type: patch Indentifies a PR as containing just a patch label Apr 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants